#216 fix symfony custom filename strategy#218
Merged
SimonMellerin merged 4 commits intomainfrom Mar 28, 2025
Merged
Conversation
SimonMellerin
force-pushed
the
216-fix-symfony-custom-filename-strategy
branch
from
b0aa1c6 to
2c85cab
Compare
Lonnytunes
approved these changes
Mar 28, 2025
pounard
reviewed
Mar 28, 2025
| foreach ($config['connections'] as $connectionName => $connectionConfig) { | ||
| // Default is handled directly by the storage service. | ||
| $strategyId = $connectionConfig['storage_filename_strategy'] ?? null; | ||
| $strategyId = $connectionConfig['storage_filename_strategy'] ?? $config['storage_filename_strategy'] ?? null; |
Member
There was a problem hiding this comment.
This is not good, we have a configuration object for each user defined configuration, which falls back on a default configuration object at runtime when fetching its configuration. You should have checked that the default configuration is rightly populated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.