ci(shred-proxy): accept static-pie in the release linkage assert#79
Merged
Conversation
The musl release build links as a PIE by default, which `file` reports as "static-pie linked" (no interpreter, no shared-lib deps — still fully static) rather than "statically linked". The release workflow's linkage assertion grepped only for "statically linked" and so rejected a genuinely static binary, failing the shred-proxy-v* release at the staging step. Accept both wordings.
ben-dz
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
shred-proxy-v0.1.0release run failed at the Stage artifact + checksum step, even though the binary built fine. The staging step asserts the artifact is static and refuses to publish otherwise:```
dist/shred-proxy-x86_64-unknown-linux-musl: ELF 64-bit LSB pie executable, x86-64, ..., static-pie linked, ...
error: shred-proxy-x86_64-unknown-linux-musl is not statically linked — refusing to publish
```
The binary is static — a musl release build links as a PIE by default, which
filereports asstatic-pie linked(no interpreter, no shared-lib deps) rather thanstatically linked. The assert grepped only for the literalstatically linked, so it rejected a genuinely static artifact.Fix
Accept both wordings in the linkage assert (
grep -Eq 'statically linked|static-pie linked'). CHANGELOG updated.Follow-up
Once merged, re-fire the release (re-point
shred-proxy-v0.1.0at the merge commit, orworkflow_dispatchfrommainwithtag=shred-proxy-v0.1.0) so the GitHub Release + binary are published. The installer one-liner is already live at https://get.doublezero.xyz/shred-proxy and will work end-to-end once the Release exists.