Refactor to use GizmoSQLConnection class#699
Open
sjruhland wants to merge 1 commit into
Open
Conversation
Updates GizmoSQL connection to use the dedicated GizmoSQLConnection class from @malloydata/db-duckdb instead of DuckDBConnection with a useGizmoSQL flag. This follows the established pattern where different client libraries use separate connection classes (similar to DuckDBWasmConnection). Signed-off-by: Schyler Ruhland <schyler@summation.com>
sjruhland
force-pushed
the
sr/use-gizmosql-connection-class
branch
from
757e54f to
94f247b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GizmoSQLConnectionclass from@malloydata/db-duckdbuseGizmoSQLflag approach in favor of separate class instantiationChanges
DuckDBConnectiontoGizmoSQLConnectionGizmoSQLConnectionOptionsinterfaceContext
This aligns the VSCode extension with the architectural pattern where different client implementations use separate connection classes (similar to
DuckDBWASMConnection), rather than embedding alternative backends in a single class.Depends on: malloydata/malloy#2582