Respect # hidden tag in chart channel assignment#2743
Open
jswir wants to merge 3 commits into
Open
Conversation
Hidden dimensions are now excluded from automatic x/y/series channel inference, so they remain in the query data (e.g. for order_by) without being rendered on the chart. Explicit channel tags on hidden fields are still honored. Made-with: Cursor
Apply the same fix from bar charts to line charts: skip hidden dimensions during auto channel assignment and embedded tag walking, so they can be used for order_by without appearing as axes or series.
4 tasks
jswir
force-pushed
the
fix/bar-chart-hidden-dimensions
branch
from
0c0325d to
e56e41c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# hidden) are now excluded from automatic channel assignment (x, y, series) in both bar and line charts# hidden # x) are still assigned normallyorder_bywithout rendering it as an axis or seriesTest plan
hidden_dimensionbar chart story renders correctly (brand on x-axis, ordered by dcId, dcId not visible)hidden_dimensionline chart story renders correctly# xtag still gets assigned to the x channel🤖 Generated with Claude Code