increase account retrys to help with older airtags initial sync#218
Conversation
|
I'm a bit hesitant to merge this into main, as there are circumstances where it's better to fail fast than succeed slowly. With the current backoff logic it would take several minutes to exhaust 20 retries, so I think it should either be kept relatively low or it should be configurable. I can merge it into a separate branch to provide people with an easy fix if they run into it, though. Then when the whole accessory importing mess is fixed it can be deleted, as you would only really run into this when doing long syncs. |
|
What about making it configurable with the default of 5 instead of hard-coding it? |
|
I kind of want to avoid fossilizing this into the API, because I still have hope that the underlying issue is a temporary problem on Apple's side. If we make it configurable and people start specifying the argument then we also need to handle the case when it is deprecated again in the future. Ideally this is a problem that FindMy.py should be able to 'fix' transparently from the user. Under normal, non-initial-syncing circumstances a max retry of 5 should be more than enough. Maybe if this issue persists it could be implemented as a generic 'retry counter', but I'd rather wait a bit longer still. |
Due to apple server errors, older airtags take long enough to the sync always fails with a 5 retry limit.
For airtags ~2yrs old, the highest retry needed was 16, and took over 20 minutes for the initial sync.