Skip to content

Fix 1 DAGSTER_AUTH_ADMIN_PASSWORD bootstrap bug and 1 logging bug for DAGSTER_AUTH_SECRET_KEY #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hongha912 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix 1 DAGSTER_AUTH_ADMIN_PASSWORD bootstrap bug and 1 logging bug for DAGSTER_AUTH_SECRET_KEY #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dagster_authkit/auth/backends/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def change_role(self, username: str, new_role: Role, performed_by: str = "system

def _bootstrap_admin(self):
"""Auto-creates admin user if specified in configuration."""
admin_pass = self.config.get("DAGSTER_AUTH_ADMIN_PASSWORD")
admin_pass = self.config.get("ADMIN_PASSWORD")
if admin_pass and not self.get_user("admin"):
self.add_user(
username="admin",
Expand Down
2 changes: 1 addition & 1 deletion dagster_authkit/utils/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def __init__(self):
self.ENV = os.getenv("DAGSTER_AUTH_ENV", "production")

# Session settings
self.SECRET_KEY = os.getenv("DAGSTER_AUTH_SECRET_KEY", self._generate_secret_key())
self.SECRET_KEY = os.getenv("DAGSTER_AUTH_SECRET_KEY") or self._generate_secret_key()
self.SESSION_COOKIE_NAME = os.getenv("DAGSTER_AUTH_COOKIE_NAME", "dagster_session")
self.SESSION_MAX_AGE = int(os.getenv("DAGSTER_AUTH_SESSION_MAX_AGE", "86400")) # 24h
self.SESSION_COOKIE_SECURE = (
Expand Down