feat: Update reverse operations to Python3#17
Open
davidxbors wants to merge 1 commit into
Open
Conversation
razvand
requested changes
Mar 5, 2023
razvand
left a comment
razvand
left a comment
Member
There was a problem hiding this comment.
Thanks, @davidxbors, see my minor comments. I'll test this more extensively and then come back with another round of review.
davidxbors
force-pushed
the
update-reverse-to-python3
branch
from
2d9fbaa to
e41ab93
Compare
razvand
reviewed
Mar 5, 2023
razvand
left a comment
razvand
left a comment
Member
There was a problem hiding this comment.
@davidxbors, there are still places where this doesn't work on Python3. I'm doing testing now to (hopefully) get all places that require updates.
Up until now all reverse operations needed `Python2` to run. This lead to a user needing to have 2 different versions of Python installed on their system. Now, only `Python3` is required to run all `Sandblaster` operations. Signed-off-by: David Bors <daviddvd267@gmail.com>
davidxbors
force-pushed
the
update-reverse-to-python3
branch
from
852c60d to
aca1685
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up until now all reverse operations needed
Python2to run. This lead to a user needing to have 2 different versions of Python installed on their system. Now, onlyPython3is required to run allSandblasteroperations.