Skip to content

Commit ec8e570

Browse files
committed
Split arrow writes
1 parent 48aedd6 commit ec8e570

1 file changed

Lines changed: 52 additions & 24 deletions

File tree

cpp/arcticdb/arrow/test/benchmark_arrow_writes.cpp

Lines changed: 52 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -76,44 +76,72 @@ static void BM_arrow_convert_multiple_record_batches_to_segment(benchmark::State
7676
}
7777

7878
BENCHMARK(BM_arrow_convert_single_record_batch_to_segment)
79-
// Numeric data
80-
// Short and wide
79+
->Name("BM_arrow_convert_single_record_batch_to_segment_short_and_wide_numeric")
8180
->Args({10, 100'000, -1, true})
8281
->Args({10, 100'000, 0, true})
8382
->Args({10, 100'000, 50'000, true})
84-
// Long and thin
85-
->Args({10'000'000, 10, -1, true})
86-
->Args({10'000'000, 10, 0, true})
87-
->Args({10'000'000, 10, 5, true})
88-
// String data
89-
// Short and wide
83+
->ArgNames({"num_rows", "num_columns", "index_column", "numeric_data"});
84+
85+
BENCHMARK(BM_arrow_convert_single_record_batch_to_segment)
86+
->Name("BM_arrow_convert_single_record_batch_to_segment_short_and_wide_string")
9087
->Args({10, 100'000, -1, false})
9188
->Args({10, 100'000, 0, false})
9289
->Args({10, 100'000, 50'000, false})
93-
// Long and thin - Windows CI can't handle this
90+
->ArgNames({"num_rows", "num_columns", "index_column", "numeric_data"});
91+
92+
BENCHMARK(BM_arrow_convert_single_record_batch_to_segment)
93+
->Name("BM_arrow_convert_single_record_batch_to_segment_long_and_thin_numeric")
94+
->Args({10'000'000, 10, -1, true})
95+
->Args({10'000'000, 10, 0, true})
96+
->Args({10'000'000, 10, 5, true})
97+
->ArgNames({"num_rows", "num_columns", "index_column", "numeric_data"});
98+
99+
// Windows CI can't handle this
94100
#ifndef WIN32
95-
->Args({10'000'000, 10, -1, false})
96-
->Args({10'000'000, 10, 0, false})
97-
->Args({10'000'000, 10, 5, false})
101+
BENCHMARK(BM_arrow_convert_single_record_batch_to_segment)
102+
->Name("BM_arrow_convert_single_record_batch_to_segment_long_and_thin_string")
103+
->Args({10'000'000, 10, -1, true})
104+
->Args({10'000'000, 10, 0, true})
105+
->Args({10'000'000, 10, 5, true})
106+
->ArgNames({"num_rows", "num_columns", "index_column", "numeric_data"});
98107
#endif
99-
;
100108

101109
BENCHMARK(BM_arrow_convert_multiple_record_batches_to_segment)
102-
// Numeric data
103-
// Short and wide
110+
->Name("BM_arrow_convert_multiple_record_batches_to_segment_short_and_wide_numeric")
104111
->Args({10, 100'000, 10, true})
105-
// Long and thin
112+
->ArgNames({"num_rows", "num_columns", "num_record_batches", "numeric_data"});
113+
114+
BENCHMARK(BM_arrow_convert_multiple_record_batches_to_segment)
115+
->Name("BM_arrow_convert_multiple_record_batches_to_segment_long_and_thin_numeric")
106116
->Args({10'000'000, 10, 100, true})
107117
->Args({10'000'000, 10, 10'000, true})
108-
// Highly fragmented
118+
->ArgNames({"num_rows", "num_columns", "num_record_batches", "numeric_data"});
119+
;
120+
121+
BENCHMARK(BM_arrow_convert_multiple_record_batches_to_segment)
122+
->Name("BM_arrow_convert_multiple_record_batches_to_segment_numeric_fragmented")
109123
->Args({1'000, 10, 1'000, true})
110-
// String data
111-
// Short and wide
124+
->ArgNames({"num_rows", "num_columns", "num_record_batches", "numeric_data"});
125+
;
126+
127+
BENCHMARK(BM_arrow_convert_multiple_record_batches_to_segment)
128+
->Name("BM_arrow_convert_multiple_record_batches_to_segment_short_and_wide_numeric")
112129
->Args({10, 100'000, 10, false})
113-
// Long and thin - Windows CI can't handle this
130+
->ArgNames({"num_rows", "num_columns", "num_record_batches", "numeric_data"});
131+
;
132+
133+
// Windows CI can't handle this
114134
#ifndef WIN32
115-
->Args({10'000'000, 10, 100, false})
116-
->Args({10'000'000, 10, 10'000, false})
135+
BENCHMARK(BM_arrow_convert_multiple_record_batches_to_segment)
136+
->Name("BM_arrow_convert_multiple_record_batches_to_segment_long_and_thin_string")
137+
->Args({10'000'000, 10, 100, true})
138+
->Args({10'000'000, 10, 10'000, true})
139+
->ArgNames({"num_rows", "num_columns", "num_record_batches", "numeric_data"});
140+
;
117141
#endif
118-
// Highly fragmented
119-
->Args({1'000, 10, 1'000, false});
142+
143+
BENCHMARK(BM_arrow_convert_multiple_record_batches_to_segment)
144+
->Name("BM_arrow_convert_multiple_record_batches_to_segment_numeric_fragmented")
145+
->Args({1'000, 10, 1'000, false})
146+
->ArgNames({"num_rows", "num_columns", "num_record_batches", "numeric_data"});
147+
;

0 commit comments

Comments
 (0)