Expose loggers logic#3132
Open
ognyanstoimenov wants to merge 1 commit into
Open
Conversation
ognyanstoimenov
commented
May 22, 2026
| .export_values(); | ||
| } | ||
|
|
||
| void register_log(py::module&& log, arcticdb::BindingScope scope) { |
Collaborator
Author
There was a problem hiding this comment.
Copy-pasted from cpp/arcticdb/python/python_module.cpp. Only changed to accept BindingScope and made the exposed methods not take choose_logger by ref as it goes out of scope. Which I am not sure how it worked OK before
Contributor
ArcticDB Code Review SummaryPR Title & Description
Notes (no action required)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Used in https://github.com/man-group/arcticdb-enterprise/pull/329
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...