Skip to content

Commit 60f4416

Browse files
committed
Remove mcaf-dotnet-semgrep skill
1 parent a7185ae commit 60f4416

File tree

9 files changed

+8
-173
lines changed

9 files changed

+8
-173
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ Platform-specific bundles can stay small and still be explicit.
115115
For example, a typical .NET repo baseline can install `mcaf-dotnet` as the entry skill, `mcaf-dotnet-features`, `mcaf-solution-governance`, `mcaf-testing`, exactly one of `mcaf-dotnet-xunit`, `mcaf-dotnet-tunit`, or `mcaf-dotnet-mstest`, plus `mcaf-dotnet-quality-ci`, `mcaf-dotnet-complexity`, `mcaf-solid-maintainability`, `mcaf-architecture-overview`, and `mcaf-ci-cd`.
116116
In that setup, `mcaf-dotnet` knows when to open the more specific .NET skills, the repo-root lowercase `.editorconfig` is the default source of truth for formatting and analyzer severity, and `AGENTS.md` records the exact `dotnet build`, `dotnet test`, `dotnet format`, `analyze`, and coverage commands. Nested `.editorconfig` files are allowed when they serve a clear subtree-specific purpose, such as stricter domain rules, generated-code handling, test-specific conventions, or legacy-code containment.
117117
For .NET code changes, the task is not done when tests are green if the repo also configured formatters, analyzers, coverage, architecture tests, or security gates. Agents should run the repo-defined post-change quality pass before completion.
118-
If the repo standardizes on concrete tools, install the matching tool skills as well. Typical open or free .NET additions include `mcaf-dotnet-format`, `mcaf-dotnet-code-analysis`, `mcaf-dotnet-analyzer-config`, `mcaf-dotnet-stylecop-analyzers`, `mcaf-dotnet-roslynator`, `mcaf-dotnet-meziantou-analyzer`, `mcaf-dotnet-cloc`, `mcaf-dotnet-coverlet`, `mcaf-dotnet-profiling`, `mcaf-dotnet-quickdup`, `mcaf-dotnet-reportgenerator`, `mcaf-dotnet-resharper-clt`, `mcaf-dotnet-stryker`, `mcaf-dotnet-netarchtest`, `mcaf-dotnet-archunitnet`, `mcaf-dotnet-semgrep`, and `mcaf-dotnet-csharpier`. `mcaf-dotnet-codeql` stays available, but should be chosen only when its hosting and licensing model fits the repository.
118+
If the repo standardizes on concrete tools, install the matching tool skills as well. Typical open or free .NET additions include `mcaf-dotnet-format`, `mcaf-dotnet-code-analysis`, `mcaf-dotnet-analyzer-config`, `mcaf-dotnet-stylecop-analyzers`, `mcaf-dotnet-roslynator`, `mcaf-dotnet-meziantou-analyzer`, `mcaf-dotnet-cloc`, `mcaf-dotnet-coverlet`, `mcaf-dotnet-profiling`, `mcaf-dotnet-quickdup`, `mcaf-dotnet-reportgenerator`, `mcaf-dotnet-resharper-clt`, `mcaf-dotnet-stryker`, `mcaf-dotnet-netarchtest`, `mcaf-dotnet-archunitnet`, and `mcaf-dotnet-csharpier`. `mcaf-dotnet-codeql` stays available, but should be chosen only when its hosting and licensing model fits the repository.
119119

120120
### 2.5 Context Rules
121121

TUTORIAL.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ Add tool-specific .NET skills only when the repo standardizes on them:
153153
- `mcaf-dotnet-reportgenerator`
154154
- `mcaf-dotnet-resharper-clt`
155155
- `mcaf-dotnet-roslynator`
156-
- `mcaf-dotnet-semgrep`
157156
- `mcaf-dotnet-stryker`
158157
- `mcaf-dotnet-stylecop-analyzers`
159158
<!-- MCAF:DOTNET-OPTIONAL-SKILLS-END -->
@@ -190,7 +189,6 @@ The website build generates this list from the actual folders under `skills/`.
190189
- `mcaf-dotnet-reportgenerator`[Folder](https://github.com/managedcode/MCAF/blob/main/skills/mcaf-dotnet-reportgenerator), [Raw SKILL](https://raw.githubusercontent.com/managedcode/MCAF/main/skills/mcaf-dotnet-reportgenerator/SKILL.md)
191190
- `mcaf-dotnet-resharper-clt`[Folder](https://github.com/managedcode/MCAF/blob/main/skills/mcaf-dotnet-resharper-clt), [Raw SKILL](https://raw.githubusercontent.com/managedcode/MCAF/main/skills/mcaf-dotnet-resharper-clt/SKILL.md)
192191
- `mcaf-dotnet-roslynator`[Folder](https://github.com/managedcode/MCAF/blob/main/skills/mcaf-dotnet-roslynator), [Raw SKILL](https://raw.githubusercontent.com/managedcode/MCAF/main/skills/mcaf-dotnet-roslynator/SKILL.md)
193-
- `mcaf-dotnet-semgrep`[Folder](https://github.com/managedcode/MCAF/blob/main/skills/mcaf-dotnet-semgrep), [Raw SKILL](https://raw.githubusercontent.com/managedcode/MCAF/main/skills/mcaf-dotnet-semgrep/SKILL.md)
194192
- `mcaf-dotnet-stryker`[Folder](https://github.com/managedcode/MCAF/blob/main/skills/mcaf-dotnet-stryker), [Raw SKILL](https://raw.githubusercontent.com/managedcode/MCAF/main/skills/mcaf-dotnet-stryker/SKILL.md)
195193
- `mcaf-dotnet-stylecop-analyzers`[Folder](https://github.com/managedcode/MCAF/blob/main/skills/mcaf-dotnet-stylecop-analyzers), [Raw SKILL](https://raw.githubusercontent.com/managedcode/MCAF/main/skills/mcaf-dotnet-stylecop-analyzers/SKILL.md)
196194
- `mcaf-dotnet-tunit`[Folder](https://github.com/managedcode/MCAF/blob/main/skills/mcaf-dotnet-tunit), [Raw SKILL](https://raw.githubusercontent.com/managedcode/MCAF/main/skills/mcaf-dotnet-tunit/SKILL.md)

skills/mcaf-dotnet-quality-ci/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ compatibility: "Requires a .NET solution or project; may update `AGENTS.md`, CI
7979
- `mcaf-dotnet-analyzer-config`
8080
- analyzer-pack skills such as `mcaf-dotnet-stylecop-analyzers`, `mcaf-dotnet-roslynator`, and `mcaf-dotnet-meziantou-analyzer`
8181
- coverage/reporting skills such as `mcaf-dotnet-coverlet` and `mcaf-dotnet-reportgenerator`
82-
- architecture/security skills such as `mcaf-dotnet-netarchtest`, `mcaf-dotnet-archunitnet`, `mcaf-dotnet-codeql`, and `mcaf-dotnet-semgrep`
82+
- architecture/security skills such as `mcaf-dotnet-netarchtest`, `mcaf-dotnet-archunitnet`, and `mcaf-dotnet-codeql`
8383
8. Avoid overlapping tools with conflicting ownership. If you add an opinionated formatter, define whether it replaces or complements `dotnet format`.
8484

8585
## Bootstrap When Missing

skills/mcaf-dotnet-quality-ci/references/quality-toolchain.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ Open/free policy for this catalog:
77

88
- everything listed here is open source or free to adopt locally
99
- `CodeQL` stays in the catalog with an explicit caveat because the hosted GitHub private-repo experience is not universally free
10-
- if the team needs a security scanner with no such hosting caveat, prefer `mcaf-dotnet-semgrep`
1110

1211
Install policy for this catalog:
1312

@@ -50,7 +49,6 @@ These tools are worth adding once the baseline is stable:
5049
| Architecture tests | `NetArchTest.Rules` | `mcaf-dotnet-netarchtest` | Simple, fluent architectural rules in tests | Good for layered or clean architecture policies |
5150
| Architecture tests | `ArchUnitNET` | `mcaf-dotnet-archunitnet` | Richer architecture assertions across xUnit, MSTest, and TUnit | Heavier than NetArchTest but more expressive |
5251
| Deep inspections and cleanup | `JetBrains ReSharper Command Line Tools` | `mcaf-dotnet-resharper-clt` | Powerful ReSharper inspections plus cleanup profiles in CI or local runs | Free official JetBrains CLI package; keep shared policy in solution `.DotSettings` |
53-
| Security scanning | `Semgrep CE` | `mcaf-dotnet-semgrep` | Fast OSS static analysis across many languages | Community Edition is file/function-scoped for security analysis |
5452
| Security scanning | `CodeQL` | `mcaf-dotnet-codeql` | Deep GitHub-native query-based analysis | Open ecosystem with private-repo hosting caveats |
5553
| Opinionated formatter | `CSharpier` | `mcaf-dotnet-csharpier` | Fast one-style formatter for C# and XML | Use only if the repo wants a formatter owner beyond `dotnet format` |
5654

@@ -94,7 +92,7 @@ Use the exact commands from `AGENTS.md`. The usual checked-in flow is:
9492
4. focused `test`
9593
5. broader `test`
9694
6. `coverage` and report generation when configured
97-
7. extra configured gates such as Roslynator, StyleCop, Meziantou, ReSharper CLT, architecture tests, Semgrep, CodeQL, CSharpier, or Stryker
95+
7. extra configured gates such as Roslynator, StyleCop, Meziantou, ReSharper CLT, architecture tests, CodeQL, CSharpier, or Stryker
9896

9997
Run only the gates the repo actually enabled.
10098

@@ -143,5 +141,4 @@ dotnet stryker
143141
- [CleanupCode](https://www.jetbrains.com/help/resharper/CleanupCode.html)
144142
- [InspectCode](https://www.jetbrains.com/help/resharper/InspectCode.html)
145143
- [CodeQL code scanning](https://docs.github.com/en/code-security/code-scanning/introduction-to-code-scanning/about-code-scanning-with-codeql)
146-
- [Semgrep](https://github.com/semgrep/semgrep)
147144
- [CSharpier](https://github.com/belav/csharpier)

skills/mcaf-dotnet-semgrep/SKILL.md

Lines changed: 0 additions & 102 deletions
This file was deleted.

skills/mcaf-dotnet-semgrep/references/semgrep.md

Lines changed: 0 additions & 58 deletions
This file was deleted.

skills/mcaf-dotnet/SKILL.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ compatibility: "Requires a .NET solution or project; respects root and local `AG
5454
- `mcaf-dotnet-quality-ci`
5555
- `mcaf-dotnet-analyzer-config`
5656
- `mcaf-dotnet-complexity`
57-
- tool-specific skills such as `mcaf-dotnet-format`, `mcaf-dotnet-roslynator`, `mcaf-dotnet-stylecop-analyzers`, `mcaf-dotnet-meziantou-analyzer`, `mcaf-dotnet-coverlet`, `mcaf-dotnet-reportgenerator`, `mcaf-dotnet-resharper-clt`, `mcaf-dotnet-netarchtest`, `mcaf-dotnet-archunitnet`, `mcaf-dotnet-semgrep`, `mcaf-dotnet-codeql`, `mcaf-dotnet-csharpier`, and `mcaf-dotnet-stryker`
57+
- tool-specific skills such as `mcaf-dotnet-format`, `mcaf-dotnet-roslynator`, `mcaf-dotnet-stylecop-analyzers`, `mcaf-dotnet-meziantou-analyzer`, `mcaf-dotnet-coverlet`, `mcaf-dotnet-reportgenerator`, `mcaf-dotnet-resharper-clt`, `mcaf-dotnet-netarchtest`, `mcaf-dotnet-archunitnet`, `mcaf-dotnet-codeql`, `mcaf-dotnet-csharpier`, and `mcaf-dotnet-stryker`
5858
4. Route design and structure through:
5959
- `mcaf-solid-maintainability` for SOLID, SRP, cohesion, and maintainability limits
6060
- `mcaf-architecture-overview` when system or module boundaries, contracts, or architecture docs need work
@@ -67,7 +67,7 @@ compatibility: "Requires a .NET solution or project; respects root and local `AG
6767
- focused `test`
6868
- broader `test`
6969
- `coverage` and report generation when configured
70-
- extra configured gates such as Roslynator, StyleCop, Meziantou, ReSharper CLT, NetArchTest, ArchUnitNET, Semgrep, CodeQL, CSharpier, or Stryker
70+
- extra configured gates such as Roslynator, StyleCop, Meziantou, ReSharper CLT, NetArchTest, ArchUnitNET, CodeQL, CSharpier, or Stryker
7171
7. If the repo does not define these commands clearly, tighten `AGENTS.md` before continuing so later agents stop guessing.
7272
8. Do not introduce preview language features unless the repo explicitly opts into preview in project or MSBuild settings.
7373

skills/mcaf-dotnet/references/skill-routing.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Use `mcaf-dotnet` as the entry skill when a task spans more than one .NET concer
1414
| .NET quality gates, analyzer stack, coverage, mutation, or security gate selection | `mcaf-dotnet-quality-ci` |
1515
| repo-root `.editorconfig` authoring and analyzer severity ownership | `mcaf-dotnet-analyzer-config` |
1616
| complex methods, maintainability metrics, and coupling thresholds | `mcaf-dotnet-complexity` |
17-
| one concrete tool such as Roslynator, StyleCop, Coverlet, ReportGenerator, ReSharper CLT, Semgrep, or CSharpier | the exact tool skill |
17+
| one concrete tool such as Roslynator, StyleCop, Coverlet, ReportGenerator, ReSharper CLT, or CSharpier | the exact tool skill |
1818
| SOLID-driven refactors and maintainability-limit enforcement | `mcaf-solid-maintainability` |
1919
| architecture map or boundary documentation | `mcaf-architecture-overview` |
2020
| architecture rules in executable tests | `mcaf-dotnet-netarchtest` or `mcaf-dotnet-archunitnet` |

skills/mcaf-dotnet/references/task-flow.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Start from checked-in repo state:
88

99
```bash
1010
rg -n "TargetFramework|TargetFrameworks|LangVersion|UseMicrosoftTestingPlatformRunner|TestingPlatformDotnetTestSupport|EnableNETAnalyzers|AnalysisLevel|TreatWarningsAsErrors" -g '*.csproj' -g 'Directory.Build.*' .
11-
rg -n "xunit|xunit\\.v3|TUnit|MSTest|StyleCopAnalyzers|Roslynator|Meziantou|coverlet|ReportGenerator|JetBrains\\.ReSharper\\.GlobalTools|NetArchTest|ArchUnitNET|Semgrep|CodeQL|CSharpier" -g '*.csproj' -g '.config/dotnet-tools.json' .
11+
rg -n "xunit|xunit\\.v3|TUnit|MSTest|StyleCopAnalyzers|Roslynator|Meziantou|coverlet|ReportGenerator|JetBrains\\.ReSharper\\.GlobalTools|NetArchTest|ArchUnitNET|CodeQL|CSharpier" -g '*.csproj' -g '.config/dotnet-tools.json' .
1212
rg --files -g '.editorconfig' -g '*.sln.DotSettings'
1313
```
1414

@@ -32,7 +32,7 @@ Use the repo's exact commands from `AGENTS.md`. If the repo has no wrappers, the
3232
4. focused `test`
3333
5. broader `test`
3434
6. `coverage` and report generation when configured
35-
7. extra configured gates such as Roslynator, StyleCop, Meziantou, ReSharper CLT, architecture tests, Semgrep, CodeQL, CSharpier, or Stryker
35+
7. extra configured gates such as Roslynator, StyleCop, Meziantou, ReSharper CLT, architecture tests, CodeQL, CSharpier, or Stryker
3636

3737
## 4. Completion Rule
3838

0 commit comments

Comments
 (0)