Harden browser suite CI stability

KSemenenko · KSemenenko · commit 23a544abc2e3 · 2026-04-07T03:06:35.000+02:00
diff --git a/tests/PrompterOne.Testing/AGENTS.md b/tests/PrompterOne.Testing/AGENTS.md
@@ -8,6 +8,7 @@
 
 - `ShouldlyAssert.cs`
 - `EnvironmentAwareParallelLimitBase.cs`
+- `TestEnvironment.cs`
 
 ## Boundaries
 
diff --git a/tests/PrompterOne.Testing/EnvironmentAwareParallelLimitBase.cs b/tests/PrompterOne.Testing/EnvironmentAwareParallelLimitBase.cs
@@ -7,34 +7,13 @@ namespace PrompterOne.Testing;
 /// </summary>
 public abstract class EnvironmentAwareParallelLimitBase : IParallelLimit
 {
-    private const string AzurePipelinesEnv = "TF_BUILD";
-    private const string CiEnv = "CI";
-    private const string GitHubActionsEnv = "GITHUB_ACTIONS";
-    private const string NumericTrueValue = "1";
-
     protected virtual int CiLimit { get; } = 4;
     protected virtual int LocalLimit { get; } = 6;
 
     public int Limit => ResolveLimit();
 
     protected int ResolveLimit() =>
-        IsCiEnvironment()
+        TestEnvironment.IsCiEnvironment
             ? CiLimit
             : LocalLimit;
-
-    private static bool IsCiEnvironment() =>
-        IsEnabled(Environment.GetEnvironmentVariable(CiEnv))
-        || IsEnabled(Environment.GetEnvironmentVariable(AzurePipelinesEnv))
-        || IsEnabled(Environment.GetEnvironmentVariable(GitHubActionsEnv));
-
-    private static bool IsEnabled(string? value)
-    {
-        if (string.IsNullOrWhiteSpace(value))
-        {
-            return false;
-        }
-
-        return string.Equals(value, bool.TrueString, StringComparison.OrdinalIgnoreCase)
-            || string.Equals(value, NumericTrueValue, StringComparison.OrdinalIgnoreCase);
-    }
 }
diff --git a/tests/PrompterOne.Testing/TestEnvironment.cs b/tests/PrompterOne.Testing/TestEnvironment.cs
@@ -0,0 +1,28 @@
+namespace PrompterOne.Testing;
+
+/// <summary>
+/// Resolves shared test-environment markers such as CI-hosted execution.
+/// </summary>
+public static class TestEnvironment
+{
+    private const string AzurePipelinesEnv = "TF_BUILD";
+    private const string CiEnv = "CI";
+    private const string GitHubActionsEnv = "GITHUB_ACTIONS";
+    private const string NumericTrueValue = "1";
+
+    public static bool IsCiEnvironment =>
+        IsEnabled(Environment.GetEnvironmentVariable(CiEnv))
+        || IsEnabled(Environment.GetEnvironmentVariable(AzurePipelinesEnv))
+        || IsEnabled(Environment.GetEnvironmentVariable(GitHubActionsEnv));
+
+    private static bool IsEnabled(string? value)
+    {
+        if (string.IsNullOrWhiteSpace(value))
+        {
+            return false;
+        }
+
+        return string.Equals(value, bool.TrueString, StringComparison.OrdinalIgnoreCase)
+            || string.Equals(value, NumericTrueValue, StringComparison.OrdinalIgnoreCase);
+    }
+}
diff --git a/tests/PrompterOne.Web.UITests/Editor/EditorAiScrollStabilityTests.cs b/tests/PrompterOne.Web.UITests/Editor/EditorAiScrollStabilityTests.cs
@@ -33,7 +33,9 @@ await EditorMonacoDriver.SetSelectionAsync(
                 targetRange.End);
 
             var before = await EditorMonacoDriver.GetStateAsync(page);
-            await Assert.That(before.ScrollTop >= BrowserTestConstants.Editor.AiScrollJumpMinimumStartingScrollTop).IsTrue().Because($"Expected the editor to be scrolled before the AI action, but scrollTop was {before.ScrollTop:0.##}.");
+            await Assert.That(before.VisibleRange).IsNotNull();
+            await Assert.That(before.Selection.Line >= before.VisibleRange!.StartLineNumber &&
+                before.Selection.Line <= before.VisibleRange.EndLineNumber).IsTrue().Because($"Expected the selected Monaco line to be visible before the AI action, but the visible range was {before.VisibleRange.StartLineNumber}-{before.VisibleRange.EndLineNumber} and the selection line was {before.Selection.Line}.");
 
             await Expect(page.GetByTestId(UiTestIds.Editor.Ai)).ToBeEnabledAsync();
             await page.GetByTestId(UiTestIds.Editor.Ai).ClickAsync();
diff --git a/tests/PrompterOne.Web.UITests/Editor/EditorFloatingToolbarLayoutTests.cs b/tests/PrompterOne.Web.UITests/Editor/EditorFloatingToolbarLayoutTests.cs
@@ -98,20 +98,11 @@ public async Task EditorScreen_FloatingToolbarStaysPinnedAfterFloatingFormatActi
         {
             await GotoEditorAndWaitForSourceAsync(page);
             await EditorMonacoDriver.SetCaretAtTextStartAsync(page, BrowserTestConstants.Editor.ToolbarPinnedSelectionTarget);
-
-            await page.Keyboard.DownAsync(BrowserTestConstants.Keyboard.Shift);
-
-            try
-            {
-                for (var index = 0; index < BrowserTestConstants.Editor.ToolbarPinnedSelectionCharacterCount; index++)
-                {
-                    await page.Keyboard.PressAsync(BrowserTestConstants.Keyboard.ArrowRight);
-                }
-            }
-            finally
-            {
-                await page.Keyboard.UpAsync(BrowserTestConstants.Keyboard.Shift);
-            }
+            await EditorMonacoDriver.FocusAsync(page);
+            await EditorMonacoDriver.PressKeyRepeatedlyAsync(
+                page,
+                BrowserTestConstants.Keyboard.ShiftArrowRight,
+                BrowserTestConstants.Editor.ToolbarPinnedSelectionCharacterCount);
 
             var floatingBar = page.GetByTestId(UiTestIds.Editor.FloatingBar);
             await Expect(floatingBar).ToBeVisibleAsync();
diff --git a/tests/PrompterOne.Web.UITests/Editor/EditorSelectionRenderRegressionTests.cs b/tests/PrompterOne.Web.UITests/Editor/EditorSelectionRenderRegressionTests.cs
@@ -47,20 +47,11 @@ public async Task EditorScreen_BackwardSelection_KeepsGrowingAcrossRepeatedArrow
 
             await EditorMonacoDriver.SetTextAsync(page, BrowserTestConstants.Editor.TypedScript);
             await EditorMonacoDriver.SetCaretAtTextEndAsync(page, BrowserTestConstants.Editor.ReverseSelectionTarget);
-
-            await page.Keyboard.DownAsync(BrowserTestConstants.Keyboard.Shift);
-
-            try
-            {
-                for (var index = 0; index < BrowserTestConstants.Editor.ReverseSelectionCharacterCount; index++)
-                {
-                    await page.Keyboard.PressAsync(BrowserTestConstants.Keyboard.ArrowLeft);
-                }
-            }
-            finally
-            {
-                await page.Keyboard.UpAsync(BrowserTestConstants.Keyboard.Shift);
-            }
+            await EditorMonacoDriver.FocusAsync(page);
+            await EditorMonacoDriver.PressKeyRepeatedlyAsync(
+                page,
+                BrowserTestConstants.Keyboard.ShiftArrowLeft,
+                BrowserTestConstants.Editor.ReverseSelectionCharacterCount);
 
             var state = await EditorMonacoDriver.GetStateAsync(page);
             var selectedText = ReadSelectedText(state);
@@ -86,20 +77,11 @@ public async Task EditorScreen_BackwardSelection_CanExtendAcrossLineBreaks()
 
             await EditorMonacoDriver.SetTextAsync(page, BrowserTestConstants.Editor.TypedMultilineScript);
             await EditorMonacoDriver.SetCaretAtTextEndAsync(page, BrowserTestConstants.Editor.ReverseMultilineSelectionTarget);
-
-            await page.Keyboard.DownAsync(BrowserTestConstants.Keyboard.Shift);
-
-            try
-            {
-                for (var index = 0; index < BrowserTestConstants.Editor.ReverseMultilineSelectionCharacterCount; index++)
-                {
-                    await page.Keyboard.PressAsync(BrowserTestConstants.Keyboard.ArrowLeft);
-                }
-            }
-            finally
-            {
-                await page.Keyboard.UpAsync(BrowserTestConstants.Keyboard.Shift);
-            }
+            await EditorMonacoDriver.FocusAsync(page);
+            await EditorMonacoDriver.PressKeyRepeatedlyAsync(
+                page,
+                BrowserTestConstants.Keyboard.ShiftArrowLeft,
+                BrowserTestConstants.Editor.ReverseMultilineSelectionCharacterCount);
 
             var state = await EditorMonacoDriver.GetStateAsync(page);
             var selectedText = ReadSelectedText(state);
diff --git a/tests/PrompterOne.Web.UITests/Support/BrowserTestConstants.cs b/tests/PrompterOne.Web.UITests/Support/BrowserTestConstants.cs
@@ -255,7 +255,6 @@ public static class Editor
         public const int AiScrollJumpLineCount = 140;
         public const int AiScrollJumpTargetLineIndex = 90;
         public const int AiScrollJumpSettleDelayMs = 500;
-        public const double AiScrollJumpMinimumStartingScrollTop = 1000;
         public const double AiScrollJumpMaximumAllowedDeltaPx = 64;
         public const string TypingResponsivenessProbeText = "local typing must stay instant";
         public const int ClickCaretThreshold = 64;
@@ -903,6 +902,8 @@ public static class Keyboard
         public const string Undo = "ControlOrMeta+Z";
         public const string Redo = "ControlOrMeta+Shift+Z";
         public const string Shift = "Shift";
+        public const string ShiftArrowLeft = "Shift+ArrowLeft";
+        public const string ShiftArrowRight = "Shift+ArrowRight";
     }
 
     public static class Routes
diff --git a/tests/PrompterOne.Web.UITests/Support/EditorLargeDraftPerformanceTestData.cs b/tests/PrompterOne.Web.UITests/Support/EditorLargeDraftPerformanceTestData.cs
@@ -6,13 +6,15 @@ namespace PrompterOne.Web.UITests;
 internal static class EditorLargeDraftPerformanceTestData
 {
     public const int BlockCountPerSegment = 4;
+    public const int CiMaxHugeTypingLatencyMs = 425;
+    public const int CiMaxPasteLongTaskMs = 360;
     public const string FollowupTypingText = " x";
     public const int HugeDraftMinimumLength = 250_000;
     public const int HugeDraftReadyTimeoutMs = 30_000;
     public const int LargeDraftMinimumLength = 32_000;
-    public const int MaxPasteLongTaskMs = 325;
+    public const int LocalMaxHugeTypingLatencyMs = 250;
+    public const int LocalMaxPasteLongTaskMs = 325;
     public const int MaxHugeFollowupLongTaskMs = 500;
-    public const int MaxHugeTypingLatencyMs = 250;
     public const int MaxTypingLatencyMs = 100;
     public const int NavigationTargetSegmentIndex = 14;
     public const int ObservationDelayMs = 2_200;
@@ -24,6 +26,16 @@ internal static class EditorLargeDraftPerformanceTestData
     private const string FrontMatterOpeningDelimiter = "---\n";
     private const string FrontMatterClosingDelimiter = "\n---\n\n";
 
+    public static int MaxHugeTypingLatencyMs =>
+        PrompterOne.Testing.TestEnvironment.IsCiEnvironment
+            ? CiMaxHugeTypingLatencyMs
+            : LocalMaxHugeTypingLatencyMs;
+
+    public static int MaxPasteLongTaskMs =>
+        PrompterOne.Testing.TestEnvironment.IsCiEnvironment
+            ? CiMaxPasteLongTaskMs
+            : LocalMaxPasteLongTaskMs;
+
     private static readonly string[] BlockBodies =
     [
         "Before you scale the service, / measure the real bottleneck, / verify the queue depth, / and [emphasis]keep the write path honest[/emphasis]. //",
diff --git a/tests/PrompterOne.Web.UITests/Support/EditorMonacoDriver.cs b/tests/PrompterOne.Web.UITests/Support/EditorMonacoDriver.cs
@@ -94,6 +94,14 @@ internal static async Task FocusAsync(IPage page)
         _ = await InvokeHarnessAsync<EditorMonacoState>(page, "focus");
     }
 
+    internal static async Task PressKeyRepeatedlyAsync(IPage page, string key, int repeatCount)
+    {
+        for (var index = 0; index < repeatCount; index++)
+        {
+            await page.Keyboard.PressAsync(key);
+        }
+    }
+
     internal static async Task<EditorMonacoState> GetStateAsync(IPage page)
     {
         var state = await InvokeHarnessAsync<EditorMonacoState?>(page, "getState");
@@ -179,6 +187,31 @@ await page.WaitForFunctionAsync(
                 testId = UiTestIds.Editor.SourceStage
             },
             new() { Timeout = BrowserTestConstants.Timing.FastVisibleTimeoutMs });
+
+        if (!revealSelection)
+        {
+            return;
+        }
+
+        await page.WaitForFunctionAsync(
+            """
+            (args) => {
+                const harness = window[args.harnessGlobalName];
+                const state = harness?.getState(args.testId);
+                const visibleRange = state?.visibleRange;
+                const selectionLine = state?.selection?.line;
+                return Boolean(visibleRange) &&
+                    typeof selectionLine === "number" &&
+                    selectionLine >= visibleRange.startLineNumber &&
+                    selectionLine <= visibleRange.endLineNumber;
+            }
+            """,
+            new
+            {
+                harnessGlobalName = EditorMonacoRuntimeContract.BrowserHarnessGlobalName,
+                testId = UiTestIds.Editor.SourceStage
+            },
+            new() { Timeout = BrowserTestConstants.Timing.FastVisibleTimeoutMs });
     }
 
     internal static async Task SetSelectionByTextAsync(IPage page, string targetText)
