Harden shell go-live routing and library root breadcrumb

KSemenenko · KSemenenko · commit b45354f133b0 · 2026-04-04T05:08:50.000+02:00
diff --git a/AGENTS.md b/AGENTS.md
@@ -406,6 +406,7 @@ Ask first:
 - thin WASM host boundaries
 - browser-realistic UI verification
 - domain logic that stays reusable and serializable
+- one extra proactive hardening pass after a broad audit or release-critical task, even when the first CI run is already green, so lingering UX or lifecycle issues are caught before the user has to ask again
 
 ### Dislikes
 
diff --git a/src/PrompterOne.Shared/AppShell/Layout/MainLayout.razor b/src/PrompterOne.Shared/AppShell/Layout/MainLayout.razor
@@ -26,10 +26,18 @@
             @if (IsLibraryScreen)
             {
                 <div class="lib-breadcrumb">
-                    <span class="bc-item">@Text(UiTextKey.LibraryAllScripts)</span>
-                    <span class="bc-sep">/</span>
-                    <span class="bc-item bc-current"
-                          data-testid="@UiTestIds.Header.LibraryBreadcrumbCurrent">@ShellState.BreadcrumbLabel</span>
+                    @if (IsLibraryRootBreadcrumb)
+                    {
+                        <span class="bc-item bc-current"
+                              data-testid="@UiTestIds.Header.LibraryBreadcrumbCurrent">@LibraryBreadcrumbCurrentLabel</span>
+                    }
+                    else
+                    {
+                        <span class="bc-item">@Text(UiTextKey.LibraryAllScripts)</span>
+                        <span class="bc-sep">/</span>
+                        <span class="bc-item bc-current"
+                              data-testid="@UiTestIds.Header.LibraryBreadcrumbCurrent">@LibraryBreadcrumbCurrentLabel</span>
+                    }
                 </div>
             }
             else
diff --git a/src/PrompterOne.Shared/AppShell/Layout/MainLayout.razor.cs b/src/PrompterOne.Shared/AppShell/Layout/MainLayout.razor.cs
@@ -41,6 +41,14 @@ public partial class MainLayout : LayoutComponentBase, IDisposable
 
     private bool ShowLibraryActions => ShellState.Screen == AppShellScreen.Library;
 
+    private bool IsLibraryRootBreadcrumb =>
+        string.IsNullOrWhiteSpace(ShellState.BreadcrumbLabel)
+        || string.Equals(ShellState.BreadcrumbLabel, Text(UiTextKey.LibraryAllScripts), StringComparison.Ordinal);
+
+    private string LibraryBreadcrumbCurrentLabel => IsLibraryRootBreadcrumb
+        ? Text(UiTextKey.LibraryAllScripts)
+        : ShellState.BreadcrumbLabel;
+
     private bool ShowLearnAction => ShellState.Screen == AppShellScreen.Editor;
 
     private bool ShowLearnWpmBadge => ShellState.Screen == AppShellScreen.Learn;
@@ -102,8 +110,10 @@ public partial class MainLayout : LayoutComponentBase, IDisposable
 
     private bool ShowGoLiveWidget => GoLiveSessionState.HasActiveSession && ShellState.Screen != AppShellScreen.GoLive;
 
-    private string GoLiveRoute => !string.IsNullOrWhiteSpace(GoLiveSessionState.ScriptId)
-        ? AppRoutes.GoLiveWithId(GoLiveSessionState.ScriptId)
+    private string GoLiveRoute => GoLiveSessionState.HasActiveSession
+        ? string.IsNullOrWhiteSpace(GoLiveSessionState.ScriptId)
+            ? AppRoutes.GoLive
+            : AppRoutes.GoLiveWithId(GoLiveSessionState.ScriptId)
         : Shell.GetGoLiveRoute();
 
     private const string IdleStateValue = "idle";
diff --git a/src/PrompterOne.Shared/Library/Pages/LibraryPage.ViewState.cs b/src/PrompterOne.Shared/Library/Pages/LibraryPage.ViewState.cs
@@ -81,9 +81,7 @@ private string ResolveSelectedFolderLabel()
     {
         if (IsAllSelected)
         {
-            return _folderNodes.Count > 0
-                ? _folderNodes[RootFolderNodeIndex].Name
-                : Text(UiTextKey.LibraryAllScripts);
+            return Text(UiTextKey.LibraryAllScripts);
         }
 
         return _folders
diff --git a/src/PrompterOne.Shared/Library/Pages/LibraryPage.razor.cs b/src/PrompterOne.Shared/Library/Pages/LibraryPage.razor.cs
@@ -12,7 +12,6 @@ namespace PrompterOne.Shared.Pages;
 
 public partial class LibraryPage : ComponentBase, IDisposable
 {
-    private const int RootFolderNodeIndex = 0;
     private const string LibrarySettingsKey = "prompterone.library";
     private const string LoadLibraryOperation = "Library load";
     private const string LoadLibraryMessage = "Unable to load the library right now.";
diff --git a/tests/PrompterOne.App.Tests/AppShell/MainLayoutActionTests.cs b/tests/PrompterOne.App.Tests/AppShell/MainLayoutActionTests.cs
@@ -1,8 +1,10 @@
 using Bunit;
 using Microsoft.AspNetCore.Components;
 using Microsoft.Extensions.DependencyInjection;
+using PrompterOne.Core.Models.Workspace;
 using PrompterOne.Shared.Contracts;
 using PrompterOne.Shared.Layout;
+using PrompterOne.Shared.Services;
 using PrompterOne.Shared.Tests;
 
 namespace PrompterOne.App.Tests;
@@ -82,4 +84,36 @@ public void MainLayout_LibraryHeaderMatchesReferenceActionOrder()
             Assert.True(goLiveIndex >= 0 && newScriptIndex >= 0 && goLiveIndex < newScriptIndex);
         });
     }
+
+    [Fact]
+    public void MainLayout_ActiveGenericGoLiveSession_UsesPlainGoLiveRoute_InsteadOfCurrentEditorScriptScope()
+    {
+        _ = TestHarnessFactory.Create(this);
+        var navigation = Services.GetRequiredService<NavigationManager>();
+        navigation.NavigateTo(AppRoutes.EditorWithId(AppTestData.Scripts.DemoId));
+        Services.GetRequiredService<GoLiveSessionService>().SetState(new GoLiveSessionState(
+            ScriptId: string.Empty,
+            ScriptTitle: string.Empty,
+            ScriptSubtitle: string.Empty,
+            SelectedSourceId: AppTestData.Camera.FirstSourceId,
+            SelectedSourceLabel: AppTestData.Camera.FrontCamera,
+            ActiveSourceId: AppTestData.Camera.FirstSourceId,
+            ActiveSourceLabel: AppTestData.Camera.FrontCamera,
+            PrimaryMicrophoneLabel: AppTestData.Scripts.BroadcastMic,
+            OutputResolution: StreamingResolutionPreset.FullHd1080p30,
+            BitrateKbps: AppTestData.Streaming.BitrateKbps,
+            IsStreamActive: true,
+            IsRecordingActive: false,
+            StreamStartedAt: DateTimeOffset.UtcNow.AddMinutes(-1),
+            RecordingStartedAt: null));
+
+        var cut = Render<MainLayout>(parameters => parameters
+            .Add(layout => layout.Body, (RenderFragment)(builder => builder.AddMarkupContent(0, "<div>Body</div>"))));
+
+        cut.WaitForAssertion(() => Assert.NotNull(cut.FindByTestId(UiTestIds.Header.LiveWidget)));
+        cut.FindByTestId(UiTestIds.Header.LiveWidget).Click();
+
+        Assert.EndsWith(AppRoutes.GoLive, navigation.Uri, StringComparison.Ordinal);
+        Assert.DoesNotContain(AppRoutes.ScriptIdQueryKey, navigation.Uri, StringComparison.Ordinal);
+    }
 }
diff --git a/tests/PrompterOne.App.UITests/GoLive/GoLiveShellSessionFlowTests.cs b/tests/PrompterOne.App.UITests/GoLive/GoLiveShellSessionFlowTests.cs
@@ -98,6 +98,41 @@ await Expect(page.GetByTestId(UiTestIds.Header.GoLive))
         }
     }
 
+    [Fact]
+    public async Task GoLivePage_GenericActiveSession_WidgetReturnsToPlainGoLiveRoute_WithoutInjectingEditorScriptId()
+    {
+        var pages = await _fixture.NewSharedPagesAsync(BrowserTestConstants.GoLive.SharedContextPageCount);
+        var primaryPage = pages[0];
+        var secondaryPage = pages[1];
+
+        try
+        {
+            await GoLiveFlowTests.SeedGoLiveSceneForReuseAsync(primaryPage);
+            await primaryPage.GotoAsync(BrowserTestConstants.Routes.GoLive);
+            await Expect(primaryPage.GetByTestId(UiTestIds.GoLive.Page)).ToBeVisibleAsync();
+
+            await primaryPage.GetByTestId(UiTestIds.GoLive.StartRecording).ClickAsync();
+            await primaryPage.WaitForFunctionAsync(
+                BrowserTestConstants.GoLive.RecordingRuntimeActiveScript,
+                BrowserTestConstants.GoLive.RuntimeSessionId,
+                new() { Timeout = BrowserTestConstants.Timing.ExtendedVisibleTimeoutMs });
+
+            await secondaryPage.GotoAsync(BrowserTestConstants.Routes.EditorDemo);
+            await Expect(secondaryPage.GetByTestId(UiTestIds.Editor.Page)).ToBeVisibleAsync();
+            await Expect(secondaryPage.GetByTestId(UiTestIds.Header.LiveWidget)).ToBeVisibleAsync();
+
+            await secondaryPage.GetByTestId(UiTestIds.Header.LiveWidget).ClickAsync();
+
+            await secondaryPage.WaitForURLAsync(BrowserTestConstants.Routes.Pattern(BrowserTestConstants.Routes.GoLive));
+            await Expect(secondaryPage.GetByTestId(UiTestIds.GoLive.Page)).ToBeVisibleAsync();
+            Assert.Equal(BrowserTestConstants.Routes.GoLive, new Uri(secondaryPage.Url).PathAndQuery);
+        }
+        finally
+        {
+            await primaryPage.Context.CloseAsync();
+        }
+    }
+
     [Fact]
     public async Task GoLivePage_RecordingState_PropagatesAcrossSharedTabsAndReturnsToIdleAfterStop()
     {
diff --git a/tests/PrompterOne.App.UITests/Library/LibraryScreenFlowTests.cs b/tests/PrompterOne.App.UITests/Library/LibraryScreenFlowTests.cs
@@ -15,7 +15,7 @@ public Task LibraryScreen_NavigatesIntoEditorAndSettings() =>
             await page.GotoAsync(BrowserTestConstants.Routes.Library);
             await Expect(page.GetByTestId(UiTestIds.Library.Page)).ToBeVisibleAsync();
             await Expect(page.GetByTestId(UiTestIds.Header.LibraryBreadcrumbCurrent))
-                .ToHaveTextAsync(BrowserTestConstants.Folders.PresentationsName);
+                .ToHaveTextAsync(BrowserTestConstants.Folders.AllScriptsName);
             await Expect(page.GetByTestId(UiTestIds.Header.GoLive))
                 .ToHaveClassAsync(BrowserTestConstants.Regexes.GoLiveHeaderClass);
             await Expect(page.GetByTestId(UiTestIds.Library.FolderChips)).ToHaveCountAsync(0);
@@ -133,6 +133,26 @@ public Task LibraryScreen_SidebarFoldersFilterCards() =>
             await Expect(page.GetByTestId(BrowserTestConstants.Elements.LeadershipCard)).ToContainTextAsync(BrowserTestConstants.Scripts.LeadershipTitle);
         });
 
+    [Fact]
+    public Task LibraryScreen_RootBreadcrumb_RendersSingleAllScriptsLabel() =>
+        RunPageAsync(async page =>
+        {
+            await page.GotoAsync(BrowserTestConstants.Routes.Library);
+            await Expect(page.GetByTestId(UiTestIds.Library.Page)).ToBeVisibleAsync();
+
+            await page.GetByTestId(UiTestIds.Library.FolderAll).ClickAsync();
+
+            await Expect(page.GetByTestId(UiTestIds.Header.LibraryBreadcrumbCurrent))
+                .ToHaveTextAsync(BrowserTestConstants.Folders.AllScriptsName);
+
+            var headerCenterText = (await page.GetByTestId(UiTestIds.Header.Center).TextContentAsync()) ?? string.Empty;
+            var allScriptsOccurrences = headerCenterText.Split(
+                BrowserTestConstants.Folders.AllScriptsName,
+                StringSplitOptions.None).Length - 1;
+
+            Assert.Equal(1, allScriptsOccurrences);
+        });
+
     [Fact]
     public Task LibraryScreen_CreatesFolderAndMovesScript() =>
         RunPageAsync(async page =>
diff --git a/tests/PrompterOne.App.UITests/Support/BrowserTestConstants.cs b/tests/PrompterOne.App.UITests/Support/BrowserTestConstants.cs
@@ -136,6 +136,7 @@ public static class Teleprompter
 
     public static class Folders
     {
+        public const string AllScriptsName = "All Scripts";
         public const string PresentationsId = "test-presentations";
         public const string PresentationsName = "Presentations";
         public const string TedTalksId = "test-ted-talks";
@@ -810,6 +811,7 @@ public static class Keyboard
     public static class Routes
     {
         public static string Editor => AppRoutes.Editor;
+        public static string GoLive => AppRoutes.GoLive;
         public static string Library => AppRoutes.Library;
         public static string Settings => AppRoutes.Settings;
         public static string EditorDemo => AppRoutes.EditorWithId(Scripts.DemoId);

Original file line number	Diff line number	Diff line change
`@@ -81,9 +81,7 @@ private string ResolveSelectedFolderLabel()`
`81`	`81`	`{`
`82`	`82`	`if (IsAllSelected)`
`83`	`83`	`{`
`84`		`- return _folderNodes.Count > 0`
`85`		`- ? _folderNodes[RootFolderNodeIndex].Name`
`86`		`- : Text(UiTextKey.LibraryAllScripts);`
	`84`	`+ return Text(UiTextKey.LibraryAllScripts);`
`87`	`85`	`}`
`88`	`86`
`89`	`87`	`return _folders`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,6 @@ namespace PrompterOne.Shared.Pages;`
`12`	`12`
`13`	`13`	`public partial class LibraryPage : ComponentBase, IDisposable`
`14`	`14`	`{`
`15`		`- private const int RootFolderNodeIndex = 0;`
`16`	`15`	`private const string LibrarySettingsKey = "prompterone.library";`
`17`	`16`	`private const string LoadLibraryOperation = "Library load";`
`18`	`17`	`private const string LoadLibraryMessage = "Unable to load the library right now.";`
Original file line number	Diff line number	Diff line change
`@@ -136,6 +136,7 @@ public static class Teleprompter`
`136`	`136`
`137`	`137`	`public static class Folders`
`138`	`138`	`{`
	`139`	`+ public const string AllScriptsName = "All Scripts";`
`139`	`140`	`public const string PresentationsId = "test-presentations";`
`140`	`141`	`public const string PresentationsName = "Presentations";`
`141`	`142`	`public const string TedTalksId = "test-ted-talks";`
`@@ -810,6 +811,7 @@ public static class Keyboard`
`810`	`811`	`public static class Routes`
`811`	`812`	`{`
`812`	`813`	`public static string Editor => AppRoutes.Editor;`
	`814`	`+ public static string GoLive => AppRoutes.GoLive;`
`813`	`815`	`public static string Library => AppRoutes.Library;`
`814`	`816`	`public static string Settings => AppRoutes.Settings;`
`815`	`817`	`public static string EditorDemo => AppRoutes.EditorWithId(Scripts.DemoId);`