Skip to content

Commit c37d2ab

Browse files
committed
align release validation environment
1 parent faad458 commit c37d2ab

File tree

2 files changed

+20
-8
lines changed

2 files changed

+20
-8
lines changed

.github/workflows/deploy-github-pages.yml

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,9 @@ concurrency:
1616
cancel-in-progress: true
1717

1818
env:
19-
APP_PROJECT: src/PrompterLive.App/PrompterLive.App.csproj
2019
APP_TEST_PROJECT: tests/PrompterLive.App.Tests/PrompterLive.App.Tests.csproj
2120
CORE_TEST_PROJECT: tests/PrompterLive.Core.Tests/PrompterLive.Core.Tests.csproj
22-
PAGES_ARTIFACT_ROOT: .artifacts/prompterlive-pages
23-
PAGES_BASE_PATH: /
24-
PAGES_CNAME: prompter.managed-code.com
2521
PLAYWRIGHT_CLI: tests/PrompterLive.App.UITests/bin/Debug/net10.0/.playwright/package/cli.js
26-
PUBLISH_ROOT: .artifacts/prompterlive-publish
27-
RELEASE_ARCHIVE_NAME: prompterlive-pages.zip
28-
RELEASE_ARTIFACT_NAME: prompterlive-release-package
29-
RELEASE_ARTIFACT_ROOT: .artifacts/release-artifact
3022
SOLUTION_FILE: PrompterLive.slnx
3123
UI_TEST_PROJECT: tests/PrompterLive.App.UITests/PrompterLive.App.UITests.csproj
3224

@@ -65,6 +57,8 @@ jobs:
6557
name: Resolve Release Version
6658
needs: validate_release
6759
runs-on: ubuntu-latest
60+
env:
61+
APP_PROJECT: src/PrompterLive.App/PrompterLive.App.csproj
6862

6963
permissions:
7064
contents: read
@@ -94,6 +88,15 @@ jobs:
9488
name: Publish Release Build
9589
needs: prepare_release
9690
runs-on: ubuntu-latest
91+
env:
92+
APP_PROJECT: src/PrompterLive.App/PrompterLive.App.csproj
93+
PAGES_ARTIFACT_ROOT: .artifacts/prompterlive-pages
94+
PAGES_BASE_PATH: /
95+
PAGES_CNAME: prompter.managed-code.com
96+
PUBLISH_ROOT: .artifacts/prompterlive-publish
97+
RELEASE_ARCHIVE_NAME: prompterlive-pages.zip
98+
RELEASE_ARTIFACT_NAME: prompterlive-release-package
99+
RELEASE_ARTIFACT_ROOT: .artifacts/release-artifact
97100

98101
permissions:
99102
contents: read
@@ -147,6 +150,9 @@ jobs:
147150
- prepare_release
148151
- publish_release_build
149152
runs-on: ubuntu-latest
153+
env:
154+
RELEASE_ARCHIVE_NAME: prompterlive-pages.zip
155+
RELEASE_ARTIFACT_ROOT: .artifacts/release-artifact
150156

151157
permissions:
152158
contents: write

ci-workflows-release-pr-validation.plan.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,10 @@ Root-cause note:
234234
- `EditorScreen_QuantumTypingKeepsStyledOverlayVisibleResponsive`
235235
- Root cause note: the test asserted a hard `maxLatency <= 120ms` on the single slowest MutationObserver sample, which was sensitive to one-off runner scheduling spikes in the release workflow even when the same Linux browser suite passed in `PR Validation`.
236236
- Intended fix path: keep the strong no-visible-input/no-long-task checks, but evaluate typing responsiveness with a bounded spike plus a stable `p95` latency threshold instead of a single-sample maximum.
237+
- GitHub run `23817217598` confirmed a workflow-level difference still remained after the typing-probe stabilization:
238+
- `PR Validation` run `23817221509` passed on the same commit while the release workflow still failed in `Build And Test`.
239+
- Root cause note: the release workflow exported Pages and release publishing variables globally, so the validation job did not actually run under the same environment contract as `PR Validation`.
240+
- Intended fix path: scope release-only environment variables to the release-preparation and publish jobs, leaving the release validation job with the same build/test environment as `PR Validation`.
237241
- Local validation after the browser-suite stability fixes passed:
238242
- `dotnet build /Users/ksemenenko/Developer/PrompterLive/PrompterLive.slnx -warnaserror`
239243
- `dotnet test /Users/ksemenenko/Developer/PrompterLive/tests/PrompterLive.Core.Tests/PrompterLive.Core.Tests.csproj --no-build`
@@ -252,6 +256,8 @@ Root-cause note:
252256
- `dotnet build /Users/ksemenenko/Developer/PrompterLive/PrompterLive.slnx -warnaserror`
253257
- `dotnet test /Users/ksemenenko/Developer/PrompterLive/tests/PrompterLive.App.UITests/PrompterLive.App.UITests.csproj --no-build`
254258
- `dotnet format /Users/ksemenenko/Developer/PrompterLive/PrompterLive.slnx`
259+
- Local workflow validation after the release-env scoping fix passed:
260+
- `actionlint /Users/ksemenenko/Developer/PrompterLive/.github/workflows/*.yml`
255261

256262
## Final Validation Skills And Commands
257263

0 commit comments

Comments
 (0)