Skip to content

Commit 4ae5af3

Browse files
committed
Fix PR 79 UI test review follow-up
1 parent f6efcad commit 4ae5af3

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

AGENTS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@ For this app:
155155
- structure both `DotPilot.Tests` and `DotPilot.UITests` by vertical slice and explicit harness boundaries; do not keep test files in one flat project-root pile
156156
- the first embedded Orleans host cut must use `UseLocalhostClustering` plus in-memory grain storage and reminders; do not introduce remote clustering or external durable stores until a later backlog item explicitly requires them
157157
- GitHub is the backlog, not the product: use issues and PRs only to drive task scope and traceability, and never copy GitHub issue text, labels, workflow language, or tracker metadata into production code, runtime snapshots, or user-facing UI
158+
- never claim an epic is complete until its current GitHub scope is verified against the live issue graph; check which issues are real children versus issues that merely depend on the epic or belong to a different parent epic
158159
- Desktop responsiveness is a product requirement: avoid synchronous probe, filesystem, network, or process work on UI-facing construction and navigation paths so the app stays fast and immediately reactive
159160
- Do not invent a repo-specific product framing such as "workbench" unless the active issue or feature spec explicitly uses it; implement the app features described in the backlog instead of turning internal implementation language into the product narrative
160161
- GitHub Actions workflows must use descriptive names and filenames that reflect their purpose; do not use a generic `ci.yml` catch-all because build validation and release automation are separate operator flows
@@ -368,6 +369,7 @@ Ask first:
368369
- Installing stale, non-canonical, or non-`mcaf-*` skills into the repo-local agent skill directory.
369370
- Moving root governance out of the repository root.
370371
- Mixing multiple `.NET` test frameworks in the active solution without a documented migration plan.
372+
- Creating auxiliary `git worktree` directories for normal PR follow-up when straightforward branch switching in the main checkout is enough.
371373
- Running build, test, or verification commands for file-only structural reorganizations when the user explicitly asked for folder cleanup without behavior changes.
372374
- Adding fallback paths or alternate harnesses that only make failures disappear in tests while the primary product path remains broken.
373375
- Switching desktop Uno pages into stacked or mobile-style responsive layouts during resize work unless the user explicitly asks for a different composition; desktop pages must stay desktop-first and protect geometry through sizing constraints instead.

DotPilot.UITests/AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Stack: `.NET 10`, `NUnit`, `Uno.UITest`, browser-driven UI tests
1313
- `DotPilot.UITests.csproj`
1414
- `Harness/Constants.cs`
1515
- `Harness/TestBase.cs`
16-
- `Features/ApplicationShell/Given_MainPage.cs`
16+
- `Features/Workbench/GivenWorkbenchShell.cs`
1717

1818
## Boundaries
1919

DotPilot.UITests/Features/ApplicationShell/Given_MainPage.cs renamed to DotPilot.UITests/Features/Workbench/GivenWorkbenchShell.cs

File renamed without changes.

0 commit comments

Comments
 (0)