Merge main into PR 80 and sync review fixes

Author: KSemenenko

DotPilot.Core/Features/ToolchainCenter/ToolchainCenterContracts.cs

@@ -4,7 +4,7 @@ namespace DotPilot.Core.Features.ToolchainCenter;
 
 public sealed record ToolchainCenterWorkstreamDescriptor(
     int IssueNumber,
-    string IssueLabel,
+    string SectionLabel,
     string Name,
     string Summary);
 
@@ -37,7 +37,7 @@ public sealed record ToolchainPollingDescriptor(
 
 public sealed record ToolchainProviderSnapshot(
     int IssueNumber,
-    string IssueLabel,
+    string SectionLabel,
     ProviderDescriptor Provider,
     string ExecutablePath,
     string InstalledVersion,

DotPilot.Runtime/Features/RuntimeFoundation/DeterministicAgentRuntimeClient.cs

@@ -1,4 +1,3 @@
-using System.Diagnostics;
 using DotPilot.Core.Features.ControlPlaneDomain;
 using DotPilot.Core.Features.RuntimeCommunication;
 using DotPilot.Core.Features.RuntimeFoundation;
@@ -64,7 +63,7 @@ AgentExecutionMode.Execute when RequiresApproval(request.Prompt) => Result<Agent
                     SessionPhase.Review,
                     ApprovalState.Approved,
                     [CreateArtifact(request.SessionId, ReviewArtifact, ArtifactKind.Report)])),
-            _ => throw new UnreachableException(),
+            _ => Result<AgentTurnResult>.Fail(RuntimeCommunicationProblems.OrchestrationUnavailable()),
         });
     }
 

DotPilot.Runtime/Features/RuntimeFoundation/RuntimeFoundationCatalog.cs

@@ -28,7 +28,7 @@ public sealed class RuntimeFoundationCatalog : IRuntimeFoundationCatalog
         "Agent Framework integration is prepared as a separate slice that can plug into the embedded host without reshaping the UI layer.";
     private readonly IReadOnlyList<ProviderDescriptor> _providers;
 
-    public RuntimeFoundationCatalog() => _providers = CreateProviders();
+    public RuntimeFoundationCatalog() => _providers = Array.AsReadOnly(CreateProviders());
 
     public RuntimeFoundationSnapshot GetSnapshot()
     {
@@ -72,7 +72,7 @@ private static IReadOnlyList<RuntimeSliceDescriptor> CreateSlices()
         ];
     }
 
-    private static IReadOnlyList<ProviderDescriptor> CreateProviders()
+    private static ProviderDescriptor[] CreateProviders()
     {
         return
         [

DotPilot.Runtime/Features/ToolchainCenter/ToolchainCenterCatalog.cs

@@ -4,7 +4,7 @@ namespace DotPilot.Runtime.Features.ToolchainCenter;
 
 public sealed class ToolchainCenterCatalog : IToolchainCenterCatalog, IDisposable
 {
-    private const string EpicLabelValue = "PRESESSION READINESS";
+    private const string EpicLabelValue = "PRE-SESSION READINESS";
     private const string EpicSummary =
         "Provider installation, launch checks, authentication, configuration, and refresh state stay visible before the first live session.";
     private const string UiWorkstreamLabel = "SURFACE";

DotPilot.Tests/Features/RuntimeFoundation/RuntimeFoundationCatalogTests.cs

@@ -174,9 +174,11 @@ public void DeterministicClientRejectsUnexpectedExecutionModes()
         var client = new DeterministicAgentRuntimeClient();
         var invalidRequest = CreateRequest("Plan the runtime foundation rollout.", (AgentExecutionMode)int.MaxValue);
 
-        var action = () => client.ExecuteAsync(invalidRequest, CancellationToken.None);
+        var result = client.ExecuteAsync(invalidRequest, CancellationToken.None).AsTask().GetAwaiter().GetResult();
 
-        action.Should().Throw<System.Diagnostics.UnreachableException>();
+        result.IsFailed.Should().BeTrue();
+        result.HasProblem.Should().BeTrue();
+        result.Problem!.HasErrorCode(RuntimeCommunicationProblemCode.OrchestrationUnavailable).Should().BeTrue();
     }
 
     [Test]
@@ -221,6 +223,7 @@ public void CatalogCachesProviderListAcrossSnapshotReads()
         var secondSnapshot = catalog.GetSnapshot();
 
         ReferenceEquals(firstSnapshot.Providers, secondSnapshot.Providers).Should().BeTrue();
+        firstSnapshot.Providers.Should().NotBeAssignableTo<ProviderDescriptor[]>();
     }
 
     private static RuntimeFoundationCatalog CreateCatalog()

DotPilot.Tests/Features/ToolchainCenter/ToolchainCenterCatalogTests.cs

@@ -2,7 +2,7 @@ namespace DotPilot.Tests.Features.ToolchainCenter;
 
 public class ToolchainCenterCatalogTests
 {
-    private const string ToolchainEpicLabel = "PRESESSION READINESS";
+    private const string ToolchainEpicLabel = "PRE-SESSION READINESS";
 
     [Test]
     public void CatalogIncludesEpicIssueCoverageAndAllExternalProviders()
@@ -18,7 +18,7 @@ public void CatalogIncludesEpicIssueCoverageAndAllExternalProviders()
 
         snapshot.EpicLabel.Should().Be(ToolchainEpicLabel);
         snapshot.Summary.Should().NotContain("Issue #");
-        snapshot.Workstreams.Select(workstream => workstream.IssueLabel).Should().Equal("SURFACE", "DIAGNOSTICS", "CONFIGURATION", "POLLING");
+        snapshot.Workstreams.Select(workstream => workstream.SectionLabel).Should().Equal("SURFACE", "DIAGNOSTICS", "CONFIGURATION", "POLLING");
         coveredIssues.Should().Equal(
             ToolchainCenterIssues.ToolchainCenterUi,
             ToolchainCenterIssues.CodexReadiness,

DotPilot/Presentation/Controls/ToolchainCenterPanel.xaml

@@ -19,7 +19,7 @@
                      FontSize="11"
                      FontWeight="Medium"
                      Foreground="{StaticResource AppMutedTextBrush}"
-                     Text="{x:Bind Workstream.IssueLabel}" />
+                     Text="{x:Bind Workstream.SectionLabel}" />
           <TextBlock FontSize="13"
                      FontWeight="SemiBold"
                      Text="{x:Bind Workstream.Name}" />
@@ -44,7 +44,7 @@
                      FontSize="11"
                      FontWeight="Medium"
                      Foreground="{StaticResource AppMutedTextBrush}"
-                     Text="{x:Bind IssueLabel}" />
+                     Text="{x:Bind SectionLabel}" />
           <TextBlock FontSize="13"
                      FontWeight="SemiBold"
                      AutomationProperties.AutomationId="{x:Bind AutomationId}"
@@ -256,7 +256,7 @@
                          FontSize="11"
                          FontWeight="Medium"
                          Foreground="{StaticResource AppMutedTextBrush}"
-                         Text="{Binding SelectedToolchainProviderSnapshot.IssueLabel}" />
+                         Text="{Binding SelectedToolchainProviderSnapshot.SectionLabel}" />
               <TextBlock AutomationProperties.AutomationId="SelectedToolchainProviderTitle"
                          FontSize="20"
                          FontWeight="SemiBold"

DotPilot/Presentation/WorkbenchPresentationModels.cs

@@ -26,7 +26,7 @@ public sealed record ToolchainProviderItem(
 {
     public string DisplayName => Snapshot.Provider.DisplayName;
 
-    public string IssueLabel => Snapshot.IssueLabel;
+    public string SectionLabel => Snapshot.SectionLabel;
 
     public string ReadinessLabel => Snapshot.ReadinessState.ToString();
 

docs/Architecture.md

@@ -35,7 +35,6 @@ flowchart LR
   Adr3["ADR-0003 vertical slices + UI-only app"]
   Feature["agent-control-plane-experience.md"]
   Toolchains["toolchain-center.md"]
-  Plan["vertical-slice-runtime-foundation.plan.md"]
   Ui["DotPilot Uno UI host"]
   Core["DotPilot.Core contracts"]
   Runtime["DotPilot.Runtime services"]
@@ -49,7 +48,6 @@ flowchart LR
   Root --> Adr3
   Root --> Feature
   Root --> Toolchains
-  Root --> Plan
   Root --> Ui
   Root --> Core
   Root --> Runtime
@@ -195,7 +193,6 @@ flowchart LR
 ### Planning and decision docs
 
 - `Solution governance` — [../AGENTS.md](../AGENTS.md)
-- `Task plan` — [../issue-24-embedded-orleans-host.plan.md](../issue-24-embedded-orleans-host.plan.md)
 - `Primary architecture decision` — [ADR-0001](./ADR/ADR-0001-agent-control-plane-architecture.md)
 - `Vertical-slice solution decision` — [ADR-0003](./ADR/ADR-0003-vertical-slices-and-ui-only-uno-app.md)
 - `Feature spec` — [Agent Control Plane Experience](./Features/agent-control-plane-experience.md)

pr-review-comment-sweep.plan.md

@@ -0,0 +1,90 @@
+## Goal
+
+Address the meaningful review comments across all currently open PRs created by this branch owner, starting from the oldest open PR and moving forward, then validate the affected slices and keep the repository push-ready.
+
+## Scope
+
+In scope:
+- open PRs created by this account, processed oldest to newest
+- code-review comments, review threads, and actionable issue comments that still make engineering sense
+- code, tests, docs, and PR metadata changes needed to satisfy those comments
+- verification for each touched slice plus the final required repo validation
+
+Out of scope:
+- comments on already merged or closed PRs unless they reappear on an open PR
+- comments that are stale, incorrect, or conflict with newer accepted decisions
+- rebasing or rewriting unrelated branch history
+
+## Current PR Order
+
+1. PR `#79` — `codex/consolidated-13-15-76`
+2. PR `#80` — `codex/issue-24-embedded-orleans-host`
+3. PR `#81` — `codex/epic-12-embedded-runtime`
+4. PR `#82` — `codex/epic-11-foundation-contracts`
+
+## Constraints And Risks
+
+- Start with the oldest open PR and move forward.
+- Only fix comments that still make sense against the current repository state.
+- Keep serial `dotnet` execution; do not run concurrent build/test commands in one checkout.
+- Each production change needs corresponding automated coverage if behavior changes.
+- The branch may need updates that touch multiple slices; keep validation layered and honest.
+
+## Testing Methodology
+
+- Gather all open review comments and unresolved threads for PRs `#79-#82`.
+- For each PR, apply only the comments that remain valid.
+- Run focused tests around the touched slice before moving to the next PR.
+- After the sweep, run:
+  - `dotnet build DotPilot.slnx -warnaserror -m:1 -p:BuildInParallel=false`
+  - `dotnet test DotPilot.slnx`
+  - `dotnet format DotPilot.slnx --verify-no-changes`
+  - `dotnet test DotPilot.Tests/DotPilot.Tests.csproj --settings DotPilot.Tests/coverlet.runsettings --collect:"XPlat Code Coverage"`
+
+## Ordered Plan
+
+- [x] Confirm the open PR list and processing order.
+- [x] Collect actionable review comments and threads for PRs `#79`, `#80`, `#81`, and `#82`.
+- [x] Audit each comment for current validity and group them by PR and affected slice.
+- [x] Apply the valid fixes for PR `#79` and run focused verification.
+- [x] Apply the valid fixes for PR `#80` and run focused verification.
+- [x] Apply the valid fixes for PR `#81` and run focused verification.
+- [x] Apply the valid fixes for PR `#82` and run focused verification.
+- [x] Run the full repo validation sequence.
+- [x] Commit the sweep and push the branch updates needed for the affected PR heads.
+
+## Full-Test Baseline
+
+- [x] Sweep baseline captured from open PR review threads and current branch verification.
+- [x] PR `#79` focused verification passed:
+  - `dotnet build DotPilot.slnx -warnaserror -m:1 -p:BuildInParallel=false`
+  - `dotnet test DotPilot.Tests/DotPilot.Tests.csproj --filter "FullyQualifiedName~ToolchainCenter|FullyQualifiedName~RuntimeFoundation"`
+  - `dotnet test DotPilot.UITests/DotPilot.UITests.csproj --filter "FullyQualifiedName~WhenNavigatingToSettingsThenCategoriesAndEntriesAreVisible|FullyQualifiedName~WhenNavigatingToSettingsThenToolchainCenterProviderDetailsAreVisible|FullyQualifiedName~WhenSwitchingToolchainProvidersThenProviderSpecificDetailsAreVisible"`
+  - `dotnet format DotPilot.slnx --verify-no-changes`
+- [x] PR `#80` focused verification passed:
+  - `dotnet build DotPilot.slnx -warnaserror -m:1 -p:BuildInParallel=false`
+  - `dotnet test DotPilot.Tests/DotPilot.Tests.csproj --filter "FullyQualifiedName~EmbeddedRuntimeHost|FullyQualifiedName~ToolchainCommandProbe"`
+  - `dotnet format DotPilot.slnx --verify-no-changes`
+- [x] PR `#81` focused verification passed:
+  - `dotnet build DotPilot.slnx -warnaserror -m:1 -p:BuildInParallel=false`
+  - `dotnet test DotPilot.Tests/DotPilot.Tests.csproj --filter "FullyQualifiedName~AgentFrameworkRuntimeClient|FullyQualifiedName~EmbeddedRuntimeTrafficPolicy|FullyQualifiedName~RuntimeFoundationCatalog"`
+  - `dotnet format DotPilot.slnx --verify-no-changes`
+- [x] PR `#82` focused verification passed:
+  - `dotnet build DotPilot.slnx -warnaserror -m:1 -p:BuildInParallel=false`
+  - `dotnet test DotPilot.Tests/DotPilot.Tests.csproj --filter "FullyQualifiedName~ControlPlaneDomain"`
+  - `dotnet format DotPilot.slnx --verify-no-changes`
+- [x] Full repo validation passed on every updated PR head:
+  - PR `#79` (`codex/consolidated-13-15-76`): `60` unit tests, `22` UI tests, coverage collector green.
+  - PR `#80` (`codex/issue-24-embedded-orleans-host`): `68` unit tests, `22` UI tests, coverage collector green.
+  - PR `#81` (`codex/epic-12-embedded-runtime`): `75` unit tests, `22` UI tests, coverage collector green.
+  - PR `#82` (`codex/epic-11-foundation-contracts`): `61` unit tests, `22` UI tests, coverage collector green.
+
+## Tracked Failing Tests
+
+- [x] No failing tests remained after the PR sweep.
+
+## Done Criteria
+
+- Every meaningful open review comment across PRs `#79-#82` has been either fixed or explicitly rejected as stale/invalid.
+- Relevant focused tests are green after each PR-specific fix set.
+- The full repo validation sequence is green after the full sweep.