You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: AGENTS.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -132,7 +132,7 @@ For this app:
132
132
- unit tests currently use `NUnit` through the default `VSTest` runner
133
133
- UI tests live in `DotPilot.UITests` and are a mandatory part of normal verification; the harness must provision or resolve browser-driver prerequisites automatically instead of skipping when local setup is missing
134
134
- a canceled, timed-out, or hanging `DotPilot.UITests` run is a harness failure to fix, not an acceptable substitute for a real pass or fail result in CI
135
-
-`format` uses `dotnet format --verify-no-changes`
135
+
-`format` uses `dotnet format --verify-no-changes` as a local pre-push check; GitHub Actions validation should not spend CI time rechecking formatting drift that must already be fixed before push
136
136
- coverage uses the `coverlet.collector` integration on `DotPilot.Tests` with the repo runsettings file to keep generated Uno artifacts out of the coverage path
137
137
- desktop release publishing uses `dotnet publish DotPilot/DotPilot.csproj -c Release -f net10.0-desktop`; the validation workflow stays focused on build and automated tests, while the release workflow owns desktop publish outputs for macOS, Windows, and Linux
Copy file name to clipboardExpand all lines: github-actions-yaml-review.plan.md
+10-4Lines changed: 10 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,7 +2,7 @@
2
2
3
3
## Goal
4
4
5
-
Review the current GitHub Actions validation and release workflows, record concrete risks with line-level evidence, and capture any durable CI policy that emerged from the user conversation, including mandatory `-warnaserror` enforcement for local and CI builds.
5
+
Review the current GitHub Actions validation and release workflows, record concrete risks with line-level evidence, and capture any durable CI policy that emerged from the user conversation, including mandatory `-warnaserror` enforcement for local and CI builds and keeping formatting as a local pre-push concern instead of a CI gate.
6
6
7
7
## Scope
8
8
@@ -11,7 +11,7 @@ Review the current GitHub Actions validation and release workflows, record concr
11
11
-`.github/workflows/build-validation.yml`
12
12
-`.github/workflows/release-publish.yml`
13
13
- shared workflow assumptions from `.github/steps/install_dependencies/action.yml`
14
-
- root governance updates needed to capture durable CI runner policy and mandatory `-warnaserror` build usage
14
+
- root governance updates needed to capture durable CI runner policy, mandatory `-warnaserror` build usage, and local-only formatting policy
15
15
16
16
### Out Of Scope
17
17
@@ -56,13 +56,19 @@ Review the current GitHub Actions validation and release workflows, record concr
56
56
- no duplicate non-value build step remains after the change
57
57
Done when: CI and local build policy both require `-warnaserror`.
58
58
59
-
-[x] Step 4: Produce the workflow review findings.
59
+
-[x] Step 4: Apply the explicitly requested formatting-gate policy.
60
+
Verification:
61
+
-`build-validation.yml` no longer runs `dotnet format`
62
+
-`AGENTS.md` keeps format as a local pre-push check instead of a CI job step
63
+
Done when: formatting is enforced locally but not re-run as a GitHub Actions validation gate.
64
+
65
+
-[x] Step 5: Produce the workflow review findings.
60
66
Verification:
61
67
- findings reference exact files and lines
62
68
- findings are ordered by severity
63
69
Done when: the user can act on the review without needing another pass to discover the real problems.
0 commit comments