Skip to content

Commit 90c5391

Browse files
committed
Remove format from CI validation
1 parent 01f537c commit 90c5391

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

.github/workflows/build-validation.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,6 @@ jobs:
3434
timeout-minutes: 60
3535
uses: "./.github/steps/install_dependencies"
3636

37-
- name: Format
38-
shell: pwsh
39-
run: dotnet format DotPilot.slnx --verify-no-changes
40-
4137
- name: Build
4238
shell: pwsh
4339
run: dotnet build DotPilot.slnx -warnaserror

AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ For this app:
132132
- unit tests currently use `NUnit` through the default `VSTest` runner
133133
- UI tests live in `DotPilot.UITests` and are a mandatory part of normal verification; the harness must provision or resolve browser-driver prerequisites automatically instead of skipping when local setup is missing
134134
- a canceled, timed-out, or hanging `DotPilot.UITests` run is a harness failure to fix, not an acceptable substitute for a real pass or fail result in CI
135-
- `format` uses `dotnet format --verify-no-changes`
135+
- `format` uses `dotnet format --verify-no-changes` as a local pre-push check; GitHub Actions validation should not spend CI time rechecking formatting drift that must already be fixed before push
136136
- coverage uses the `coverlet.collector` integration on `DotPilot.Tests` with the repo runsettings file to keep generated Uno artifacts out of the coverage path
137137
- desktop release publishing uses `dotnet publish DotPilot/DotPilot.csproj -c Release -f net10.0-desktop`; the validation workflow stays focused on build and automated tests, while the release workflow owns desktop publish outputs for macOS, Windows, and Linux
138138
- `LangVersion` is pinned to `latest` at the root

github-actions-yaml-review.plan.md

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## Goal
44

5-
Review the current GitHub Actions validation and release workflows, record concrete risks with line-level evidence, and capture any durable CI policy that emerged from the user conversation, including mandatory `-warnaserror` enforcement for local and CI builds.
5+
Review the current GitHub Actions validation and release workflows, record concrete risks with line-level evidence, and capture any durable CI policy that emerged from the user conversation, including mandatory `-warnaserror` enforcement for local and CI builds and keeping formatting as a local pre-push concern instead of a CI gate.
66

77
## Scope
88

@@ -11,7 +11,7 @@ Review the current GitHub Actions validation and release workflows, record concr
1111
- `.github/workflows/build-validation.yml`
1212
- `.github/workflows/release-publish.yml`
1313
- shared workflow assumptions from `.github/steps/install_dependencies/action.yml`
14-
- root governance updates needed to capture durable CI runner policy and mandatory `-warnaserror` build usage
14+
- root governance updates needed to capture durable CI runner policy, mandatory `-warnaserror` build usage, and local-only formatting policy
1515

1616
### Out Of Scope
1717

@@ -56,13 +56,19 @@ Review the current GitHub Actions validation and release workflows, record concr
5656
- no duplicate non-value build step remains after the change
5757
Done when: CI and local build policy both require `-warnaserror`.
5858

59-
- [x] Step 4: Produce the workflow review findings.
59+
- [x] Step 4: Apply the explicitly requested formatting-gate policy.
60+
Verification:
61+
- `build-validation.yml` no longer runs `dotnet format`
62+
- `AGENTS.md` keeps format as a local pre-push check instead of a CI job step
63+
Done when: formatting is enforced locally but not re-run as a GitHub Actions validation gate.
64+
65+
- [x] Step 5: Produce the workflow review findings.
6066
Verification:
6167
- findings reference exact files and lines
6268
- findings are ordered by severity
6369
Done when: the user can act on the review without needing another pass to discover the real problems.
6470

65-
- [x] Step 5: Validate touched YAML/policy files.
71+
- [x] Step 6: Validate touched YAML/policy files.
6672
Verification:
6773
- `dotnet build DotPilot.slnx -warnaserror`
6874
- `actionlint .github/workflows/build-validation.yml`

0 commit comments

Comments
 (0)