Skip to content

Commit c73e46c

Browse files
committed
Disable Uno DSP in CI builds
1 parent b28121f commit c73e46c

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

DotPilot/DotPilot.csproj

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
-->
2626
<UnoFeatures>
2727
Material;
28-
Dsp;
2928
Hosting;
3029
Toolkit;
3130
Logging;
@@ -39,6 +38,10 @@
3938
</UnoFeatures>
4039
</PropertyGroup>
4140

41+
<PropertyGroup Condition="'$(CI)' != 'true'">
42+
<UnoFeatures>$(UnoFeatures);Dsp;</UnoFeatures>
43+
</PropertyGroup>
44+
4245
<PropertyGroup Condition="'$(TargetFramework)'=='net10.0-desktop'">
4346
<UnoFeatures>$(UnoFeatures);SkiaRenderer;</UnoFeatures>
4447
</PropertyGroup>

github-actions-yaml-review.plan.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,11 @@ Review the current GitHub Actions validation and release workflows, record concr
9090

9191
## Failing Tests And Checks Tracker
9292

93-
- [x] None currently tracked for this review-only pass.
93+
- [x] `Build Validation #23045490754 -> Quality Gate -> Build`
94+
Failure symptom: Windows CI build fails with `Uno.Dsp.Tasks.targets(20,3): error : Unable to find uno.themes.winui.markup in the Nuget cache.`
95+
Suspected cause: the `Dsp` Uno feature activates build-time DSP generation in CI even though the generated `Styles/ColorPaletteOverride.xaml` file is already checked into the repo; on GitHub Actions Windows the DSP task looks for a package identity that is not present in the restored NuGet cache.
96+
Intended fix path: keep `Dsp` enabled for local design-time regeneration only and disable it in CI by conditioning the feature on the `CI` environment property.
97+
Status: fixed locally; `CI=true dotnet build DotPilot.slnx -warnaserror` and `CI=true dotnet test DotPilot.slnx` both pass.
9498

9599
## Final Validation Skills
96100

0 commit comments

Comments
 (0)