You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: ci-pr-validation.plan.md
+8Lines changed: 8 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -103,6 +103,7 @@ Fix the GitHub Actions CI path used by `managedcode/dotPilot` so it builds with
103
103
- Local `dotnet build DotPilot.slnx` and `dotnet test DotPilot.Tests/DotPilot.Tests.csproj` already passed, which confirmed the primary CI break was the workflow toolchain path rather than product code.
104
104
- Local `dotnet test DotPilot.Tests/DotPilot.Tests.csproj --collect:"XPlat Code Coverage"` reproduced a second blocker: coverage did not crash, but `coverlet.collector` spent minutes instrumenting generated Uno artifacts before test execution began, which was not acceptable for PR validation.
105
105
- The workflow also lacked any desktop publish stage, so pull requests produced no downloadable app artifacts for human verification across macOS, Windows, and Linux.
106
+
- After the first PR push, GitHub rejected the new workflow before any jobs started because `timeout-minutes` used `fromJSON(env.STEP_TIMEOUT_MINUTES)` at the job level, where the `env` context is not available during workflow validation.
106
107
107
108
## Failing Tests And Checks Tracker
108
109
@@ -130,6 +131,12 @@ Fix the GitHub Actions CI path used by `managedcode/dotPilot` so it builds with
130
131
Intended fix path: add a stable matrix job that publishes `net10.0-desktop` on `macos-latest`, `windows-latest`, and `ubuntu-latest`, then uploads the publish directories as artifacts.
131
132
Status: fixed by the `Desktop Artifact` matrix job in `.github/workflows/ci.yml`.
132
133
134
+
-[x]`Workflow validation: instant failure before any CI jobs were created`
135
+
Failure symptom: the first pushed branch run failed in `0s` with no jobs or logs.
136
+
Suspected cause: GitHub Actions rejected the workflow because job-level `timeout-minutes` referenced `env`, which is not an allowed context at workflow-validation time.
137
+
Intended fix path: replace the dynamic timeout expression with literal timeout values and lint the workflow locally before pushing again.
138
+
Status: fixed by the literal `timeout-minutes: 60` update and local `actionlint` validation.
139
+
133
140
## Validation Notes
134
141
135
142
-`dotnet format DotPilot.slnx --verify-no-changes` passed.
@@ -140,6 +147,7 @@ Fix the GitHub Actions CI path used by `managedcode/dotPilot` so it builds with
140
147
-`dotnet test DotPilot.UITests/DotPilot.UITests.csproj` passed with `6` UI tests green and `0` skipped.
141
148
-`dotnet test DotPilot.slnx` passed and included both the unit and UI suites.
142
149
-`dotnet publish DotPilot/DotPilot.csproj -c Release -f net10.0-desktop` passed locally on macOS and produced a publish directory under `artifacts/local-macos-publish`.
150
+
-`actionlint .github/workflows/ci.yml` initially failed on invalid job-level `env` usage for `timeout-minutes`; after the fix it passed locally.
143
151
- GitHub repository ruleset `Require Full CI Validation` was created in active mode and initially required `Quality`, `Unit Tests`, `Coverage`, and `UI Tests` on the default branch and `refs/heads/release/*`; it now also needs the new desktop artifact checks after the workflow is pushed and verified.
0 commit comments