Restore complexity and CRAP to dotnet-quality

Author: KSemenenko

README.md

@@ -313,6 +313,7 @@ This catalog currently contains **157** skills.
 | [`dotnet-analyzer-config`](catalog/Tools/Analyzer-Config/skills/dotnet-analyzer-config/) | `1.0.0` | Use a repo-root `.editorconfig` to configure free .NET analyzer and style rules. Use when a .NET repo needs rule severity, code-style options, section layout, or analyzer ownership made explicit. Nested `.editorconfig` files are allowed when they serve a clear subtree-specific purpose. |
 | [`dotnet-chous`](catalog/Tools/Chous/skills/dotnet-chous/) | `1.0.0` | Use Chous in .NET repositories that ship sizeable frontend codebases and want file-structure linting, naming convention enforcement, and folder-layout policy as a CLI gate. Use when the problem is frontend architecture drift in the file tree rather than semantic code issues inside the files. |
 | [`dotnet-code-analysis`](catalog/Tools/Code-Analysis/skills/dotnet-code-analysis/) | `1.0.1` | Use the free built-in .NET SDK analyzers and analysis levels with gradual Roslyn warning promotion. Use when a .NET repo needs first-party code analysis, `EnableNETAnalyzers`, `AnalysisLevel`, or warning-as-error policy wired into build and CI. |
+| [`dotnet-complexity`](catalog/Tools/Complexity/skills/dotnet-complexity/) | `1.0.0` | Use free built-in .NET maintainability analyzers and code metrics configuration to find overly complex methods and coupled code. Use when a repo needs cyclomatic complexity checks, maintainability thresholds, or complexity-driven refactoring gates. |
 | [`dotnet-csharpier`](catalog/Tools/CSharpier/skills/dotnet-csharpier/) | `1.0.0` | Use the open-source free `CSharpier` formatter for C# and XML. Use when a .NET repo intentionally wants one opinionated formatter instead of a highly configurable `dotnet format`-driven style model. |
 | [`dotnet-format`](catalog/Tools/Format/skills/dotnet-format/) | `1.0.0` | Use the free first-party `dotnet format` CLI for .NET formatting and analyzer fixes. Use when a .NET repo needs formatting commands, `--verify-no-changes` CI checks, or `.editorconfig`-driven code style enforcement. |
 | [`dotnet-metalint`](catalog/Tools/Metalint/skills/dotnet-metalint/) | `1.0.0` | Use Metalint in .NET repositories that ship Node-based frontend assets and want one CLI entrypoint over several underlying linters. Use when a repo wants to orchestrate ESLint, Stylelint, HTMLHint, and related frontend checks from a single checked-in `.metalint/` configuration. |
@@ -368,7 +369,6 @@ This catalog currently contains **157** skills.
 | [`dotnet-asynkron-profiler`](catalog/Tools/Asynkron-Profiler/skills/dotnet-asynkron-profiler/) | `1.0.0` | Use the open-source free `Asynkron.Profiler` dotnet tool for CLI-first CPU, allocation, exception, contention, and heap profiling of .NET commands or existing trace artifacts. |
 | [`dotnet-cloc`](catalog/Tools/cloc/skills/dotnet-cloc/) | `1.0.0` | Use the open-source free `cloc` tool for line-count, language-mix, and diff statistics in .NET repositories. Use when a repo needs C# and solution footprint metrics, branch-to-branch LOC comparison, or repeatable code-size reporting in local workflows and CI. |
 | [`dotnet-codeql`](catalog/Tools/CodeQL/skills/dotnet-codeql/) | `1.0.0` | Use the open-source CodeQL ecosystem for .NET security analysis. Use when a repo needs CodeQL query packs, CLI-based analysis on open source codebases, or GitHub Action setup with explicit licensing caveats for private repositories. |
-| [`dotnet-complexity`](catalog/Tools/Complexity/skills/dotnet-complexity/) | `1.0.0` | Use free built-in .NET maintainability analyzers and code metrics configuration to find overly complex methods and coupled code. Use when a repo needs cyclomatic complexity checks, maintainability thresholds, or complexity-driven refactoring gates. |
 | [`dotnet-profiling`](catalog/Tools/Profiling/skills/dotnet-profiling/) | `1.0.0` | Use the free official .NET diagnostics CLI tools for profiling and runtime investigation in .NET repositories. Use when a repo needs CPU tracing, live counters, GC and allocation investigation, exception or contention tracing, heap snapshots, or startup diagnostics without GUI-only tooling. |
 | [`dotnet-quickdup`](catalog/Tools/QuickDup/skills/dotnet-quickdup/) | `1.0.0` | Use the open-source free `QuickDup` clone detector for .NET repositories. Use when a repo needs duplicate C# code discovery, structural clone detection, DRY refactoring candidates, or repeatable duplication scans in local workflows and CI. |
 | [`dotnet-trace-collect`](catalog/Tools/Official-DotNet-Diagnostics/skills/dotnet-trace-collect/) | `0.1.0` | Guide developers through capturing diagnostic artifacts to diagnose production .NET performance issues. Use when the user needs help choosing diagnostic tools, collecting performance data, or understanding tool trade-offs across different environments (Windows/Linux, .NET Framework/modern .NET, container/non-container). |

catalog/Tools/Complexity/skills/dotnet-complexity/manifest.json

@@ -1,4 +1,4 @@
 {
   "version": "1.0.0",
-  "category": "Metrics"
+  "category": "Code Quality"
 }

cli/ManagedCode.DotnetSkills/Runtime/CatalogScanner.cs

@@ -29,7 +29,7 @@ internal static class CatalogScanner
         new(
             "dotnet-quality",
             ".NET quality bundle",
-            "Install the core .NET quality toolchain: formatter, analyzers, editorconfig guidance, and CI quality checks. Frontend linters stay out of this bundle on purpose.",
+            "Install the core .NET quality toolchain: formatter, analyzers, complexity checks, CRAP analysis, editorconfig guidance, and CI quality checks. Frontend linters stay out of this bundle on purpose.",
             "stack",
             ".NET Quality",
             "Code Quality",
@@ -42,6 +42,8 @@ internal static class CatalogScanner
                 "dotnet-stylecop-analyzers",
                 "dotnet-analyzer-config",
                 "dotnet-code-analysis",
+                "dotnet-complexity",
+                "crap-score",
             ]),
         new(
             "frontend-quality",

scripts/catalog_index.py

@@ -32,7 +32,7 @@
     {
         "name": "dotnet-quality",
         "title": ".NET quality bundle",
-        "description": "Install the core .NET quality toolchain: formatter, analyzers, editorconfig guidance, and CI quality checks. Frontend linters stay out of this bundle on purpose.",
+        "description": "Install the core .NET quality toolchain: formatter, analyzers, complexity checks, CRAP analysis, editorconfig guidance, and CI quality checks. Frontend linters stay out of this bundle on purpose.",
         "kind": "stack",
         "stack": ".NET Quality",
         "lane": "Code Quality",
@@ -45,6 +45,8 @@
             "dotnet-stylecop-analyzers",
             "dotnet-analyzer-config",
             "dotnet-code-analysis",
+            "dotnet-complexity",
+            "crap-score",
         ],
     },
     {

tests/ManagedCode.DotnetSkills.Tests/CatalogOrganizationTests.cs

@@ -33,6 +33,7 @@ public void Load_AssignsExpectedStacksAndLanes()
         AssertSkill(catalog, "template-authoring", "Templates & Scaffolding", "Project & Templates");
         AssertSkill(catalog, "analyzing-dotnet-performance", "Diagnostics & Metrics", "Performance");
         AssertSkill(catalog, "dotnet-cloc", "Diagnostics & Metrics", "Observability");
+        AssertSkill(catalog, "dotnet-complexity", ".NET Quality", "Code Quality");
         AssertSkill(catalog, "dotnet-codeql", "Diagnostics & Metrics", "Static Analysis");
         AssertSkill(catalog, "mtp-hot-reload", "Upgrades & Migration", "Testing migrations");
         AssertSkill(catalog, "migrate-xunit-to-xunit-v3", "Upgrades & Migration", "Testing migrations");
@@ -59,6 +60,8 @@ public void Load_ExposesFocusedBundles_WithoutMixingQualityAndMigrationFlows()
         Assert.Equal(".NET Quality", dotnetQuality.Stack);
         Assert.Equal("Code Quality", dotnetQuality.Lane);
         Assert.DoesNotContain(dotnetQuality.Skills, skill => string.Equals(skill, "dotnet-eslint", StringComparison.OrdinalIgnoreCase));
+        Assert.Contains(dotnetQuality.Skills, skill => string.Equals(skill, "dotnet-complexity", StringComparison.OrdinalIgnoreCase));
+        Assert.Contains(dotnetQuality.Skills, skill => string.Equals(skill, "crap-score", StringComparison.OrdinalIgnoreCase));
 
         Assert.Equal(".NET Foundations", dotnetBase.Stack);
         Assert.Equal("Foundations", dotnetBase.Lane);

tests/ManagedCode.DotnetSkills.Tests/SkillInstallerTests.cs

@@ -70,6 +70,8 @@ public void SelectSkillsFromPackages_ResolvesFocusedBundlesOnly()
         Assert.Contains(selected, skill => skill.Name == "dotnet-orleans");
         Assert.Contains(selected, skill => skill.Name == "dotnet-managedcode-orleans-graph");
         Assert.Contains(selected, skill => skill.Name == "dotnet-code-analysis");
+        Assert.Contains(selected, skill => skill.Name == "dotnet-complexity");
+        Assert.Contains(selected, skill => skill.Name == "crap-score");
         Assert.Contains(selected, skill => skill.Name == "dotnet-format");
         Assert.Equal(selected.Select(skill => skill.Name).Distinct(StringComparer.OrdinalIgnoreCase).Count(), selected.Count);
     }