Fix test failures: httpx Response request param and mock pattern

httpx.Response needs request param for raise_for_status.
Replace broken new_callable pattern with @patch('app.modal').

Author: manascb1344

tests/test_app.py

@@ -46,7 +46,8 @@ def _make_webhook_body(
 
 @pytest.mark.asyncio
 async def test_call_github_api_success_on_first_attempt():
-    mock_response = httpx.Response(200, json={"ok": True})
+    req = httpx.Request("POST", "http://test")
+    mock_response = httpx.Response(200, json={"ok": True}, request=req)
     mock_client = AsyncMock()
     mock_client.request = AsyncMock(return_value=mock_response)
 
@@ -59,15 +60,16 @@ async def test_call_github_api_success_on_first_attempt():
 
 @pytest.mark.asyncio
 async def test_call_github_api_retries_on_429():
-    response_429 = httpx.Response(429)
-    response_ok = httpx.Response(200, json={"ok": True})
+    req = httpx.Request("POST", "http://test")
+    response_429 = httpx.Response(429, request=req)
+    response_ok = httpx.Response(200, json={"ok": True}, request=req)
 
     mock_client = AsyncMock()
     mock_client.request = AsyncMock(
         side_effect=[
             httpx.HTTPStatusError(
                 "rate limited",
-                request=httpx.Request("POST", "http://test"),
+                request=req,
                 response=response_429,
             ),
             response_ok,
@@ -85,15 +87,16 @@ async def test_call_github_api_retries_on_429():
 
 @pytest.mark.asyncio
 async def test_call_github_api_retries_on_500():
-    response_500 = httpx.Response(500)
-    response_ok = httpx.Response(200, json={"ok": True})
+    req = httpx.Request("POST", "http://test")
+    response_500 = httpx.Response(500, request=req)
+    response_ok = httpx.Response(200, json={"ok": True}, request=req)
 
     mock_client = AsyncMock()
     mock_client.request = AsyncMock(
         side_effect=[
             httpx.HTTPStatusError(
                 "server error",
-                request=httpx.Request("POST", "http://test"),
+                request=req,
                 response=response_500,
             ),
             response_ok,
@@ -111,13 +114,14 @@ async def test_call_github_api_retries_on_500():
 
 @pytest.mark.asyncio
 async def test_call_github_api_no_retry_on_404():
-    response_404 = httpx.Response(404)
+    req = httpx.Request("POST", "http://test")
+    response_404 = httpx.Response(404, request=req)
 
     mock_client = AsyncMock()
     mock_client.request = AsyncMock(
         side_effect=httpx.HTTPStatusError(
             "not found",
-            request=httpx.Request("POST", "http://test"),
+            request=req,
             response=response_404,
         )
     )
@@ -132,7 +136,8 @@ async def test_call_github_api_no_retry_on_404():
 
 @pytest.mark.asyncio
 async def test_call_github_api_retries_on_timeout():
-    response_ok = httpx.Response(200, json={"ok": True})
+    req = httpx.Request("POST", "http://test")
+    response_ok = httpx.Response(200, json={"ok": True}, request=req)
 
     mock_client = AsyncMock()
     mock_client.request = AsyncMock(
@@ -153,13 +158,14 @@ async def test_call_github_api_retries_on_timeout():
 
 @pytest.mark.asyncio
 async def test_call_github_api_exhausts_retries():
-    response_429 = httpx.Response(429)
+    req = httpx.Request("POST", "http://test")
+    response_429 = httpx.Response(429, request=req)
 
     mock_client = AsyncMock()
     mock_client.request = AsyncMock(
         side_effect=httpx.HTTPStatusError(
             "rate limited",
-            request=httpx.Request("POST", "http://test"),
+            request=req,
             response=response_429,
         )
     )
@@ -254,16 +260,9 @@ async def test_verify_signature_bad_content_type():
 # =============================================================================
 
 
-def _mock_modal():
-    modal_mock = MagicMock()
-    modal_mock.Sandbox.list.return_value = []
-    modal_mock.Sandbox.create.return_value = MagicMock()
-    return modal_mock
-
-
 @pytest.mark.asyncio
-@patch("app.modal", new_callable=_mock_modal)
-async def test_webhook_missing_workflow_job(_mock_modal_obj):
+@patch("app.modal")
+async def test_webhook_missing_workflow_job(mock_modal):
     from fastapi import HTTPException
 
     from app import github_webhook
@@ -280,8 +279,8 @@ async def test_webhook_missing_workflow_job(_mock_modal_obj):
 
 
 @pytest.mark.asyncio
-@patch("app.modal", new_callable=_mock_modal)
-async def test_webhook_missing_repository(_mock_modal_obj):
+@patch("app.modal")
+async def test_webhook_missing_repository(mock_modal):
     from fastapi import HTTPException
 
     from app import github_webhook
@@ -296,8 +295,8 @@ async def test_webhook_missing_repository(_mock_modal_obj):
 
 
 @pytest.mark.asyncio
-@patch("app.modal", new_callable=_mock_modal)
-async def test_webhook_missing_labels(_mock_modal_obj):
+@patch("app.modal")
+async def test_webhook_missing_labels(mock_modal):
     from fastapi import HTTPException
 
     from app import github_webhook
@@ -318,8 +317,8 @@ async def test_webhook_missing_labels(_mock_modal_obj):
 
 
 @pytest.mark.asyncio
-@patch("app.modal", new_callable=_mock_modal)
-async def test_webhook_ignores_non_modal_labels(_mock_modal_obj):
+@patch("app.modal")
+async def test_webhook_ignores_non_modal_labels(mock_modal):
     from app import github_webhook
 
     body = _make_webhook_body(labels=["self-hosted", "ubuntu"])
@@ -331,8 +330,8 @@ async def test_webhook_ignores_non_modal_labels(_mock_modal_obj):
 
 
 @pytest.mark.asyncio
-@patch("app.modal", new_callable=_mock_modal)
-async def test_webhook_ignores_non_queued_action(_mock_modal_obj):
+@patch("app.modal")
+async def test_webhook_ignores_non_queued_action(mock_modal):
     from app import github_webhook
 
     body = _make_webhook_body(action="started")
@@ -343,8 +342,8 @@ async def test_webhook_ignores_non_queued_action(_mock_modal_obj):
 
 
 @pytest.mark.asyncio
-@patch("app.modal", new_callable=_mock_modal)
-async def test_webhook_rejects_invalid_json(_mock_modal_obj):
+@patch("app.modal")
+async def test_webhook_rejects_invalid_json(mock_modal):
     from fastapi import HTTPException
 
     from app import github_webhook
@@ -359,8 +358,8 @@ async def test_webhook_rejects_invalid_json(_mock_modal_obj):
 
 
 @pytest.mark.asyncio
-@patch("app.modal", new_callable=_mock_modal)
-async def test_webhook_rejects_invalid_repo_url(_mock_modal_obj):
+@patch("app.modal")
+async def test_webhook_rejects_invalid_repo_url(mock_modal):
     from fastapi import HTTPException
 
     from app import github_webhook