Revert to direct sandbox spawning (queue approach needs running processor)

Author: manascb1344

app.py

@@ -190,79 +190,6 @@ async def verify_signature(request: Request, body: bytes) -> str | None:
     return delivery_id
 
 
-async def _spawn_single_sandbox(job_data: dict):
-    """Helper to spawn a single sandbox and wait for completion."""
-    job_id = job_data["job_id"]
-    jit_config = job_data["jit_config"]
-
-    logger.info(f"Spawning sandbox for job {job_id}")
-
-    try:
-        cmd = "cd /actions-runner && export RUNNER_ALLOW_RUNASROOT=1 && ./run.sh --jitconfig $GHA_JIT_CONFIG"
-
-        sandbox = modal.Sandbox.create(
-            "bash",
-            "-c",
-            cmd,
-            image=runner_image,
-            app=app,
-            timeout=TIMEOUT_SECONDS,
-            env={"GHA_JIT_CONFIG": jit_config},
-        )
-
-        sandbox.set_tags({"job_id": str(job_id)})
-
-        # Wait for completion
-        sandbox.wait()
-
-        logger.info(f"Sandbox for job {job_id} completed")
-
-    except Exception as e:
-        logger.error(f"Failed to spawn sandbox for job {job_id}: {type(e).__name__}")
-        raise
-
-
-@app.function(image=runner_image, secrets=[github_secret])
-async def process_job_batch():
-    """Process jobs from queue with controlled concurrency using asyncio.Semaphore.
-
-    This function runs continuously, pulling jobs from the queue and spawning
-    sandboxes with max DEFAULT_MAX_PARALLEL concurrent executions.
-    """
-    semaphore = asyncio.Semaphore(DEFAULT_MAX_PARALLEL)
-
-    logger.info(
-        f"Starting job processor with max {DEFAULT_MAX_PARALLEL} concurrent sandboxes"
-    )
-
-    while True:
-        try:
-            # Get job from queue (blocks until available)
-            job_data = await job_queue.get.aio()
-
-            if job_data is None:
-                # Sentinel value to stop processing
-                break
-
-            # Acquire semaphore before spawning
-            await semaphore.acquire()
-
-            # Spawn sandbox in background task so we can continue to next job
-            asyncio.create_task(_process_with_semaphore(semaphore, job_data))
-
-        except Exception as e:
-            logger.error(f"Error in job processor: {type(e).__name__}: {e}")
-            await asyncio.sleep(1)
-
-
-async def _process_with_semaphore(semaphore: asyncio.Semaphore, job_data: dict):
-    """Process a job and release semaphore when done."""
-    try:
-        await _spawn_single_sandbox(job_data)
-    finally:
-        semaphore.release()
-
-
 @app.function(image=runner_image, secrets=[github_secret])
 @modal.fastapi_endpoint(method="POST")
 async def github_webhook(request: Request):
@@ -426,25 +353,27 @@ async def github_webhook(request: Request):
             )
             raise HTTPException(status_code=500, detail="Internal server error")
 
-    logger.info(f"Queueing job {job_id} for processing...")
+    logger.info(f"Spawning sandbox for job {job_id}...")
 
     try:
-        # Prepare job data for queue
-        job_data = {
-            "job_id": job_id,
-            "repo_url": repo_url,
-            "job_labels": job_labels,
-            "jit_config": jit_config,
-        }
+        cmd = "cd /actions-runner && export RUNNER_ALLOW_RUNASROOT=1 && ./run.sh --jitconfig $GHA_JIT_CONFIG"
 
-        # Put job in queue for processor
-        await job_queue.put.aio(job_data)
+        sandbox = modal.Sandbox.create(
+            "bash",
+            "-c",
+            cmd,
+            image=runner_image,
+            app=app,
+            timeout=TIMEOUT_SECONDS,
+            env={"GHA_JIT_CONFIG": jit_config},
+        )
 
-        logger.info(f"Successfully queued job {job_id}")
+        sandbox.set_tags({"job_id": str(job_id)})
+
+        logger.info(f"Successfully spawned sandbox for job {job_id}")
 
     except Exception as e:
-        logger.error(f"Failed to queue job {job_id}: {type(e).__name__}")
-        raise HTTPException(status_code=500, detail="Failed to queue job")
+        logger.error(f"Failed to spawn sandbox for job {job_id}: {type(e).__name__}")
+        raise HTTPException(status_code=500, detail="Failed to spawn runner sandbox")
 
-    logger.info(f"Successfully queued runner for job {job_id}")
-    return {"status": "queued", "job_id": job_id}
+    return {"status": "provisioned", "job_id": job_id}