Skip to content

Commit 68e6fc0

Browse files
committed
Remove modal mock from webhook validation tests
Tests for payload validation, label checks, and action filtering don't reach sandbox creation code, so modal mock is unnecessary and caused TypeError with Modal's Function objects.
1 parent 5e9d682 commit 68e6fc0

1 file changed

Lines changed: 7 additions & 14 deletions

File tree

tests/test_app.py

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -261,8 +261,7 @@ async def test_verify_signature_bad_content_type():
261261

262262

263263
@pytest.mark.asyncio
264-
@patch("app.modal")
265-
async def test_webhook_missing_workflow_job(mock_modal):
264+
async def test_webhook_missing_workflow_job():
266265
from fastapi import HTTPException
267266

268267
from app import github_webhook
@@ -279,8 +278,7 @@ async def test_webhook_missing_workflow_job(mock_modal):
279278

280279

281280
@pytest.mark.asyncio
282-
@patch("app.modal")
283-
async def test_webhook_missing_repository(mock_modal):
281+
async def test_webhook_missing_repository():
284282
from fastapi import HTTPException
285283

286284
from app import github_webhook
@@ -295,8 +293,7 @@ async def test_webhook_missing_repository(mock_modal):
295293

296294

297295
@pytest.mark.asyncio
298-
@patch("app.modal")
299-
async def test_webhook_missing_labels(mock_modal):
296+
async def test_webhook_missing_labels():
300297
from fastapi import HTTPException
301298

302299
from app import github_webhook
@@ -317,8 +314,7 @@ async def test_webhook_missing_labels(mock_modal):
317314

318315

319316
@pytest.mark.asyncio
320-
@patch("app.modal")
321-
async def test_webhook_ignores_non_modal_labels(mock_modal):
317+
async def test_webhook_ignores_non_modal_labels():
322318
from app import github_webhook
323319

324320
body = _make_webhook_body(labels=["self-hosted", "ubuntu"])
@@ -330,8 +326,7 @@ async def test_webhook_ignores_non_modal_labels(mock_modal):
330326

331327

332328
@pytest.mark.asyncio
333-
@patch("app.modal")
334-
async def test_webhook_ignores_non_queued_action(mock_modal):
329+
async def test_webhook_ignores_non_queued_action():
335330
from app import github_webhook
336331

337332
body = _make_webhook_body(action="started")
@@ -342,8 +337,7 @@ async def test_webhook_ignores_non_queued_action(mock_modal):
342337

343338

344339
@pytest.mark.asyncio
345-
@patch("app.modal")
346-
async def test_webhook_rejects_invalid_json(mock_modal):
340+
async def test_webhook_rejects_invalid_json():
347341
from fastapi import HTTPException
348342

349343
from app import github_webhook
@@ -358,8 +352,7 @@ async def test_webhook_rejects_invalid_json(mock_modal):
358352

359353

360354
@pytest.mark.asyncio
361-
@patch("app.modal")
362-
async def test_webhook_rejects_invalid_repo_url(mock_modal):
355+
async def test_webhook_rejects_invalid_repo_url():
363356
from fastapi import HTTPException
364357

365358
from app import github_webhook

0 commit comments

Comments
 (0)