Skip to content

Commit 8b9857f

Browse files
committed
fix: runner not picking up jobs - bash syntax error and label contention
- Remove trailing & causing bash syntax error (& &&) in SANDBOX_CMD - Add unique job-${{ github.run_id }} label to test.yml runs-on to prevent label contention between JIT runners
1 parent 387b0bd commit 8b9857f

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66

77
jobs:
88
test-modal-runner:
9-
runs-on: [self-hosted, modal]
9+
runs-on: [self-hosted, modal, "job-${{ github.run_id }}"]
1010
steps:
1111
- name: Hello World
1212
run: |

runner/services/sandbox_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ def build_runner_image() -> modal.Image:
115115
SANDBOX_CMD = (
116116
"bash -c '/start-dockerd.sh &'"
117117
" && for i in $(seq 1 10); do docker info > /dev/null 2>&1 && break; sleep 1; done"
118-
" && (docker load -i /images/node-22-alpine.tar 2>/dev/null || true) &"
118+
" && (docker load -i /images/node-22-alpine.tar 2>/dev/null || true)"
119119
" && cd /actions-runner"
120120
" && export RUNNER_ALLOW_RUNASROOT=1"
121121
" && export DOCKER_BUILDKIT=1"

0 commit comments

Comments
 (0)