Skip to content

Commit ca5b351

Browse files
committed
fix: configure only the named app logger instead of mutating global root logger
1 parent 97fcc36 commit ca5b351

1 file changed

Lines changed: 10 additions & 8 deletions

File tree

runner/logging.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,15 @@ def format(self, record: logging.LogRecord) -> str:
3030

3131

3232
def setup_logging(level: int = logging.INFO) -> logging.Logger:
33-
"""Configure root logger with JSON formatter and return the app logger."""
34-
handler = logging.StreamHandler()
35-
handler.setFormatter(JsonFormatter())
33+
"""Configure app logger with JSON formatter without mutating global root logger."""
34+
app_logger = logging.getLogger("modal-github-runner")
3635

37-
root_logger = logging.getLogger()
38-
root_logger.handlers.clear()
39-
root_logger.addHandler(handler)
40-
root_logger.setLevel(level)
36+
if not app_logger.handlers:
37+
handler = logging.StreamHandler()
38+
handler.setFormatter(JsonFormatter())
39+
app_logger.addHandler(handler)
4140

42-
return logging.getLogger("modal-github-runner")
41+
app_logger.setLevel(level)
42+
app_logger.propagate = False
43+
44+
return app_logger

0 commit comments

Comments
 (0)