Skip to content

feat(idp): wire trust_email_assertions through Create/Update API (WS5)#416

Merged
PaulDotterer merged 1 commit into
mainfrom
feat/idp-trust-email-wiring
Jun 13, 2026
Merged

feat(idp): wire trust_email_assertions through Create/Update API (WS5)#416
PaulDotterer merged 1 commit into
mainfrom
feat/idp-trust-email-wiring

Conversation

@PaulDotterer

Copy link
Copy Markdown
Contributor

Completes the WS5 trust_email_assertions opt-in: PR #412 added the flag + the SCIM AutoLinkByEmail account-takeover gate, but the flag had no Create/Update RPC field (settable only via a raw event). With the sdk proto field (manchtools/power-manage-sdk#98), this maps req.Msg.TrustEmailAssertions into the IdentityProviderCreated/Updated events and returns it on the IdentityProvider response — so operators can enable it via API/UI. Default false (secure).

Bumps sdk to the proto field. Test: create-with-flag / read-back / update-off / default-false round-trip. Closes #415.

…sponse

PR #412 added the trust_email_assertions flag + SCIM AutoLinkByEmail
account-takeover gate, but the flag had no Create/Update RPC field — operators
could only set it via a raw event. With the sdk proto field
(manchtools/power-manage-sdk#98), map req.Msg.TrustEmailAssertions into the
IdentityProviderCreated/Updated events and return it on the IdentityProvider
response, so it is settable + visible via the API/UI. Default false (secure).

Bumps sdk to the proto field. Closes the WS5 trust_email follow-up.
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@PaulDotterer, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 21 minutes and 6 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dd98f215-bf15-4db4-89bf-528b7842134d

📥 Commits

Reviewing files that changed from the base of the PR and between 1eae492 and 26a0107.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (4)
  • go.mod
  • internal/api/idp_handler.go
  • internal/api/idp_handler_test.go
  • internal/eventtypes/payloads/idp.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/idp-trust-email-wiring

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PaulDotterer PaulDotterer merged commit 989c4fb into main Jun 13, 2026
9 checks passed
@PaulDotterer PaulDotterer deleted the feat/idp-trust-email-wiring branch June 13, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: wire trust_email_assertions through Create/Update IdP API (WS5 follow-up)

1 participant