Skip to content

Accept self-hosted CAPE version strings without warning#3118

Open
itxsamad1 wants to merge 1 commit into
mandiant:masterfrom
itxsamad1:fix/cape-version-strings
Open

Accept self-hosted CAPE version strings without warning#3118
itxsamad1 wants to merge 1 commit into
mandiant:masterfrom
itxsamad1:fix/cape-version-strings

Conversation

@itxsamad1

Copy link
Copy Markdown

Summary

  • Include self-hosted CAPE version strings (2.2, 2.4, 2.5) alongside capesandbox.com suffixed forms in TESTED_VERSIONS
  • Prevents spurious unsupported-version warnings on standard self-hosted CAPE reports

Fixes #3082

Test plan

  • pytest tests/test_cape_model.py::test_cape_tested_versions_include_self_hosted_strings

Self-hosted CAPE instances report version strings like 2.5 while capesandbox.com uses 2.5-CAPE. Include both forms in TESTED_VERSIONS.

Fixes mandiant#3082

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the TESTED_VERSIONS set in the CAPE extractor to include self-hosted version strings ("2.2", "2.4", "2.5") alongside the existing "-CAPE" suffixed versions. Additionally, a unit test has been added to verify that these version strings are correctly present in the set. There are no review comments, so no feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@williballenthin

Copy link
Copy Markdown
Collaborator

@itxsamad1 please provide test cape archives with this data, sourced from a real installation. otherwise, i don't trust this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CapeExtractor version mismatch warning on self-hosted CAPE reports

2 participants