refactored codebase a/c napoleon style#979
Conversation
|
@mr-tz @williballenthin I have made changes using the isort , for the code style. |
|
please fix isort/black issues first |
|
Corrected the isort and black issues @mr-tz |
|
code style looks good now, this will take a bit to go through also other tests fail, need to look into those |
|
Can you look into the test failures, please? |
|
@mr-tz Sure ill look into it. |
|
Can you rebase this to master to (maybe) fix the test failures, please? Otherwise, we have to look closer at them. |
|
@mr-tz Sure i will take a look. |
2ce601e to
a0ee25a
Compare
|
@RahulSankhla312 do you know what's failing here? |
|
@RahulSankhla312 another ping, otherwise we may have to close this here |
|
name: CI on: Save workspaces to speed up testingenv: jobs: tests: |
|
cc: @vee1e as we talked about doc improvements, just fyi |
|
yup, I think this can easily be made doxygen compatible by letting a good enough agent go through this. |
|
Hi maintainers, thanks for reviewing this PR. I noticed there are merge conflicts with the latest Please let me know if you prefer this refactoring to be split into smaller PRs — happy to do that. Looking forward to your feedback! |
|
@Abhishekjc19 are you making a new PR to resolve the conflicts? because @RahulSankhla312 is the author of this PR |
Thanks for pointing that out! I’m not the author of this PR — I was just suggesting resolving the merge conflicts. The actual updates would need to be made by @RahulSankhla312. Happy to help review or assist if needed. |
Changed the whole codebase Refactored codebase to consistently use Napoleon-style docstrings.
Improves code readability and maintainability by providing clear function and class descriptions.