test: repair test infrastructure, add lib unit tests and CI

The karma setup had been broken since the v20/v21 builder migrations
and no test target existed for the library itself.

Infrastructure:
- remove the removed @angular-devkit/build-angular karma framework/
  plugin from all karma.conf.js files
- pass polyfills as array to @angular/build:karma (sample,
  quickstart-demo)
- add karma-coverage required by the new builder's default plugin set
- drop reference to non-existent src/test.ts from lib tsconfig.spec

Tests:
- add a test target for the lib plus its first unit tests:
  UrlHelperService parsing and DefaultHashHandler sha-256 against a
  known vector
- add JwksValidationHandler guard-clause specs (suite was empty)
- rewrite the stale quickstart scaffold specs: boot the components
  with the real OAuth providers and assert the discovery document
  request via HttpTestingController

CI:
- add npm run test:ci running all five suites headless single-run
- add GitHub Actions workflow building lib, jwks and sample and
  running test:ci on pushes to master and pull requests

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: L-X-T

.github/workflows/ci.yml

@@ -0,0 +1,32 @@
+name: CI
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+
+jobs:
+  build-and-test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 22
+          cache: npm
+
+      - name: Install dependencies
+        run: npm ci --legacy-peer-deps
+
+      - name: Build library
+        run: npx ng build lib --configuration production
+
+      - name: Build angular-oauth2-oidc-jwks
+        run: npx ng build angular-oauth2-oidc-jwks --ts-config tsconfig.npm.json
+
+      - name: Build sample app
+        run: npx ng build sample
+
+      - name: Run unit tests
+        run: npm run test:ci

angular.json

@@ -30,6 +30,17 @@
               "projects/lib/**/*.html"
             ]
           }
+        },
+        "test": {
+          "builder": "@angular/build:karma",
+          "options": {
+            "polyfills": [
+              "zone.js",
+              "zone.js/testing"
+            ],
+            "tsConfig": "projects/lib/tsconfig.spec.json",
+            "karmaConfig": "projects/lib/karma.conf.js"
+          }
         }
       }
     },
@@ -112,7 +123,9 @@
           "builder": "@angular/build:karma",
           "options": {
             "main": "projects/sample/src/test.ts",
-            "polyfills": "projects/sample/src/polyfills.ts",
+            "polyfills": [
+              "projects/sample/src/polyfills.ts"
+            ],
             "tsConfig": "projects/sample/tsconfig.spec.json",
             "karmaConfig": "projects/sample/karma.conf.js",
             "styles": [
@@ -152,7 +165,9 @@
               "projects/quickstart-demo/src/favicon.ico",
               "projects/quickstart-demo/src/assets"
             ],
-            "styles": ["projects/quickstart-demo/src/styles.css"],
+            "styles": [
+              "projects/quickstart-demo/src/styles.css"
+            ],
             "scripts": [],
             "extractLicenses": false,
             "sourceMap": true,
@@ -206,14 +221,18 @@
           "builder": "@angular/build:karma",
           "options": {
             "main": "projects/quickstart-demo/src/test.ts",
-            "polyfills": "projects/quickstart-demo/src/polyfills.ts",
+            "polyfills": [
+              "projects/quickstart-demo/src/polyfills.ts"
+            ],
             "tsConfig": "projects/quickstart-demo/tsconfig.spec.json",
             "karmaConfig": "projects/quickstart-demo/karma.conf.js",
             "assets": [
               "projects/quickstart-demo/src/favicon.ico",
               "projects/quickstart-demo/src/assets"
             ],
-            "styles": ["projects/quickstart-demo/src/styles.css"],
+            "styles": [
+              "projects/quickstart-demo/src/styles.css"
+            ],
             "scripts": []
           }
         }
@@ -364,7 +383,9 @@
   },
   "cli": {
     "analytics": false,
-    "schematicCollections": ["@angular-eslint/schematics"],
+    "schematicCollections": [
+      "@angular-eslint/schematics"
+    ],
     "packageManager": "npm"
   }
 }

package-lock.json

@@ -9,6 +9,7 @@
     "build": "npm run prettier && ng build --configuration production --project lib && npm run copy:readme && npm run copy:license && npm run docs",
     "build:jwks": "npm run prettier && ng build angular-oauth2-oidc-jwks --ts-config tsconfig.npm.json && npm run copyfiles:jwks",
     "test": "ng test",
+    "test:ci": "ng test lib --watch=false --browsers=ChromeHeadless && ng test sample --watch=false --browsers=ChromeHeadless && ng test quickstart-demo --watch=false --browsers=ChromeHeadless && ng test quickstart-standalone --watch=false --browsers=ChromeHeadless && ng test angular-oauth2-oidc-jwks --watch=false --browsers=ChromeHeadless",
     "lint": "ng lint lib",
     "e2e": "ng e2e",
     "tsc": "tsc",
@@ -74,6 +75,7 @@
     "karma": "~6.4.4",
     "karma-chrome-launcher": "~3.2.0",
     "karma-cli": "~2.0.0",
+    "karma-coverage": "~2.2.1",
     "karma-coverage-istanbul-reporter": "~3.0.3",
     "karma-jasmine": "~4.0.2",
     "karma-jasmine-html-reporter": "^1.7.0",

package.json

@@ -4,13 +4,13 @@
 module.exports = function(config) {
   config.set({
     basePath: '',
-    frameworks: ['jasmine', '@angular-devkit/build-angular'],
+    frameworks: ['jasmine'],
     plugins: [
       require('karma-jasmine'),
       require('karma-chrome-launcher'),
       require('karma-jasmine-html-reporter'),
-      require('karma-coverage-istanbul-reporter'),
-      require('@angular-devkit/build-angular/plugins/karma')
+      require('karma-coverage-istanbul-reporter')
+
     ],
     client: {
       clearContext: false // leave Jasmine Spec Runner output visible in browser

projects/angular-oauth2-oidc-jwks/karma.conf.js

@@ -0,0 +1,52 @@
+import { AbstractValidationHandler, ValidationParams } from 'angular-oauth2-oidc';
+import { JwksValidationHandler } from './jwks-validation-handler';
+
+describe('JwksValidationHandler', () => {
+  let handler: JwksValidationHandler;
+
+  beforeEach(() => {
+    handler = new JwksValidationHandler();
+  });
+
+  it('should be created', () => {
+    expect(handler).toBeTruthy();
+    expect(handler instanceof AbstractValidationHandler).toBe(true);
+  });
+
+  it('should allow the common JOSE signing algorithms by default', () => {
+    expect(handler.allowedAlgorithms).toContain('RS256');
+    expect(handler.allowedAlgorithms).toContain('ES256');
+    expect(handler.allowedAlgorithms).toContain('HS256');
+  });
+
+  it('should throw if no idToken is given', () => {
+    expect(() =>
+      handler.validateSignature({} as ValidationParams)
+    ).toThrowError('Parameter idToken expected!');
+  });
+
+  it('should throw if no idTokenHeader is given', () => {
+    expect(() =>
+      handler.validateSignature({ idToken: 'abc' } as ValidationParams)
+    ).toThrowError('Parameter idTokenHandler expected.');
+  });
+
+  it('should throw if no jwks is given', () => {
+    expect(() =>
+      handler.validateSignature({
+        idToken: 'abc',
+        idTokenHeader: { alg: 'RS256' },
+      } as ValidationParams)
+    ).toThrowError('Parameter jwks expected!');
+  });
+
+  it('should throw if jwks contains no keys', () => {
+    expect(() =>
+      handler.validateSignature({
+        idToken: 'abc',
+        idTokenHeader: { alg: 'RS256' },
+        jwks: { keys: [] },
+      } as unknown as ValidationParams)
+    ).toThrowError('Array keys in jwks missing!');
+  });
+});

projects/angular-oauth2-oidc-jwks/src/lib/jwks-validation-handler.spec.ts

@@ -4,13 +4,13 @@
 module.exports = function(config) {
   config.set({
     basePath: '',
-    frameworks: ['jasmine', '@angular-devkit/build-angular'],
+    frameworks: ['jasmine'],
     plugins: [
       require('karma-jasmine'),
       require('karma-chrome-launcher'),
       require('karma-jasmine-html-reporter'),
-      require('karma-coverage-istanbul-reporter'),
-      require('@angular-devkit/build-angular/plugins/karma')
+      require('karma-coverage-istanbul-reporter')
+
     ],
     client: {
       clearContext: false // leave Jasmine Spec Runner output visible in browser

projects/lib/karma.conf.js

@@ -0,0 +1,39 @@
+import { DefaultHashHandler } from './hash-handler';
+
+function toHex(rawHash: string): string {
+  return Array.from(rawHash)
+    .map((c) => c.charCodeAt(0).toString(16).padStart(2, '0'))
+    .join('');
+}
+
+describe('DefaultHashHandler', () => {
+  let handler: DefaultHashHandler;
+
+  beforeEach(() => {
+    handler = new DefaultHashHandler();
+  });
+
+  it('should calculate the correct sha-256 hash for a known vector', async () => {
+    const hash = await handler.calcHash('abc', 'sha-256');
+    expect(toHex(hash)).toEqual(
+      'ba7816bf8f01cfea414140de5dae2223b00361a396177a9cb410ff61f20015ad'
+    );
+  });
+
+  it('should return a 32 byte hash', async () => {
+    const hash = await handler.calcHash('some-nonce-value', 'sha-256');
+    expect(hash.length).toBe(32);
+  });
+
+  it('should be deterministic', async () => {
+    const a = await handler.calcHash('value', 'sha-256');
+    const b = await handler.calcHash('value', 'sha-256');
+    expect(a).toEqual(b);
+  });
+
+  it('should produce different hashes for different inputs', async () => {
+    const a = await handler.calcHash('value-a', 'sha-256');
+    const b = await handler.calcHash('value-b', 'sha-256');
+    expect(a).not.toEqual(b);
+  });
+});