transport vanishing fix#300
Merged
billy1arm merged 1 commit intomangoszero:masterfrom Apr 20, 2026
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transports that travel within a single zone have a problem where the client will silently drop the transport object when it goes out of visible range, making it invisible to a player the next time it comes around to the same dock. Presumably (because we are talking internal client logic here), this isn't a problem for Menethil harbor, etc style transports because they already send new Delete + Create packets whenever the transport crosses maps.
The proposed fix re-sends the delete + create packets for the transport to all in-zone players whenever the transport stops (docks). It seems to fix the problem, though I'm still suspicious as to why it works as well as it does.
P.S. I tried sending only create messages, and I tried sending delete+create only for players entering the zone -- nothing seemed to work, which is why I suspect it's about visbility range on the client side.
This change is