fix for bot revive-from-corpse#306
Open
bozimmerman wants to merge 1 commit intomangoszero:masterfrom
Open
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the problem with Bots not reviving when they are released and get back to their corpse.
The fix is to rename the "dead" trigger to "bot dead".
The code was such that I can't prove it 100%, but I am really sure that the cause is that, when converting a trigger name to an object, it iterates through ALL named contexts for a match, which means that it could hit a "dead" value or "dead" action or whatever before hitting the correct "dead" trigger. By making the name more unique, this doesn't happen.
Whether my causal theory is correct, the solution absolutely works and is otherwise harmless.
This change is