Skip to content

Typescript#31

Open
YovelNehmady wants to merge 6 commits into
maniac-tech:masterfrom
YovelNehmady:typescript
Open

Typescript#31
YovelNehmady wants to merge 6 commits into
maniac-tech:masterfrom
YovelNehmady:typescript

Conversation

@YovelNehmady

@YovelNehmady YovelNehmady commented Sep 19, 2023

Copy link
Copy Markdown

Description

In this PR I changed the JS files to TS files and added type to make this lib more easy to use.

Fixes # (issue)

#29 #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@maniac-tech

Copy link
Copy Markdown
Owner

@YovelNehmady : Is this ready for review?

@YovelNehmady

Copy link
Copy Markdown
Author

@maniac-tech: Yes.

@maniac-tech

Copy link
Copy Markdown
Owner

@YovelNehmady can you also create a PR in the example application consuming these changes ?

This way we can test, and update the sample application too.

@YovelNehmady

Copy link
Copy Markdown
Author

@maniac-tech Yes I can.

@maniac-tech

Copy link
Copy Markdown
Owner

@maniac-tech Yes I can.

Lets do that then

@YovelNehmady

Copy link
Copy Markdown
Author

@maniac-tech Yes I can.

Lets do that then

I am from Israel and we are currently at war so it will take me a little time to do this.

@maniac-tech

Copy link
Copy Markdown
Owner

@maniac-tech Yes I can.

Lets do that then

I am from Israel and we are currently at war so it will take me a little time to do this.

Take your time, and most importantly be safe @YovelNehmady !

@alokpant

Copy link
Copy Markdown
Contributor

@maniac-tech would you like me to complete this? Having typescript would be very helpful while working on the frontend.

@maniac-tech

Copy link
Copy Markdown
Owner

@maniac-tech would you like me to complete this? Having typescript would be very helpful while working on the frontend.

Sure!

@SrisharanVS

Copy link
Copy Markdown

Hi, is there any update in this PR?

@maniac-tech

Copy link
Copy Markdown
Owner

Wasn't able to check this so far. Will prioritize in the upcoming week.

@maukoese

Copy link
Copy Markdown

Hello, any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants