Skip to content

fix: SDK 51-54 support — dynamic build.gradle, peer dep range, remove deprecated APIs#99

Merged
maniac-tech merged 3 commits into
masterfrom
fix/tier-1-sdk-51-54-support
Mar 4, 2026
Merged

fix: SDK 51-54 support — dynamic build.gradle, peer dep range, remove deprecated APIs#99
maniac-tech merged 3 commits into
masterfrom
fix/tier-1-sdk-51-54-support

Conversation

@maniac-tech

@maniac-tech maniac-tech commented Mar 3, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes compatibility issues preventing the library from working on Expo SDK 51–54.
Bumps version to 9.1.1.


Changes

android/build.gradle

  • Fixed minSdkVersion from 3421 — the previous value was blocking any app targeting Android 5.0+, which is the vast majority of production apps
  • Made compileSdk and targetSdkVersion dynamic via safeExtGet() — the library now defers to the host app's values instead of hardcoding them
  • Changed react-native dependency from 0.73.6+ — picks up the host app's bundled version at build time, preventing version conflicts
  • Added Java 1.8 source/target compatibility

package.json

  • Version: 9.0.2-alpha9.1.1
  • peerDependencies: "react-native": "*"">=0.73" — accurately documents the minimum supported version (SDK 51 = RN 0.74) while staying compatible with all SDK 51–54 users
  • Added keywords: expo, otp

RNExpoReadSmsPackage.java

  • Removed deprecated createJSModules() override — this method was removed from the React Native API in RN 0.47 and its presence causes compile warnings/errors on newer RN versions

RNExpoReadSmsModule.java

  • Added explicit Build import
  • Set msgReceiver = null on stopReadSMS to prevent potential memory leaks
  • Minor comment cleanup

Testing

Verified against 4 TestApp branches:

Related

@maniac-tech maniac-tech self-assigned this Mar 3, 2026
@maniac-tech maniac-tech added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Mar 3, 2026

@maniac-tech maniac-tech left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with SDK versions 51 - 54. Good to merge,

@maniac-tech maniac-tech merged commit 69d17e0 into master Mar 4, 2026
3 checks passed
@maniac-tech maniac-tech deleted the fix/tier-1-sdk-51-54-support branch March 4, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix "return_statements" issue in index.js

1 participant