circus-evaluator: migrate evix 0.3.3 -> 2.0.1; eval fixes#133
Open
NotAShelf wants to merge 19 commits into
Open
circus-evaluator: migrate evix 0.3.3 -> 2.0.1; eval fixes#133NotAShelf wants to merge 19 commits into
NotAShelf wants to merge 19 commits into
Conversation
NotAShelf
force-pushed
the
notashelf/push-tmsskmtxkqtx
branch
from
June 27, 2026 15:59
0335dfe to
8cab644
Compare
NotAShelf
marked this pull request as draft
July 2, 2026 20:13
Member
Author
|
Needs to be updated to 1.2.0 |
amaanq
force-pushed
the
notashelf/push-tmsskmtxkqtx
branch
2 times, most recently
from
July 3, 2026 03:04
b48b6ee to
a765c28
Compare
Replace2 blocking `evaluate_cancellable` + `spawn_blocking` with the v1 async `Session::open(config).await?` + `session.stream()` drain loop. Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I6d77fd62f962d4b2ad9c7f42d8de44356a6a6964
… count Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: Ifb96aef86d352dbb2a17bf95210b99796a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: If8a502d8bfc7ef89c6e35f02bd519da46a6a6964
NotAShelf
force-pushed
the
notashelf/push-tmsskmtxkqtx
branch
from
July 12, 2026 09:37
fd8bacb to
100ccf1
Compare
NotAShelf
changed the title
NotAShelf
force-pushed
the
notashelf/push-tmsskmtxkqtx
branch
3 times, most recently
from
July 12, 2026 12:06
3b46c2f to
edb8f00
Compare
NotAShelf
changed the title
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: Icb2035c611ac45a66ec80691be4b61c36a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I1c3305276273f9ebbb74a2078c6930506a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: Id8b524cf17c20559b895b64cc8529e276a6a6964
…t/cancel helpers Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I474a60ef38b56128739fa94a433b77286a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I669a11f7e17036f194dfb2e04eb1636e6a6a6964
…cellation poller Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I9e60a3414ad8ea1e671a172dbc0fc79c6a6a6964
…art via dashboard Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: Ide6d8fe415cfff159577984f106af7286a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: If7d6a7875f9678089bd06e1e7a2abdc96a6a6964
NotAShelf
force-pushed
the
notashelf/push-tmsskmtxkqtx
branch
from
July 12, 2026 12:32
edb8f00 to
b3643a9
Compare
NotAShelf
marked this pull request as ready for review
July 12, 2026 12:38
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: Ife1808aa35d758f49b1a537be6075c7e6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I9c1f5447d4865b245b0b85fd1fde3d096a6a6964
NotAShelf
force-pushed
the
notashelf/push-tmsskmtxkqtx
branch
from
July 13, 2026 14:22
5d8c584 to
0a86f3f
Compare
NotAShelf
changed the title
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I722e9447acfb64dd898c540c2a164a8a6a6a6964
NotAShelf
force-pushed
the
notashelf/push-tmsskmtxkqtx
branch
from
July 14, 2026 04:56
0a86f3f to
91228a7
Compare
amaanq
requested changes
Jul 14, 2026
Comment on lines
+445
to
+487
| repo::evaluations::update_status( | ||
| repo::evaluations::finish_running( |
Member
There was a problem hiding this comment.
We should probably transition reused failed evaluations back to Running before this guarded update, since the conflict path only does that for Pending evaluations, meaning Failed falls through and reruns.
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I061874ad8c52cd82a427d598887494ef6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I18c89d26f662d132783545f9ed13582a6a6a6964
NotAShelf
force-pushed
the
notashelf/push-tmsskmtxkqtx
branch
from
July 16, 2026 06:39
8331f0d to
3189d47
Compare
amaanq
previously approved these changes
Jul 17, 2026
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I119568674e31cc7597a040d926ac4cec6a6a6964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
evixto the latest version and refactors the Nix evaluation logic to use the new asynchronous streaming API provided byevix. This makes the evaluation code slightly simpler and with my latest changes in nix-bindings the error handling for evaluations is improved slightly.Change-Id: I6d77fd62f962d4b2ad9c7f42d8de44356a6a6964