Fix/clean stack fix#178
Open
donhardman wants to merge 2 commits into
Open
Conversation
- Remove custom panic logging hooks and catch_unwind from FFI wrappers - Narrow lock scopes around model forward passes to reduce contention - Remove redundant contiguous calls during tensor to vector conversion - Simplify mutex acquisition and error handling in ONNX evaluations - Streamline text model creation and prediction logic - Clean up verbose FFI memory layout comments
- Set opt-level 1 for candle and gemm packages in dev profile - Reduce stack frame size to fit within 128KiB coroutine limit - Resolve silent memory corruption causing glibc heap aborts
Linux debug test results 8 files 8 suites 15m 25s ⏱️ For more details on these failures, see this check. Results for commit 55168f5. |
Linux release test results 8 files 8 suites 7m 55s ⏱️ Results for commit 55168f5. |
Windows test results 5 files 5 suites 18m 39s ⏱️ Results for commit 55168f5. |
Member
Author
|
We should merge it as it revert unnecessary changes that is was defensive to real root cause in the stack of the daemon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.