fix: pad StreamVByte decode input#193
Open
sanikolaev wants to merge 1 commit into
Open
Conversation
StreamVByte decoders can read past the exact compressed stream. Secondary index block data loaded from disk is rounded to uint32_t words, so provide explicit zero padding before decode instead of relying on adjacent memory. Related issue: #192
sanikolaev
force-pushed
the
fix/svb-decode-padding
branch
from
1bbefd9 to
0474209
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StreamVByte decoders can read past the exact compressed stream. Secondary index block data loaded from disk is rounded to uint32_t words, so provide explicit zero padding before decode instead of relying on adjacent memory.
Related issue: #192
Related PR in the daemon with tests: manticoresoftware/manticoresearch#4708