refactor(build): extract libxml2 dependency installation into separate function

Author: donhardman

build-alpine

@@ -42,11 +42,19 @@ install_deps() {
 
 install_dev_deps() {
   apk add gmp-dev judy-dev bsd-compat-headers m4
+}
 
-  install_libxml2
+install_libxml2_deps() {
+  test -d libxml2-2.10.3 && rm -fr libxml2-2.10.3
+  curl -sSL https://github.com/GNOME/libxml2/archive/refs/tags/v2.10.3.tar.gz | tar -xzf -
+  cd libxml2-2.10.3 && mkdir -p build && cd build
+  cmake -DBUILD_SHARED_LIBS=OFF -DLIBXML2_WITH_LZMA=OFF -DLIBXML2_WITH_PYTHON=OFF -DLIBXML2_WITH_ICONV=OFF -DCMAKE_BUILD_TYPE=Release ..
+  make -j4 && make install
+  cd ../..
+  rm -fr libxml2-2.10.3
 }
 
-export -f install_deps install_dev_deps install_rust
+export -f install_deps install_dev_deps install_libxml2_deps install_rust
 . build-bash-base.sh "$@"
 
 if [ "$BUILD_DEV" -eq 1 ]; then

build-bash-base.sh

@@ -27,6 +27,8 @@ fi
 if [[ -z "$SKIP_SYSTEM_DEPS"  || "$SKIP_SYSTEM_DEPS" == 0 ]]; then
   install_deps
 
+  install_libxml2_deps
+
   if [[ "$BUILD_DEV" == "1" ]]; then
     install_dev_deps
   fi
@@ -97,10 +99,7 @@ if [ "$(uname)" == "Darwin" ]; then
 fi
 cd ../..
 
-BUILD_EXTRA=()
-if [[ "$BUILD_DEV" == "1" ]]; then
-  BUILD_STATIC=0
-  BUILD_EXTRA=(
+BUILD_EXTRA=(
     "--enable-dom"
     "--with-libxml"
     "--enable-tokenizer"
@@ -109,20 +108,24 @@ if [[ "$BUILD_DEV" == "1" ]]; then
     "--enable-xmlreader"
     "--enable-simplexml"
     "--enable-phar"
-    # Little extra exts in case we will need it
-    "--enable-bcmath"
-    "--enable-ctype"
-    "--with-gmp"
-    # Profiling extensions
-    "--enable-debug"
-    # "--enable-memprof"
-    # "--enable-memprof-debug"
+  )
+  if [[ "$BUILD_DEV" == "1" ]]; then
+    BUILD_STATIC=0
+    BUILD_EXTRA+=(
+      # Little extra exts in case we will need it
+      "--enable-bcmath"
+      "--enable-ctype"
+      "--with-gmp"
+      # Profiling extensions
+      "--enable-debug"
+      # "--enable-memprof"
+      # "--enable-memprof-debug"
 		#
 		# It does not work with PHP 8.4.18
-    # "--enable-tideways-xhprof"
-    # "--enable-xdebug"
-  )
-fi
+      # "--enable-tideways-xhprof"
+      # "--enable-xdebug"
+    )
+  fi
 
 # Build main php
 mkdir dist

build-linux

@@ -34,7 +34,11 @@ install_dev_deps() {
   sudo apt-get install -y libonig-dev libgmp-dev libxml2-dev
 }
 
-export -f install_deps install_dev_deps install_rust
+install_libxml2_deps() {
+  sudo apt-get install -y libxml2-dev
+}
+
+export -f install_deps install_dev_deps install_libxml2_deps install_rust
 . build-bash-base.sh "$@"
 
 

build-osx

@@ -38,7 +38,11 @@ install_dev_deps() {
   brew install libxml2 oniguruma libgmp
 }
 
-export -f install_deps install_dev_deps install_rust
+install_libxml2_deps() {
+  brew install libxml2
+}
+
+export -f install_deps install_dev_deps install_libxml2_deps install_rust
 . ./build-bash-base.sh "$@"
 
 MAKE_LDFLAGS=