Skip to content

Commit defbddd

Browse files
authored
Merge pull request #75 from manticoresoftware/update/add_ext_iconv
Added iconv extension to fix issues with newer symfony/polyfill-mbstr…
2 parents 8398b07 + 2a85b25 commit defbddd

4 files changed

Lines changed: 10 additions & 7 deletions

File tree

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ We build executor from `PHP 8.4.2` with the following extensions enabled and com
3838
* openssl
3939
* zlib
4040
* mbstring
41+
* iconv
4142

4243
## Build from source
4344

build-alpine

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ install_deps() {
2222
ln -s /usr/bin/objcopy "/usr/bin/${arch}-alpine-linux-musl-objcopy"
2323
export CROSS_COMPILE="/usr/bin/${arch}-alpine-linux-musl-"
2424

25-
apk add curl git autoconf bison re2c pkgconf zlib-dev zstd-dev openssl-libs-static openssl-dev zlib-static zlib-dev
25+
apk add curl git autoconf bison re2c pkgconf zlib-dev zstd-dev openssl-libs-static openssl-dev zlib-static zlib-dev gnu-libiconv-dev
2626

2727
install_curl
2828

@@ -70,6 +70,7 @@ ENABLE_STATIC=yes
7070
--enable-sysvsem \
7171
--with-mysqli \
7272
--enable-mysqlnd \
73+
--with-iconv \
7374
"${BUILD_EXTRA[@]}"
7475

7576
fix_static_linking

build-linux

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ set -xe
1717

1818
install_deps() {
1919
sudo apt-get update -y
20-
sudo apt-get install -y curl build-essential autoconf automake bison re2c libzstd-dev pkg-config git libssl-dev zlib1g-dev libzip-dev libonig-dev cmake libcurl4-openssl-dev libzip-dev librdkafka-dev
20+
sudo apt-get install -y curl build-essential autoconf automake bison re2c libzstd-dev pkg-config git libssl-dev zlib1g-dev libzip-dev libonig-dev cmake libcurl4-openssl-dev libzip-dev librdkafka-dev libiconv-hook-dev
2121
}
2222

2323
install_dev_deps() {
@@ -47,7 +47,7 @@ ENABLE_STATIC=yes
4747
--with-rdkafka \
4848
--enable-jchash \
4949
--enable-simdjson \
50-
--with-openssl --with-zlib --with-zip \
50+
--with-openssl --with-zlib --with-zip --with-iconv \
5151
--enable-filter \
5252
--with-curl \
5353
--enable-mbstring \

build-osx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,17 @@
88

99
set -e
1010
install_deps() {
11-
brew install bash curl autoconf automake bison re2c zstd git openssl zlib cmake libzip librdkafka
11+
brew install bash curl autoconf automake bison re2c zstd git openssl zlib cmake libzip librdkafka libiconv
1212

1313
OPENSSL_PREFIX="$(brew --prefix openssl)"
1414
LIBRDKAFKA_PREFIX="$(brew --prefix librdkafka)"
15+
ICONV_PREFIX="$(brew --prefix libiconv)"
1516
OPENSSL_CFLAGS="-I${OPENSSL_PREFIX}/include"
1617
OPENSSL_LIBS="-L${OPENSSL_PREFIX}/lib -lcrypto -lssl"
1718
export OPENSSL_PREFIX OPENSSL_CFLAGS OPENSSL_LIBS
1819
export PATH="${OPENSSL_PREFIX}/bin:${PATH}"
19-
export LDFLAGS="-L${OPENSSL_PREFIX}/lib -L${LIBRDKAFKA_PREFIX}/lib"
20-
export CPPFLAGS="-I${OPENSSL_PREFIX}/include -I${LIBRDKAFKA_PREFIX}/include"
20+
export LDFLAGS="-L${OPENSSL_PREFIX}/lib -L${LIBRDKAFKA_PREFIX}/lib -L${ICONV_PREFIX}/lib"
21+
export CPPFLAGS="-I${OPENSSL_PREFIX}/include -I${LIBRDKAFKA_PREFIX}/include -I${ICONV_PREFIX}/include"
2122

2223
export PKG_CONFIG_PATH="${OPENSSL_PREFIX}/lib/pkgconfig"
2324
}
@@ -94,7 +95,7 @@ chmod +x configure
9495
--with-rdkafka \
9596
--enable-jchash \
9697
--enable-simdjson \
97-
--with-openssl --with-zlib --with-zip \
98+
--with-openssl --with-zlib --with-zip --with-iconv=$(brew --prefix libiconv) \
9899
--enable-filter \
99100
--with-curl \
100101
--enable-opcache \

0 commit comments

Comments
 (0)