feat: allow left table column prefix in JOIN#4326
Merged
Merged
Conversation
Contributor
|
Can't definitely say anything about the logic, but at first glance, passing advanced 'nullptr' in dozen of calls looks really weird. Especially facing the fact, that the last param - in most calls named 'tExprArgs' - that means, 'our dozens of nullptrs and another boring default params we decided to move (and pass) via this tuple of arguments'. In this struct they, at least, named. So, you don't need to enumerate dozen of 'nullptr', keeping in mind, which one means what. Sure, this bunch of explicit pararms should be eliminated. Who knows, m.b. after it 'files changed' will reduce to couple files of code + some files of doc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related discussion in public slack https://manticore-community.slack.com/archives/C7NSLK1NE/p1772552296680869