Skip to content

feat: allow left table column prefix in JOIN#4326

Merged
glookka merged 4 commits into
masterfrom
left-prefix
Apr 12, 2026
Merged

feat: allow left table column prefix in JOIN#4326
glookka merged 4 commits into
masterfrom
left-prefix

Conversation

@sanikolaev
Copy link
Copy Markdown
Collaborator

@sanikolaev sanikolaev commented Mar 4, 2026

@sanikolaev sanikolaev requested review from glookka and removed request for glookka March 4, 2026 05:14
@klirichek
Copy link
Copy Markdown
Contributor

klirichek commented Mar 4, 2026

Can't definitely say anything about the logic, but at first glance, passing advanced 'nullptr' in dozen of calls looks really weird. Especially facing the fact, that the last param - in most calls named 'tExprArgs' - that means, 'our dozens of nullptrs and another boring default params we decided to move (and pass) via this tuple of arguments'.

In this struct they, at least, named. So, you don't need to enumerate dozen of 'nullptr', keeping in mind, which one means what.

Sure, this bunch of explicit pararms should be eliminated. Who knows, m.b. after it 'files changed' will reduce to couple files of code + some files of doc.

@glookka glookka merged commit ca4687c into master Apr 12, 2026
60 checks passed
@glookka glookka deleted the left-prefix branch April 12, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants