Raise open file descriptors limit to avoid problem with pystack#40108
Merged
Conversation
MialLewis
approved these changes
Oct 14, 2025
Contributor
MialLewis
left a comment
There was a problem hiding this comment.
Looks good.
I've tested the change locally using the packaged produced by the CI and C++ stack traces are now again working.
SilkeSchomann
approved these changes
Oct 14, 2025
Contributor
SilkeSchomann
left a comment
There was a problem hiding this comment.
I've tested these changes on IDAaaS and can confirm that there is a normal stacktrace again instead of ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../.././libMantidJson.so output.
peterfpeterson
pushed a commit
to peterfpeterson/mantid
that referenced
this pull request
Oct 14, 2025
…idproject#40108) ### Description of work The recent problems with running `pystack` in the error reporter have been traced back to the fact that `pystack` was trying to open more file descriptors than the limit set on most linux systems. A pr into `pystack` has been made to improve their error messages (bloomberg/pystack#260). When this is a problem, you get a lot of this kind of output ``` ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../.././libMantidJson.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../.././libMantidJson.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../.././libMantidJson.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../.././libMantidJson.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../../libMantidTypes.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../../libMantidTypes.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../../libMantidTypes.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../../libMantidTypes.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../../libMantidPythonInterfaceCore.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../../libMantidPythonInterfaceCore.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../../libMantidPythonInterfaceCore.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../../libMantidPythonInterfaceCore. ``` The issue started after the first new instrument view pr went in (this commit mantidproject@8733e98#diff-4a6d6571d2c59705d8a673667672de2d7dcc3c756c61a3f0195acdefac52fe34). We're not that sure why, but it could be the addition of new libraries such as `pyvista`. This pr raises the limit (equivalent to `ulimit -n <value>`) for the outer mantid process, which may eventually launch the error reporter. ### To test: Package to test is at `mamba install jhaigh0/label/raise_open_files_limit::mantidworkbench` It would be good to test on idaaas where the core dump location is already set up. Run Segfault and check that the pystack output has been captured in the stacktrace field.
peterfpeterson
added a commit
that referenced
this pull request
Oct 14, 2025
This is a version of #40108 into `ornl-next` Co-authored-by: Jonathan Haigh <35813666+jhaigh0@users.noreply.github.com>
peterfpeterson
pushed a commit
to peterfpeterson/mantid
that referenced
this pull request
Oct 15, 2025
…idproject#40108) ### Description of work The recent problems with running `pystack` in the error reporter have been traced back to the fact that `pystack` was trying to open more file descriptors than the limit set on most linux systems. A pr into `pystack` has been made to improve their error messages (bloomberg/pystack#260). When this is a problem, you get a lot of this kind of output ``` ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../.././libMantidJson.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../.././libMantidJson.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../.././libMantidJson.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../.././libMantidJson.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../../libMantidTypes.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../../libMantidTypes.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../../libMantidTypes.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../../libMantidTypes.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../../libMantidPythonInterfaceCore.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../../libMantidPythonInterfaceCore.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../../libMantidPythonInterfaceCore.so ERROR(process_core): Cannot open ELF file /home/bya67386/mambaforge/envs/test_htlp_links/lib/python3.11/site-packages/mantid/kernel/../../../../libMantidPythonInterfaceCore. ``` The issue started after the first new instrument view pr went in (this commit mantidproject@8733e98#diff-4a6d6571d2c59705d8a673667672de2d7dcc3c756c61a3f0195acdefac52fe34). We're not that sure why, but it could be the addition of new libraries such as `pyvista`. This pr raises the limit (equivalent to `ulimit -n <value>`) for the outer mantid process, which may eventually launch the error reporter. ### To test: Package to test is at `mamba install jhaigh0/label/raise_open_files_limit::mantidworkbench` It would be good to test on idaaas where the core dump location is already set up. Run Segfault and check that the pystack output has been captured in the stacktrace field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
The recent problems with running
pystackin the error reporter have been traced back to the fact thatpystackwas trying to open more file descriptors than the limit set on most linux systems. A pr intopystackhas been made to improve their error messages (bloomberg/pystack#260).When this is a problem, you get a lot of this kind of output
The issue started after the first new instrument view pr went in (this commit 8733e98#diff-4a6d6571d2c59705d8a673667672de2d7dcc3c756c61a3f0195acdefac52fe34). We're not that sure why, but it could be the addition of new libraries such as
pyvista.This pr raises the limit (equivalent to
ulimit -n <value>) for the outer mantid process, which may eventually launch the error reporter.To test:
Package to test is at
mamba install jhaigh0/label/raise_open_files_limit::mantidworkbenchIt would be good to test on idaaas where the core dump location is already set up.
Run Segfault and check that the pystack output has been captured in the stacktrace field.
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
Gatekeeper
As per the gatekeeping guidelines: