When theres no ROIs, disable fitting buttons and plot empty spectrum#3124
Open
MikeSullivan7 wants to merge 2 commits into
Open
When theres no ROIs, disable fitting buttons and plot empty spectrum#3124MikeSullivan7 wants to merge 2 commits into
MikeSullivan7 wants to merge 2 commits into
Conversation
Collaborator
|
KeyError occurs here because no ROI is selected in the fitting form dropdown. |
8bb229f to
1736263
Compare
f340492 to
1736263
Compare
1736263 to
fcb2788
Compare
ashleymeigh2
approved these changes
May 19, 2026
Collaborator
|
looks good |
RasmiaKulan
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Closes #3123
Description
There are now checks when the Fitting Tab is activated so that when we are in ROI mode and all ROIs have been deleted from the table, an empty spectrum is plotted and the "From ROI" and "Run All Fit" buttons are disabled as there is no data to fit against.
Developer Testing
python -m pytest -vsAcceptance Criteria and Reviewer Testing
python -m pytest -vs