Reconstruction Window: Remove maximum projection angle field#3156
Merged
Conversation
|
coverage: 67.986% (-0.01%) from 67.998% — 1851-Remove_maximum_projection_angle_field into main |
ashleymeigh2
requested changes
May 19, 2026
| @property | ||
| def max_proj_angle(self) -> float: | ||
| return self.maxProjAngleSpinBox.value() | ||
| # @property |
Collaborator
There was a problem hiding this comment.
Can this not be removed?
Collaborator
Author
There was a problem hiding this comment.
It can be removed, I mustve forgotten it while testing 😅
RasmiaKulan
force-pushed
the
1851-Remove_maximum_projection_angle_field
branch
from
1217338 to
cf6153b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Closes #1851
Description
Removed the
Maximum projection anglefield from the reconstruction window along with any of its references. This is not required anymore as now there is no case where the value is used. If there is a geometry that is used instead of the value, if there is not a geometry then recon won't work.Developer Testing
python -m pytest -vsMaximum projection anglehad an impact on them in the reconstruction window.Acceptance Criteria and Reviewer Testing
python -m pytest -vsMaximum projection anglefield.Documentation and Additional Notes