From 8ab8f72c4037c9394fed4a48e44716d1080596a5 Mon Sep 17 00:00:00 2001
From: Marco Wobben <marcow@bcp-software.nl>
Date: Fri, 10 Apr 2026 11:48:45 +0200
Subject: [PATCH] Fix conflict between BBCodePlus and MantisCoreFormatting
 Markdown

When MantisCoreFormatting's Markdown mode is active, BBCodePlus was
calling string_strip_hrefs() which destroyed links rendered by the
Markdown parser (e.g. [text](url) -> <a href="url">text</a> -> "text").

Skip string_strip_hrefs when Markdown is active so Markdown-generated
links survive BBCodePlus's HTML->BBCode->HTML round-trip intact.

BBCode [tag] syntax and Markdown **syntax** are orthogonal and do not
conflict, so both plugins can be active simultaneously. This allows
sites with a mix of legacy BBCode tickets and newer Markdown tickets to
display correctly without disabling either plugin.

Removes the conflict warning in content_begin() as it is no longer
needed.
---
 BBCodePlus/BBCodePlus.php | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/BBCodePlus/BBCodePlus.php b/BBCodePlus/BBCodePlus.php
index d830256..f28ae75 100644
--- a/BBCodePlus/BBCodePlus.php
+++ b/BBCodePlus/BBCodePlus.php
@@ -85,13 +85,9 @@ function init() {
        * @return  void
        */
       function content_begin() {
-         if ( ON == $this->t_MantisCoreFormatting_process_markdown ) {
-            # display a warning if markdown processing is on.
-            $output = '<div class="alert alert-warning" id="check-notice-warnings">'.
-               plugin_lang_get( 'title' ) . ': '. plugin_lang_get( 'markdown_warning' ) . '</div>';
-         } else {
-            $output = '';
-         }
+         # BBCodePlus and MantisCoreFormatting Markdown can coexist: BBCode [tag] syntax and
+         # Markdown **syntax** are orthogonal and do not interfere with each other.
+         $output = '';
          # add image picker modal.
          $output .= '<div id="bbcodeplus-image-picker" class="bbcodeplus modal">';
          $output .= '<div class="bbcodeplus modal-content widget-box widget-color-blue2">';
@@ -308,7 +304,9 @@ function string_process_bbcode( $p_string, $p_multiline = TRUE ) {
          $p_string = preg_replace( '/<a href="([^"]*)" title="([^"]*)">([^"]*)<\/a>/is', '[url=$1]$3[/url]', $p_string);
          $p_string = preg_replace( '/<a href="([^"]*)" title="([^"]*)" class="resolved">([^"]*)<\/a>/is', '[url=$1 resolved]$3[/url]', $p_string);
          # strip all the auto generated URLs by MantisCoreFormatting plugin to avoid mangling.
-         if ( ON == $this->t_MantisCoreFormatting_process_urls ) {
+         # when markdown is active we must NOT strip hrefs, because MantisCoreFormatting renders
+         # markdown links ([text](url)) to <a> tags that we want to preserve, not destroy.
+         if ( ON == $this->t_MantisCoreFormatting_process_urls && OFF == $this->t_MantisCoreFormatting_process_markdown ) {
             $p_string = string_strip_hrefs( $p_string );
          }