Skip to content

Commit bc83d37

Browse files
sukvvonsukvvon
authored
test({react,preact}-query/useMutation): unify destructuring pattern in complex scenario tests (TanStack#10494)
test({react,preact}-query/useMutation): apply destructuring pattern to complex scenario tests
1 parent aad1bd5 commit bc83d37

2 files changed

Lines changed: 34 additions & 34 deletions

File tree

‎packages/preact-query/src/__tests__/useMutation.test.tsx‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1898,11 +1898,11 @@ describe('useMutation', () => {
18981898
function Page() {
18991899
const [result, setResult] = useState<string>('idle')
19001900

1901-
const createUserMutation = useMutation({
1901+
const { mutateAsync: createUserAsync } = useMutation({
19021902
mutationFn: (name: string) => sleep(10).then(() => ({ id: '1', name })),
19031903
})
19041904

1905-
const updateProfileMutation = useMutation({
1905+
const { mutateAsync: updateProfileAsync } = useMutation({
19061906
mutationFn: (userId: string) =>
19071907
sleep(10).then(() => `profile updated for ${userId}`),
19081908
})
@@ -1911,8 +1911,8 @@ describe('useMutation', () => {
19111911
<div>
19121912
<button
19131913
onClick={async () => {
1914-
const user = await createUserMutation.mutateAsync('John')
1915-
const profile = await updateProfileMutation.mutateAsync(user.id)
1914+
const user = await createUserAsync('John')
1915+
const profile = await updateProfileAsync(user.id)
19161916
setResult(profile)
19171917
}}
19181918
>
@@ -1938,14 +1938,14 @@ describe('useMutation', () => {
19381938
function Page() {
19391939
const [result, setResult] = useState<string>('idle')
19401940

1941-
const createUserMutation = useMutation({
1941+
const { mutateAsync: createUserAsync } = useMutation({
19421942
mutationFn: (_name: string) =>
19431943
sleep(10).then<{ id: string }>(() => {
19441944
throw new Error('create failed')
19451945
}),
19461946
})
19471947

1948-
const updateProfileMutation = useMutation({
1948+
const { mutateAsync: updateProfileAsync } = useMutation({
19491949
mutationFn: (userId: string) =>
19501950
sleep(10).then(() => `profile updated for ${userId}`),
19511951
})
@@ -1955,8 +1955,8 @@ describe('useMutation', () => {
19551955
<button
19561956
onClick={async () => {
19571957
try {
1958-
const user = await createUserMutation.mutateAsync('John')
1959-
const profile = await updateProfileMutation.mutateAsync(user.id)
1958+
const user = await createUserAsync('John')
1959+
const profile = await updateProfileAsync(user.id)
19601960
setResult(profile)
19611961
} catch (error) {
19621962
setResult(`error: ${(error as Error).message}`)
@@ -1984,7 +1984,7 @@ describe('useMutation', () => {
19841984
function Page() {
19851985
const [message, setMessage] = useState<string>('idle')
19861986

1987-
const submitMutation = useMutation({
1987+
const { mutate } = useMutation({
19881988
mutationFn: async (shouldFail: boolean) => {
19891989
await sleep(10)
19901990
if (shouldFail) {
@@ -1999,7 +1999,7 @@ describe('useMutation', () => {
19991999
<div>
20002000
<button
20012001
onClick={() =>
2002-
submitMutation.mutate(false, {
2002+
mutate(false, {
20032003
onSuccess: (result) => setMessage(`success: ${result}`),
20042004
onError: (error) => setMessage(`error: ${error.message}`),
20052005
})
@@ -2009,7 +2009,7 @@ describe('useMutation', () => {
20092009
</button>
20102010
<button
20112011
onClick={() =>
2012-
submitMutation.mutate(true, {
2012+
mutate(true, {
20132013
onSuccess: (result) => setMessage(`success: ${result}`),
20142014
onError: (error) => setMessage(`error: ${error.message}`),
20152015
})
@@ -2045,7 +2045,7 @@ describe('useMutation', () => {
20452045
function Page() {
20462046
const [message, setMessage] = useState<string>('idle')
20472047

2048-
const submitMutation = useMutation({
2048+
const { mutate } = useMutation({
20492049
mutationFn: async () => {
20502050
await sleep(10)
20512051
attempt++
@@ -2061,7 +2061,7 @@ describe('useMutation', () => {
20612061
<div>
20622062
<button
20632063
onClick={() =>
2064-
submitMutation.mutate(undefined, {
2064+
mutate(undefined, {
20652065
onSuccess: (result) => setMessage(`result: ${result}`),
20662066
onError: () => setMessage('failed, retrying...'),
20672067
})
@@ -2099,7 +2099,7 @@ describe('useMutation', () => {
20992099

21002100
const [successMessage, setSuccessMessage] = useState<string>('')
21012101

2102-
const deleteMutation = useMutation({
2102+
const { mutate } = useMutation({
21032103
mutationFn: (item: string) => sleep(10).then(() => item),
21042104
onMutate: (item) => {
21052105
const previousItems = [...items]
@@ -2119,7 +2119,7 @@ describe('useMutation', () => {
21192119
return (
21202120
<div>
21212121
{items.map((item) => (
2122-
<button key={item} onClick={() => deleteMutation.mutate(item)}>
2122+
<button key={item} onClick={() => mutate(item)}>
21232123
delete {item}
21242124
</button>
21252125
))}
@@ -2156,7 +2156,7 @@ describe('useMutation', () => {
21562156

21572157
const [message, setMessage] = useState<string>('')
21582158

2159-
const deleteMutation = useMutation({
2159+
const { mutate } = useMutation({
21602160
mutationFn: (item: string) =>
21612161
sleep(10).then(() => {
21622162
throw new Error(`Failed to delete ${item}`)
@@ -2181,7 +2181,7 @@ describe('useMutation', () => {
21812181
return (
21822182
<div>
21832183
{items.map((item) => (
2184-
<button key={item} onClick={() => deleteMutation.mutate(item)}>
2184+
<button key={item} onClick={() => mutate(item)}>
21852185
delete {item}
21862186
</button>
21872187
))}

‎packages/react-query/src/__tests__/useMutation.test.tsx‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1897,11 +1897,11 @@ describe('useMutation', () => {
18971897
function Page() {
18981898
const [result, setResult] = React.useState<string>('idle')
18991899

1900-
const createUserMutation = useMutation({
1900+
const { mutateAsync: createUserAsync } = useMutation({
19011901
mutationFn: (name: string) => sleep(10).then(() => ({ id: '1', name })),
19021902
})
19031903

1904-
const updateProfileMutation = useMutation({
1904+
const { mutateAsync: updateProfileAsync } = useMutation({
19051905
mutationFn: (userId: string) =>
19061906
sleep(10).then(() => `profile updated for ${userId}`),
19071907
})
@@ -1910,8 +1910,8 @@ describe('useMutation', () => {
19101910
<div>
19111911
<button
19121912
onClick={async () => {
1913-
const user = await createUserMutation.mutateAsync('John')
1914-
const profile = await updateProfileMutation.mutateAsync(user.id)
1913+
const user = await createUserAsync('John')
1914+
const profile = await updateProfileAsync(user.id)
19151915
setResult(profile)
19161916
}}
19171917
>
@@ -1937,14 +1937,14 @@ describe('useMutation', () => {
19371937
function Page() {
19381938
const [result, setResult] = React.useState<string>('idle')
19391939

1940-
const createUserMutation = useMutation({
1940+
const { mutateAsync: createUserAsync } = useMutation({
19411941
mutationFn: (_name: string) =>
19421942
sleep(10).then<{ id: string }>(() => {
19431943
throw new Error('create failed')
19441944
}),
19451945
})
19461946

1947-
const updateProfileMutation = useMutation({
1947+
const { mutateAsync: updateProfileAsync } = useMutation({
19481948
mutationFn: (userId: string) =>
19491949
sleep(10).then(() => `profile updated for ${userId}`),
19501950
})
@@ -1954,8 +1954,8 @@ describe('useMutation', () => {
19541954
<button
19551955
onClick={async () => {
19561956
try {
1957-
const user = await createUserMutation.mutateAsync('John')
1958-
const profile = await updateProfileMutation.mutateAsync(user.id)
1957+
const user = await createUserAsync('John')
1958+
const profile = await updateProfileAsync(user.id)
19591959
setResult(profile)
19601960
} catch (error) {
19611961
setResult(`error: ${(error as Error).message}`)
@@ -1983,7 +1983,7 @@ describe('useMutation', () => {
19831983
function Page() {
19841984
const [message, setMessage] = React.useState<string>('idle')
19851985

1986-
const submitMutation = useMutation({
1986+
const { mutate } = useMutation({
19871987
mutationFn: async (shouldFail: boolean) => {
19881988
await sleep(10)
19891989
if (shouldFail) {
@@ -1998,7 +1998,7 @@ describe('useMutation', () => {
19981998
<div>
19991999
<button
20002000
onClick={() =>
2001-
submitMutation.mutate(false, {
2001+
mutate(false, {
20022002
onSuccess: (result) => setMessage(`success: ${result}`),
20032003
onError: (error) => setMessage(`error: ${error.message}`),
20042004
})
@@ -2008,7 +2008,7 @@ describe('useMutation', () => {
20082008
</button>
20092009
<button
20102010
onClick={() =>
2011-
submitMutation.mutate(true, {
2011+
mutate(true, {
20122012
onSuccess: (result) => setMessage(`success: ${result}`),
20132013
onError: (error) => setMessage(`error: ${error.message}`),
20142014
})
@@ -2044,7 +2044,7 @@ describe('useMutation', () => {
20442044
function Page() {
20452045
const [message, setMessage] = React.useState<string>('idle')
20462046

2047-
const submitMutation = useMutation({
2047+
const { mutate } = useMutation({
20482048
mutationFn: async () => {
20492049
await sleep(10)
20502050
attempt++
@@ -2060,7 +2060,7 @@ describe('useMutation', () => {
20602060
<div>
20612061
<button
20622062
onClick={() =>
2063-
submitMutation.mutate(undefined, {
2063+
mutate(undefined, {
20642064
onSuccess: (result) => setMessage(`result: ${result}`),
20652065
onError: () => setMessage('failed, retrying...'),
20662066
})
@@ -2098,7 +2098,7 @@ describe('useMutation', () => {
20982098

20992099
const [successMessage, setSuccessMessage] = React.useState<string>('')
21002100

2101-
const deleteMutation = useMutation({
2101+
const { mutate } = useMutation({
21022102
mutationFn: (item: string) => sleep(10).then(() => item),
21032103
onMutate: (item) => {
21042104
const previousItems = [...items]
@@ -2118,7 +2118,7 @@ describe('useMutation', () => {
21182118
return (
21192119
<div>
21202120
{items.map((item) => (
2121-
<button key={item} onClick={() => deleteMutation.mutate(item)}>
2121+
<button key={item} onClick={() => mutate(item)}>
21222122
delete {item}
21232123
</button>
21242124
))}
@@ -2155,7 +2155,7 @@ describe('useMutation', () => {
21552155

21562156
const [message, setMessage] = React.useState<string>('')
21572157

2158-
const deleteMutation = useMutation({
2158+
const { mutate } = useMutation({
21592159
mutationFn: (item: string) =>
21602160
sleep(10).then(() => {
21612161
throw new Error(`Failed to delete ${item}`)
@@ -2180,7 +2180,7 @@ describe('useMutation', () => {
21802180
return (
21812181
<div>
21822182
{items.map((item) => (
2183-
<button key={item} onClick={() => deleteMutation.mutate(item)}>
2183+
<button key={item} onClick={() => mutate(item)}>
21842184
delete {item}
21852185
</button>
21862186
))}

0 commit comments

Comments
 (0)