Skip to content

[pull] main from TanStack:main #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Apr 14, 2026
Merged

[pull] main from TanStack:main #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aad1bd5
test({react,preact}-query/useMutation): add parallel 'mutateAsync' te…
sukvvon Apr 14, 2026
bc83d37
test({react,preact}-query/useMutation): unify destructuring pattern i…
sukvvon Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
174 changes: 157 additions & 17 deletions packages/preact-query/src/__tests__/useMutation.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1898,11 +1898,11 @@ describe('useMutation', () => {
function Page() {
const [result, setResult] = useState<string>('idle')

const createUserMutation = useMutation({
const { mutateAsync: createUserAsync } = useMutation({
mutationFn: (name: string) => sleep(10).then(() => ({ id: '1', name })),
})

const updateProfileMutation = useMutation({
const { mutateAsync: updateProfileAsync } = useMutation({
mutationFn: (userId: string) =>
sleep(10).then(() => `profile updated for ${userId}`),
})
Expand All @@ -1911,8 +1911,8 @@ describe('useMutation', () => {
<div>
<button
onClick={async () => {
const user = await createUserMutation.mutateAsync('John')
const profile = await updateProfileMutation.mutateAsync(user.id)
const user = await createUserAsync('John')
const profile = await updateProfileAsync(user.id)
setResult(profile)
}}
>
Expand All @@ -1938,14 +1938,14 @@ describe('useMutation', () => {
function Page() {
const [result, setResult] = useState<string>('idle')

const createUserMutation = useMutation({
const { mutateAsync: createUserAsync } = useMutation({
mutationFn: (_name: string) =>
sleep(10).then<{ id: string }>(() => {
throw new Error('create failed')
}),
})

const updateProfileMutation = useMutation({
const { mutateAsync: updateProfileAsync } = useMutation({
mutationFn: (userId: string) =>
sleep(10).then(() => `profile updated for ${userId}`),
})
Expand All @@ -1955,8 +1955,8 @@ describe('useMutation', () => {
<button
onClick={async () => {
try {
const user = await createUserMutation.mutateAsync('John')
const profile = await updateProfileMutation.mutateAsync(user.id)
const user = await createUserAsync('John')
const profile = await updateProfileAsync(user.id)
setResult(profile)
} catch (error) {
setResult(`error: ${(error as Error).message}`)
Expand Down Expand Up @@ -1984,7 +1984,7 @@ describe('useMutation', () => {
function Page() {
const [message, setMessage] = useState<string>('idle')

const submitMutation = useMutation({
const { mutate } = useMutation({
mutationFn: async (shouldFail: boolean) => {
await sleep(10)
if (shouldFail) {
Expand All @@ -1999,7 +1999,7 @@ describe('useMutation', () => {
<div>
<button
onClick={() =>
submitMutation.mutate(false, {
mutate(false, {
onSuccess: (result) => setMessage(`success: ${result}`),
onError: (error) => setMessage(`error: ${error.message}`),
})
Expand All @@ -2009,7 +2009,7 @@ describe('useMutation', () => {
</button>
<button
onClick={() =>
submitMutation.mutate(true, {
mutate(true, {
onSuccess: (result) => setMessage(`success: ${result}`),
onError: (error) => setMessage(`error: ${error.message}`),
})
Expand Down Expand Up @@ -2045,7 +2045,7 @@ describe('useMutation', () => {
function Page() {
const [message, setMessage] = useState<string>('idle')

const submitMutation = useMutation({
const { mutate } = useMutation({
mutationFn: async () => {
await sleep(10)
attempt++
Expand All @@ -2061,7 +2061,7 @@ describe('useMutation', () => {
<div>
<button
onClick={() =>
submitMutation.mutate(undefined, {
mutate(undefined, {
onSuccess: (result) => setMessage(`result: ${result}`),
onError: () => setMessage('failed, retrying...'),
})
Expand Down Expand Up @@ -2099,7 +2099,7 @@ describe('useMutation', () => {

const [successMessage, setSuccessMessage] = useState<string>('')

const deleteMutation = useMutation({
const { mutate } = useMutation({
mutationFn: (item: string) => sleep(10).then(() => item),
onMutate: (item) => {
const previousItems = [...items]
Expand All @@ -2119,7 +2119,7 @@ describe('useMutation', () => {
return (
<div>
{items.map((item) => (
<button key={item} onClick={() => deleteMutation.mutate(item)}>
<button key={item} onClick={() => mutate(item)}>
delete {item}
</button>
))}
Expand Down Expand Up @@ -2156,7 +2156,7 @@ describe('useMutation', () => {

const [message, setMessage] = useState<string>('')

const deleteMutation = useMutation({
const { mutate } = useMutation({
mutationFn: (item: string) =>
sleep(10).then(() => {
throw new Error(`Failed to delete ${item}`)
Expand All @@ -2181,7 +2181,7 @@ describe('useMutation', () => {
return (
<div>
{items.map((item) => (
<button key={item} onClick={() => deleteMutation.mutate(item)}>
<button key={item} onClick={() => mutate(item)}>
delete {item}
</button>
))}
Expand All @@ -2207,4 +2207,144 @@ describe('useMutation', () => {
expect(rendered.getByText('items: item1, item2, item3')).toBeInTheDocument()
expect(rendered.getByText('message: rollback')).toBeInTheDocument()
})

it('should be able to run multiple mutateAsync calls in parallel with Promise.all', async () => {
function Page() {
const [result, setResult] = useState<string>('idle')

const { mutateAsync } = useMutation({
mutationFn: (file: string) => sleep(10).then(() => `uploaded: ${file}`),
})

return (
<div>
<button
onClick={async () => {
const results = await Promise.all([
mutateAsync('file1'),
mutateAsync('file2'),
mutateAsync('file3'),
])
setResult(results.join(', '))
}}
>
upload all
</button>
<div>result: {result}</div>
</div>
)
}

const rendered = renderWithClient(queryClient, <Page />)

fireEvent.click(rendered.getByRole('button', { name: /upload all/i }))
await vi.advanceTimersByTimeAsync(11)

expect(
rendered.getByText(
'result: uploaded: file1, uploaded: file2, uploaded: file3',
),
).toBeInTheDocument()
})

it('should handle Promise.all rejection when one parallel mutateAsync call fails', async () => {
function Page() {
const [result, setResult] = useState<string>('idle')

const { mutateAsync } = useMutation({
mutationFn: async (file: string) => {
await sleep(10)
if (file === 'file2') {
throw new Error('upload failed')
}
return `uploaded: ${file}`
},
retry: false,
})

return (
<div>
<button
onClick={async () => {
try {
const results = await Promise.all([
mutateAsync('file1'),
mutateAsync('file2'),
mutateAsync('file3'),
])
setResult(results.join(', '))
} catch (error) {
setResult(`error: ${(error as Error).message}`)
}
}}
>
upload all
</button>
<div>result: {result}</div>
</div>
)
}

const rendered = renderWithClient(queryClient, <Page />)

fireEvent.click(rendered.getByRole('button', { name: /upload all/i }))
await vi.advanceTimersByTimeAsync(11)

expect(
rendered.getByText('result: error: upload failed'),
).toBeInTheDocument()
})

it('should handle partial failure in parallel mutateAsync calls with Promise.allSettled', async () => {
function Page() {
const [result, setResult] = useState<string>('idle')

const { mutateAsync } = useMutation({
mutationFn: async (file: string) => {
await sleep(10)
if (file === 'file2') {
throw new Error('upload failed')
}
return `uploaded: ${file}`
},
retry: false,
})

return (
<div>
<button
onClick={async () => {
const results = await Promise.allSettled([
mutateAsync('file1'),
mutateAsync('file2'),
mutateAsync('file3'),
])
const summary = results
.map((r) =>
r.status === 'fulfilled'
? r.value
: `error: ${r.reason.message}`,
)
.join(', ')
setResult(summary)
}}
>
upload all
</button>
<div>result: {result}</div>
</div>
)
}

const rendered = renderWithClient(queryClient, <Page />)

fireEvent.click(rendered.getByRole('button', { name: /upload all/i }))
await vi.advanceTimersByTimeAsync(11)

expect(
rendered.getByText(
'result: uploaded: file1, error: upload failed, uploaded: file3',
),
).toBeInTheDocument()
})
})
Loading
Loading