Ensure the squirrel instance for native member function call actually has userpointer type

z33ky · z33ky · commit a03e6b0d3510 · 2025-06-11T02:11:09.000+02:00
This prevents memory errors when incorrectly invoking native member
functions from Squirrel.
diff --git a/sp/src/vscript/vscript_squirrel.cpp b/sp/src/vscript/vscript_squirrel.cpp
@@ -1425,7 +1425,10 @@ SQInteger function_stub(HSQUIRRELVM vm)
 	if (pFunc->m_flags & SF_MEMBER_FUNC)
 	{
 		SQUserPointer self;
-		sq_getinstanceup(vm, 1, &self, nullptr);
+		if (SQ_FAILED(sq_getinstanceup(vm, 1, &self, nullptr)))
+		{
+			return sq_throwerror(vm, "Expected userpointer");
+		}
 
 		if (!self)
 		{

Original file line number	Diff line number	Diff line change
`@@ -1425,7 +1425,10 @@ SQInteger function_stub(HSQUIRRELVM vm)`
`1425`	`1425`	`if (pFunc->m_flags & SF_MEMBER_FUNC)`
`1426`	`1426`	`{`
`1427`	`1427`	`SQUserPointer self;`
`1428`		`- sq_getinstanceup(vm, 1, &self, nullptr);`
	`1428`	`+ if (SQ_FAILED(sq_getinstanceup(vm, 1, &self, nullptr)))`
	`1429`	`+ {`
	`1430`	`+ return sq_throwerror(vm, "Expected userpointer");`
	`1431`	`+ }`
`1429`	`1432`
`1430`	`1433`	`if (!self)`
`1431`	`1434`	`{`