Fix lack of bounds checking in pose parameter functions

Blixibon · Blixibon · commit b9af81eb3307 · 2026-05-16T16:55:25.000-05:00
diff --git a/sp/src/game/client/c_baseanimating.cpp b/sp/src/game/client/c_baseanimating.cpp
@@ -1468,7 +1468,7 @@ float C_BaseAnimating::GetPoseParameter( int iPoseParameter )
 	if ( pStudioHdr->GetNumPoseParameters() < iPoseParameter )
 		return 0.0f;
 
-	if ( iPoseParameter < 0 )
+	if ( iPoseParameter < 0 || iPoseParameter >= MAXSTUDIOPOSEPARAM )
 		return 0.0f;
 
 	return m_flPoseParameter[iPoseParameter];
@@ -6054,7 +6054,7 @@ float C_BaseAnimating::SetPoseParameter( CStudioHdr *pStudioHdr, int iParameter,
 		return flValue;
 	}
 
-	if (iParameter >= 0)
+	if (iParameter >= 0 || iParameter < MAXSTUDIOPOSEPARAM)
 	{
 		float flNewValue;
 		flValue = Studio_SetPoseParameter( pStudioHdr, iParameter, flValue, flNewValue );

Original file line number	Diff line number	Diff line change
`@@ -1468,7 +1468,7 @@ float C_BaseAnimating::GetPoseParameter( int iPoseParameter )`
`1468`	`1468`	`if ( pStudioHdr->GetNumPoseParameters() < iPoseParameter )`
`1469`	`1469`	`return 0.0f;`
`1470`	`1470`
`1471`		`- if ( iPoseParameter < 0 )`
	`1471`	`+ if ( iPoseParameter < 0 \|\| iPoseParameter >= MAXSTUDIOPOSEPARAM )`
`1472`	`1472`	`return 0.0f;`
`1473`	`1473`
`1474`	`1474`	`return m_flPoseParameter[iPoseParameter];`
`@@ -6054,7 +6054,7 @@ float C_BaseAnimating::SetPoseParameter( CStudioHdr *pStudioHdr, int iParameter,`
`6054`	`6054`	`return flValue;`
`6055`	`6055`	`}`
`6056`	`6056`
`6057`		`- if (iParameter >= 0)`
	`6057`	`+ if (iParameter >= 0 \|\| iParameter < MAXSTUDIOPOSEPARAM)`
`6058`	`6058`	`{`
`6059`	`6059`	`float flNewValue;`
`6060`	`6060`	`flValue = Studio_SetPoseParameter( pStudioHdr, iParameter, flValue, flNewValue );`