Skip to content

Commit 948b323

Browse files
kediarovpengdev
authored andcommitted
Remove targetSdk version from all libraries (internal-9434)
[Jira ticket](https://mapbox.atlassian.net/browse/MAPSSDK-849) Target SDK version is being removed for Android libraries: https://developer.android.com/reference/tools/gradle-api/7.4/com/android/build/api/dsl/LibraryBaseFlavor#targetSdk() Discussion: - I have added `lint.targetSdk` and `testOptions.targetSdk`. It does not seems to be required for every module but it takes a lot of effort to verify where it does, so it is safe to just add those, plus they are not forgotten in case of a need - Should it be added to changelog? Now I just add skip_changelog label cc @mapbox/nav-core-sdk cc @mapbox/3d-live-navigation cc @mapbox/search-sdk-android cc @mapbox/maps-android cc @mapbox/gl-native cc @mapbox/core-sdk cc @mapbox/search-sdk-native cc @mapbox/navnative --------- Co-authored-by: Peng Liu <peng.liu@mapbox.com> GitOrigin-RevId: 52c7abc36caaf2c91e23d6a1f833764096978319
1 parent 1a3c1ea commit 948b323

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

library/build.gradle.kts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,12 @@ apply(from = "${rootDir}/gradle/checkstyle.gradle")
99
android {
1010
compileSdk = libs.versions.compileSdk.get().toInt()
1111
namespace = "com.mapbox.android.gestures"
12+
lint {
13+
targetSdk = libs.versions.targetSdkVersion.get().toInt()
14+
}
1215

1316
defaultConfig {
1417
minSdk = libs.versions.minSdk.get().toInt()
15-
//noinspection ExpiredTargetSdkVersion
16-
targetSdk = libs.versions.targetSdkVersion.get().toInt()
1718
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
1819
}
1920

@@ -30,6 +31,7 @@ android {
3031
}
3132

3233
testOptions {
34+
targetSdk = libs.versions.targetSdkVersion.get().toInt()
3335
unitTests {
3436
isIncludeAndroidResources = true
3537
}

0 commit comments

Comments
 (0)