Enable more e18e rules

GitOrigin-RevId: 759e02a67c5364a669dab878bde3b22fe77a1148

Author: stepankuzmin

3d-style/data/bucket/building_bucket.ts

@@ -504,7 +504,7 @@ export class BuildingBucket implements BucketWithGroundEffect {
                 continue;
 
             let buildingId: number | null = null;
-            if (feature.properties && feature.properties.hasOwnProperty('building_id')) {
+            if (feature.properties && Object.hasOwn(feature.properties, 'building_id')) {
                 buildingId = Number(feature.properties['building_id']);
                 if (disabledBuildings.has(buildingId)) {
                     continue;
@@ -1473,7 +1473,7 @@ export class BuildingBucket implements BucketWithGroundEffect {
         // We use a lookup table to cache the results of the footprint search
         // to avoid searching through all footprints for every tile coordinate.
         const lookupKey = (x + EXTENT) * 4 * EXTENT + (y + EXTENT);
-        if (this.footprintLookup.hasOwnProperty(lookupKey)) {
+        if (Object.hasOwn(this.footprintLookup, lookupKey)) {
             const footprint = this.footprintLookup[lookupKey];
             return footprint ? {height: footprint.height, hidden: footprint.hiddenFlags !== BUILDING_VISIBLE} : undefined;
         }

3d-style/data/bucket/model_bucket.ts

@@ -243,7 +243,7 @@ class ModelBucket implements Bucket {
         for (const {feature, id, index, sourceLayerIndex} of features) {
             // use non numeric id, if in properties, too.
             const featureId = (id != null) ? id :
-                (feature.properties && feature.properties.hasOwnProperty("id")) ? feature.properties["id"] : undefined;
+                (feature.properties && Object.hasOwn(feature.properties, "id")) ? feature.properties["id"] : undefined;
             const evaluationFeature = toEvaluationFeature(feature, needGeometry);
 
             if (!this.layers[0]._featureFilter.filter(new EvaluationParameters(this.zoom, {worldview: this.worldview, activeFloors: options.activeFloors}), evaluationFeature, canonical))
@@ -305,7 +305,7 @@ class ModelBucket implements Bucket {
         for (const modelId in this.instancesPerModel) {
             const instances: PerModelAttributes = this.instancesPerModel[modelId];
             for (const id in states) {
-                if (instances.idToFeaturesIndex.hasOwnProperty(id)) {
+                if (Object.hasOwn(instances.idToFeaturesIndex, id)) {
                     const feature = instances.features[instances.idToFeaturesIndex[id]];
                     this.evaluate(feature, states[id], instances, true);
                     this.uploaded = false;

3d-style/data/bucket/tiled_3d_model_bucket.ts

@@ -593,7 +593,7 @@ class Tiled3dModelBucket implements Bucket {
         for (const nodeInfo of this.getNodesInfo()) {
             const footprint = nodeInfo.node.footprint;
             // Node is visible if its footprint passes the replacement check
-            nodeInfo.hiddenByReplacement = !!footprint && !activeReplacements.find(region => region.footprint === footprint);
+            nodeInfo.hiddenByReplacement = !!footprint && !activeReplacements.some(region => region.footprint === footprint);
         }
     }
 

3d-style/elevation/elevated_structures.ts

@@ -288,9 +288,9 @@ export class ElevatedStructures {
             }
             // Each edge of the exterior ring is a potential portal
             const exterior = polygon[0];
-            assert(exterior.length > 1 && pointsEqual(exterior[0], exterior[exterior.length - 1]));
+            assert(exterior.length > 1 && pointsEqual(exterior[0], exterior.at(-1)));
 
-            let prevEdgeHash = ElevatedStructures.computeEdgeHash(exterior[exterior.length - 2], exterior[exterior.length - 1]);
+            let prevEdgeHash = ElevatedStructures.computeEdgeHash(exterior[exterior.length - 2], exterior.at(-1));
 
             for (let i = 0; i < exterior.length - 1; i++) {
                 const a = exterior[i + 0];

3d-style/elevation/elevation_feature_parser.ts

@@ -69,7 +69,7 @@ class PropertyParser {
     }
 
     private get(name: string, required, setter: Setter, convert?: Convert): PropertyParser {
-        const value = this.feature.properties.hasOwnProperty(name) ? +this.feature.properties[name] : undefined;
+        const value = Object.hasOwn(this.feature.properties, name) ? +this.feature.properties[name] : undefined;
         if (this._valid && value !== undefined && !Number.isNaN(value)) {
             if (convert) {
                 setter(convert(value));

3d-style/render/draw_model.ts

@@ -781,7 +781,7 @@ function drawVectorLayerModels(painter: Painter, source: SourceCache, layer: Mod
     layer.modelManager = modelManager;
     const shadowRenderer = painter.shadowRenderer;
 
-    if (!layer._unevaluatedLayout._values.hasOwnProperty('model-id')) { return; }
+    if (!Object.hasOwn(layer._unevaluatedLayout._values, 'model-id')) { return; }
 
     const modelIdUnevaluatedProperty = layer._unevaluatedLayout._values['model-id'];
 

3d-style/render/shadow_renderer.ts

@@ -525,7 +525,7 @@ export class ShadowRenderer {
             const meterInTiles = tileToMeter(unwrappedTileID.canonical);
             const texelScale = 2.0 / transform.tileSize * EXTENT / this._shadowParameters.shadowMapResolution;
             const shadowTexelInTileCoords0 = texelScale * this._cascades[0].boundingSphereRadius;
-            const shadowTexelInTileCoords1 = texelScale * this._cascades[this._cascades.length - 1].boundingSphereRadius;
+            const shadowTexelInTileCoords1 = texelScale * this._cascades.at(-1).boundingSphereRadius;
             // Instanced model tiles could have smoothened (shared among neighbor faces) normals. Normal is not surface normal
             // and this is why it is needed to increase the offset. 3.0 in case of model-tile could be alternatively replaced by
             // 2.0 if normal would not get scaled by dotScale in shadow_normal_offset().

3d-style/source/model_loader.ts

@@ -377,7 +377,7 @@ function parseLegacyFootprintMesh(gltfNode: GLTFNode): FootprintMesh | null | un
         return null;
     }
 
-    if (vertices.length > 1 && vertices[vertices.length - 1].equals(vertices[0])) {
+    if (vertices.length > 1 && vertices.at(-1).equals(vertices[0])) {
         vertices.pop();
     }
 

3d-style/source/model_source.ts

@@ -202,7 +202,7 @@ class ModelSource extends Evented<SourceEvents> implements ISource {
                 orientation: [0, 0, 0]
             };
 
-            if (value.hasOwnProperty('orientation')) {
+            if (Object.hasOwn(value, 'orientation')) {
                 const orientation = value['orientation'] as Float32Array;
                 if (orientation) {
                     nodeOverride.orientation = orientation;

3d-style/style/style_layer/model_style_layer.ts

@@ -181,8 +181,8 @@ class ModelStyleLayer extends StyleLayer {
         for (const modelId in bucket.instancesPerModel) {
             const instances = bucket.instancesPerModel[modelId];
             const featureId = feature.id !== undefined ? feature.id :
-                (feature.properties && feature.properties.hasOwnProperty("id")) ? (feature.properties["id"] as string | number) : undefined;
-            if (instances.idToFeaturesIndex.hasOwnProperty(featureId)) {
+                (feature.properties && Object.hasOwn(feature.properties, "id")) ? (feature.properties["id"] as string | number) : undefined;
+            if (Object.hasOwn(instances.idToFeaturesIndex, featureId)) {
                 const modelFeature = instances.features[instances.idToFeaturesIndex[featureId]];
                 const model = modelManager.getModel(modelId, scope || this.scope);
                 if (!model) return false;