fix(GeolocateControl): include all GeolocationPositionError properties in error event#13597
Closed
lucavb wants to merge 1 commit intomapbox:mainfrom
Closed
fix(GeolocateControl): include all GeolocationPositionError properties in error event#13597lucavb wants to merge 1 commit intomapbox:mainfrom
lucavb wants to merge 1 commit intomapbox:mainfrom
Conversation
1e82bfb to
cf5ac98
Compare
cf5ac98 to
d58ce39
Compare
d58ce39 to
3072c19
Compare
3072c19 to
cb44ad0
Compare
…ositionError properties - Updated the error event to fire with a structured object containing code, message, and constants for PERMISSION_DENIED, POSITION_UNAVAILABLE, and TIMEOUT. - Added a unit test to verify that these properties are correctly passed through when an error occurs. GitOrigin-RevId: [your-rev-id]
cb44ad0 to
762b735
Compare
|
Hey, @lucavb 👋 Thanks for your contribution to Mapbox GL JS! Important: This repository does not accept direct merges. All changes go through our internal review process. What happens next:
Please respond to any review comments on this PR. For more details, see CONTRIBUTING.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses: #13576
Problem
In versions 3.15.0+, the GeolocateControl error event is missing
code,message,PERMISSION_DENIED,POSITION_UNAVAILABLE, andTIMEOUTproperties. Users only receive{ target, type }instead of the full error information.Root Cause
GeolocationPositionErroris a native DOM object with non-enumerable properties. When passed directly tonew Event('error', error), theEventconstructor usesObject.assign()which doesn't copy non-enumerable properties.Solution
Explicitly extract properties from
GeolocationPositionErrorwhen creating the error event, matching the pattern already used for thegeolocateevent (fixed in commit 9a1c893).Before:
After:
Here is a screenshot where I tested it in Firefox

Launch Checklist
@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes. (N/A)@mapbox/gl-nativeif this PR includes shader changes or needs a native port. (N/A)@mapbox/gl-nativeif this PR disables any test because it also needs to be disabled on their side. (N/A)gl-nativeto groom in the MAPSNAT JIRA queue if this PR includes shader changes or features not present in the native side or if it disables a test that's not disabled there. (N/A)