Disable dist sourcemaps for publish builds to prevent src 404s (internal-1596)#13648
Open
anthony0030 wants to merge 1 commit intomapbox:mainfrom
Open
Disable dist sourcemaps for publish builds to prevent src 404s (internal-1596)#13648anthony0030 wants to merge 1 commit intomapbox:mainfrom
anthony0030 wants to merge 1 commit intomapbox:mainfrom
Conversation
…nal-1596) Prevent sourcemap-related 404s in production error reporting by disabling distributable sourcemaps during publish builds. Background: Root cause was introduced in: Do not include source in NPM package (internal-1596) Commit: 8bbf4bd Since src/ is no longer shipped in the npm package, sourcemap sources pointing to src/* cause Honeybadger/browser fetch attempts to return 404. Changes: Add env-controlled sourcemap toggle for Rollup dist outputs. Set NO_DIST_SOURCEMAPS=true in prepublishOnly so publish artifacts are generated without .map files. Keep compiled JS output unchanged. Impact: Eliminates noisy Honeybadger 404s caused by missing src paths referenced by distributed sourcemaps. Maintains existing runtime behavior and bundle contents.
|
|
|
Hey, @anthony0030 👋 Thanks for your contribution to Mapbox GL JS! Important: This repository does not accept direct merges. All changes go through our internal review process. What happens next:
Please respond to any review comments on this PR. For more details, see CONTRIBUTING.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent sourcemap-related 404s in production error reporting by disabling distributable sourcemaps during publish builds.
Background:
Root cause was introduced in: Do not include source in NPM package (internal-1596) Commit: 8bbf4bd
Since src/ is no longer shipped in the npm package, sourcemap sources pointing to src/* cause Honeybadger/browser fetch attempts to return 404. Changes:
Add env-controlled sourcemap toggle for Rollup dist outputs. Set NO_DIST_SOURCEMAPS=true in prepublishOnly so publish artifacts are generated without .map files. Keep compiled JS output unchanged.
Impact:
Eliminates noisy Honeybadger 404s caused by missing src paths referenced by distributed sourcemaps. Maintains existing runtime behavior and bundle contents.
Launch Checklist
@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes.@mapbox/gl-nativeif this PR includes shader changes or needs a native port.@mapbox/gl-nativeif this PR disables any test because it also needs to be disabled on their side.gl-nativeto groom in the MAPSNAT JIRA queue if this PR includes shader changes or features not present in the native side or if it disables a test that's not disabled there.